alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jason Montleon <jmontleo@redhat.com>
To: pierre-louis.bossart@linux.intel.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
	ckeepax@opensource.cirrus.com, regressions@lists.linux.dev,
	jmontleo@redhat.com, cezary.rojewski@intel.com, tiwai@suse.com,
	broonie@kernel.org
Subject: [PATCH v2 1/2] ASoC: rt5514: fix legacy dai naming
Date: Thu,  3 Nov 2022 09:11:43 -0400	[thread overview]
Message-ID: <20221103131144.2942-1-jmontleo@redhat.com> (raw)
In-Reply-To: <87v8nwmgso.wl-tiwai@suse.de>

Starting with 6.0-rc1 these messages are logged and the sound card
is unavailable. Adding legacy_dai_naming to the rt5514-spi causes
it to function properly again.

[   16.928454] kbl_r5514_5663_max kbl_r5514_5663_max: ASoC: CPU DAI
spi-PRP0001:00 not registered
[   16.928561] platform kbl_r5514_5663_max: deferred probe pending
---
 sound/soc/codecs/rt5514-spi.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c
index 1a25a3787935..362663abcb89 100644
--- a/sound/soc/codecs/rt5514-spi.c
+++ b/sound/soc/codecs/rt5514-spi.c
@@ -298,13 +298,14 @@ static int rt5514_spi_pcm_new(struct snd_soc_component *component,
 }
 
 static const struct snd_soc_component_driver rt5514_spi_component = {
-	.name		= DRV_NAME,
-	.probe		= rt5514_spi_pcm_probe,
-	.open		= rt5514_spi_pcm_open,
-	.hw_params	= rt5514_spi_hw_params,
-	.hw_free	= rt5514_spi_hw_free,
-	.pointer	= rt5514_spi_pcm_pointer,
-	.pcm_construct	= rt5514_spi_pcm_new,
+	.name			= DRV_NAME,
+	.probe			= rt5514_spi_pcm_probe,
+	.open			= rt5514_spi_pcm_open,
+	.hw_params		= rt5514_spi_hw_params,
+	.hw_free		= rt5514_spi_hw_free,
+	.pointer		= rt5514_spi_pcm_pointer,
+	.pcm_construct		= rt5514_spi_pcm_new,
+	.legacy_dai_naming	= 1,
 };
 
 /**
-- 
2.37.3


  reply	other threads:[~2022-11-04  8:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 20:05 [PATCH] Fix kbl_rt5663_rt5514_max98927 regression Jason Montleon
2022-11-02 22:05 ` Pierre-Louis Bossart
2022-11-03  7:59   ` Takashi Iwai
2022-11-03  9:54     ` Charles Keepax
2022-11-03 11:13       ` Takashi Iwai
2022-11-03 13:11         ` Jason Montleon [this message]
2022-11-03 13:11           ` [PATCH v2 2/2] ASoC: rt5677: fix legacy dai naming Jason Montleon
2022-11-03 13:19           ` [PATCH v2 1/2] ASoC: rt5514: " Mark Brown
2022-11-03 13:21           ` Takashi Iwai
2022-11-03 13:24             ` Takashi Iwai
2022-11-03 15:00               ` Thorsten Leemhuis
2022-11-03 13:20         ` [PATCH] Fix kbl_rt5663_rt5514_max98927 regression Jason Montleon
2022-11-03 11:57 ` [PATCH] Fix kbl_rt5663_rt5514_max98927 regression #forregzbot Thorsten Leemhuis
2022-11-05 10:13   ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103131144.2942-1-jmontleo@redhat.com \
    --to=jmontleo@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=oder_chiou@realtek.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=regressions@lists.linux.dev \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).