Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes

From: Maxime Ripard <maxime@cerno.tech>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Abel Vesa" <abelvesa@kernel.org>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@gmail.com>,
	"David Lechner" <david@lechnology.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Prashant Gaikwad" <pgaikwad@nvidia.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Sekhar Nori" <nsekhar@ti.com>, "Shawn Guo" <shawnguo@kernel.org>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Vinod Koul" <vkoul@kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
	linux-phy@lists.infradead.org, linux-mips@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	linux-actions@lists.infradead.org, linux-clk@vger.kernel.org,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	patches@opensource.cirrus.com, linux-tegra@vger.kernel.org,
	linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes
Date: Wed, 22 Mar 2023 11:01:53 +0100	[thread overview]
Message-ID: <20230322100153.gzyznaukbdngcvko@houat> (raw)
In-Reply-To: <f804380a14c346fdbbf3286bcb40b3c2.sboyd@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

Hi Stephen,

On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote:
> Quoting Maxime Ripard (2022-11-04 06:17:17)
> > Hi,
> > 
> > This is a follow-up to a previous series that was printing a warning
> > when a mux has a set_parent implementation but is missing
> > determine_rate().
> > 
> > The rationale is that set_parent() is very likely to be useful when
> > changing the rate, but it's determine_rate() that takes the parenting
> > decision. If we're missing it, then the current parent is always going
> > to be used, and thus set_parent() will not be used. The only exception
> > being a direct call to clk_set_parent(), but those are fairly rare
> > compared to clk_set_rate().
> > 
> > Stephen then asked to promote the warning to an error, and to fix up all
> > the muxes that are in that situation first. So here it is :)
> > 
> > Let me know what you think,
> 
> What's the plan here? Are you going to resend?

It wasn't clear to me whether or not this was something that you wanted,
and I got some pushback on the drivers so I kind of forgot about it.

If you do want it (and it looks like you do), I'll resend it.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]