From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: Intel: hda: Fix SKL dai count
Date: Tue, 14 Jan 2020 10:13:20 -0600 [thread overview]
Message-ID: <2870108c-0484-ce5e-f04c-ce353f939e98@linux.intel.com> (raw)
In-Reply-To: <6bf3ef29-aed8-d69d-8bb6-9e81253e5547@intel.com>
On 1/14/20 5:18 AM, Cezary Rojewski wrote:
> On 2020-01-13 16:30, Pierre-Louis Bossart wrote:
>> On 1/13/20 5:40 AM, Cezary Rojewski wrote:
>>> With fourth pin added for iDisp for skl_dai, update SOF_SKL_DAI_NUM to
>>> account for the change. Without this, dais from the bottom of the list
>>> are skipped. In current state that's the case for 'Alt Analog CPU DAI'.
>>
>> Can you clarify if you are fixing an issue on TGL - which isn't
>> supported in the mainline? Or fixing an issue with SKL w/ HDaudio
>> support?
>
> This is not strictly connected to TGL but to any platform making use of
> 'skl_dai[]' within /sof/intel. Encountered this issue when playing with
> probes - my BEs added at the bottom of the list were omitted during
> component registration. Once debug flags in asoc were enabled,
> root-cause presented itself clearly.
ok.
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
>> FWIW, I couldn't make HDaudio codec support work on KBL, with the
>> changes in ASoC core, the HDaudio support is broken with the SKL
>> driver (or depends on an unreleased topology). See traces at:
>>
>> https://github.com/thesofproject/linux/pull/1667/commits/ae584cf633f232d9cf828bb599a1b620cd0b4fe0
>>
>
> We do have working cAVS 1.5 machines (e.g.: SKL, KBL, KBL-R, ABL..) with
> HDA on our end.
> Will checkout the existing "vanilla skylake" to filter the least amount
> of changes needed to enable it. However, this can lead to topology
> binary needed to be updated.
yes, that's the problem I faced, and since I don't have a clue how to
change the topology on SKL I commented out the hard-coded parts in the
machine driver.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-14 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 11:40 [alsa-devel] [PATCH] ASoC: SOF: Intel: hda: Fix SKL dai count Cezary Rojewski
2020-01-13 15:30 ` Pierre-Louis Bossart
2020-01-14 11:18 ` Cezary Rojewski
2020-01-14 16:13 ` Pierre-Louis Bossart [this message]
2020-01-17 15:44 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: Fix SKL dai count" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2870108c-0484-ce5e-f04c-ce353f939e98@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).