From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: Intel: hda: Fix SKL dai count
Date: Mon, 13 Jan 2020 09:30:30 -0600 [thread overview]
Message-ID: <f8e6c1b8-5508-fc5e-57ce-fc2c54e23414@linux.intel.com> (raw)
In-Reply-To: <20200113114054.9716-1-cezary.rojewski@intel.com>
On 1/13/20 5:40 AM, Cezary Rojewski wrote:
> With fourth pin added for iDisp for skl_dai, update SOF_SKL_DAI_NUM to
> account for the change. Without this, dais from the bottom of the list
> are skipped. In current state that's the case for 'Alt Analog CPU DAI'.
Can you clarify if you are fixing an issue on TGL - which isn't
supported in the mainline? Or fixing an issue with SKL w/ HDaudio support?
FWIW, I couldn't make HDaudio codec support work on KBL, with the
changes in ASoC core, the HDaudio support is broken with the SKL driver
(or depends on an unreleased topology). See traces at:
https://github.com/thesofproject/linux/pull/1667/commits/ae584cf633f232d9cf828bb599a1b620cd0b4fe0
>
> Fixes: ac42b142cd76 ("ASoC: SOF: Intel: hda: Add iDisp4 DAI")
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
> sound/soc/sof/intel/hda.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h
> index 47408ec0de40..a4d030bfeee1 100644
> --- a/sound/soc/sof/intel/hda.h
> +++ b/sound/soc/sof/intel/hda.h
> @@ -348,7 +348,7 @@
>
> /* Number of DAIs */
> #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
> -#define SOF_SKL_NUM_DAIS 14
> +#define SOF_SKL_NUM_DAIS 15
> #else
> #define SOF_SKL_NUM_DAIS 8
> #endif
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-14 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 11:40 [alsa-devel] [PATCH] ASoC: SOF: Intel: hda: Fix SKL dai count Cezary Rojewski
2020-01-13 15:30 ` Pierre-Louis Bossart [this message]
2020-01-14 11:18 ` Cezary Rojewski
2020-01-14 16:13 ` Pierre-Louis Bossart
2020-01-17 15:44 ` [alsa-devel] Applied "ASoC: SOF: Intel: hda: Fix SKL dai count" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8e6c1b8-5508-fc5e-57ce-fc2c54e23414@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).