Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure
@ 2020-10-13 13:39 Srinivasa Rao Mandadapu
  2020-10-13 15:15 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2020-10-13 13:39 UTC (permalink / raw)
  To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, plai,
	bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
	linux-arm-msm, alsa-devel, devicetree, linux-kernel
  Cc: V Sujith Kumar Reddy, Srinivasa Rao Mandadapu

From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>

Disable MI2S bit clock from PAUSE/STOP/SUSPEND usecase
instead of shutdown time. Acheive this by invoking
clk_disable_unprepare API from cpu daiops shutdown to
cpu daiops trigger.
This Fix is update to the below patch.
https://lore.kernel.org/patchwork/patch/1308101/

Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
---
 sound/soc/qcom/lpass-cpu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index ba2aca3..2dfb921 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b/sound/soc/qcom/lpass-cpu.c
@@ -88,8 +88,6 @@ static void lpass_cpu_daiops_shutdown(struct snd_pcm_substream *substream,
 {
 	struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai);
 
-	clk_disable_unprepare(drvdata->mi2s_bit_clk[dai->driver->id]);
-
 	clk_disable_unprepare(drvdata->mi2s_osr_clk[dai->driver->id]);
 }
 
@@ -324,6 +322,7 @@ static int lpass_cpu_daiops_trigger(struct snd_pcm_substream *substream,
 		if (ret)
 			dev_err(dai->dev, "error writing to i2sctl reg: %d\n",
 				ret);
+		clk_disable_unprepare(drvdata->mi2s_bit_clk[dai->driver->id]);
 		break;
 	}
 
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure
  2020-10-13 13:39 [PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure Srinivasa Rao Mandadapu
@ 2020-10-13 15:15 ` Mark Brown
  2020-10-14  4:19   ` Srinivasa Rao Mandadapu
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2020-10-13 15:15 UTC (permalink / raw)
  To: Srinivasa Rao Mandadapu
  Cc: devicetree, alsa-devel, bgoswami, V Sujith Kumar Reddy,
	linux-arm-msm, plai, tiwai, lgirdwood, robh+dt, bjorn.andersson,
	agross, srinivas.kandagatla, rohitkr, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

On Tue, Oct 13, 2020 at 07:09:46PM +0530, Srinivasa Rao Mandadapu wrote:
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> 
> Disable MI2S bit clock from PAUSE/STOP/SUSPEND usecase
> instead of shutdown time. Acheive this by invoking
> clk_disable_unprepare API from cpu daiops shutdown to
> cpu daiops trigger.

I'm missing patch 2 here?

> This Fix is update to the below patch.
> https://lore.kernel.org/patchwork/patch/1308101/

Fixes should be specified using tags like this:

  Fixes: commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency")

in the changelog.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure
  2020-10-13 15:15 ` Mark Brown
@ 2020-10-14  4:19   ` Srinivasa Rao Mandadapu
  0 siblings, 0 replies; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2020-10-14  4:19 UTC (permalink / raw)
  To: Mark Brown
  Cc: devicetree, alsa-devel, bgoswami, V Sujith Kumar Reddy,
	linux-arm-msm, plai, tiwai, lgirdwood, robh+dt, bjorn.andersson,
	agross, srinivas.kandagatla, rohitkr, linux-kernel

Thanks  Mark Brown for your time !!!

On 10/13/2020 8:45 PM, Mark Brown wrote:
> On Tue, Oct 13, 2020 at 07:09:46PM +0530, Srinivasa Rao Mandadapu wrote:
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Disable MI2S bit clock from PAUSE/STOP/SUSPEND usecase
>> instead of shutdown time. Acheive this by invoking
>> clk_disable_unprepare API from cpu daiops shutdown to
>> cpu daiops trigger.
> I'm missing patch 2 here?
No.. It's a single patch. By mistake I sent with wrong header.
>
>> This Fix is update to the below patch.
>> https://lore.kernel.org/patchwork/patch/1308101/
> Fixes should be specified using tags like this:
>
>    Fixes: commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency")
>
> in the changelog.
Thanks for your guidance. I will take care of it next time.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-13 13:39 [PATCH 1/2] Asoc: qcom: lpass-cpu: Fix clock disable failure Srinivasa Rao Mandadapu
2020-10-13 15:15 ` Mark Brown
2020-10-14  4:19   ` Srinivasa Rao Mandadapu

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git