* [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format
@ 2014-03-07 12:18 Peter Ujfalusi
2014-03-09 8:41 ` Mark Brown
2014-03-10 2:25 ` Li.Xiubo
0 siblings, 2 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2014-03-07 12:18 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: moinejf, alsa-devel, Li.Xiubo, kuninori.morimoto.gx
The "format" part of the property name is missing from the code.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/generic/simple-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 7cabcc5c8703..064b404ed252 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -165,7 +165,7 @@ static int asoc_simple_card_parse_of(struct device_node *node,
snd_soc_of_parse_card_name(&priv->snd_card, "simple-audio-card,name");
/* get CPU/CODEC common format via simple-audio-card,format */
- priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") &
+ priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,format") &
(SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK);
/* off-codec widgets */
--
1.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format
2014-03-07 12:18 [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format Peter Ujfalusi
@ 2014-03-09 8:41 ` Mark Brown
2014-03-10 2:25 ` Li.Xiubo
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2014-03-09 8:41 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: moinejf, alsa-devel, Li.Xiubo, Liam Girdwood, kuninori.morimoto.gx
[-- Attachment #1.1: Type: text/plain, Size: 149 bytes --]
On Fri, Mar 07, 2014 at 02:18:31PM +0200, Peter Ujfalusi wrote:
> The "format" part of the property name is missing from the code.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format
2014-03-07 12:18 [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format Peter Ujfalusi
2014-03-09 8:41 ` Mark Brown
@ 2014-03-10 2:25 ` Li.Xiubo
2014-03-10 7:53 ` Mark Brown
2014-03-10 9:54 ` Peter Ujfalusi
1 sibling, 2 replies; 5+ messages in thread
From: Li.Xiubo @ 2014-03-10 2:25 UTC (permalink / raw)
To: Peter Ujfalusi, Mark Brown, Liam Girdwood
Cc: moinejf, alsa-devel, kuninori.morimoto.gx
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -165,7 +165,7 @@ static int asoc_simple_card_parse_of(struct device_node
> *node,
> snd_soc_of_parse_card_name(&priv->snd_card, "simple-audio-card,name");
>
> /* get CPU/CODEC common format via simple-audio-card,format */
> - priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") &
> + priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,format")
@Peter
Sorry, the interface of snd_soc_of_parse_daifmt(struct device_node *np,
const char *prefix), it's intended not only to parse the 'XXX,format', but also
'XXX,continuous-clock', 'XXX, bitclock-inversion', 'XXX, frame-inversion',
'XXX,bitclock-master' and 'XXX,frame-master' at the same time.
Maybe just the comment here is not very correct.
Thanks,
--
Best Regards,
Xiubo
> &
> (SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK);
>
> /* off-codec widgets */
> --
> 1.9.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format
2014-03-10 2:25 ` Li.Xiubo
@ 2014-03-10 7:53 ` Mark Brown
2014-03-10 9:54 ` Peter Ujfalusi
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2014-03-10 7:53 UTC (permalink / raw)
To: Li.Xiubo
Cc: Peter Ujfalusi, moinejf, alsa-devel, Liam Girdwood, kuninori.morimoto.gx
[-- Attachment #1.1: Type: text/plain, Size: 480 bytes --]
On Mon, Mar 10, 2014 at 02:25:02AM +0000, Li.Xiubo@freescale.com wrote:
> Sorry, the interface of snd_soc_of_parse_daifmt(struct device_node *np,
> const char *prefix), it's intended not only to parse the 'XXX,format', but also
> 'XXX,continuous-clock', 'XXX, bitclock-inversion', 'XXX, frame-inversion',
> 'XXX,bitclock-master' and 'XXX,frame-master' at the same time.
> Maybe just the comment here is not very correct.
Yes, the comment needs fixing. I've dropped the patch.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format
2014-03-10 2:25 ` Li.Xiubo
2014-03-10 7:53 ` Mark Brown
@ 2014-03-10 9:54 ` Peter Ujfalusi
1 sibling, 0 replies; 5+ messages in thread
From: Peter Ujfalusi @ 2014-03-10 9:54 UTC (permalink / raw)
To: Li.Xiubo, Mark Brown, Liam Girdwood
Cc: moinejf, alsa-devel, kuninori.morimoto.gx
On 03/10/2014 04:25 AM, Li.Xiubo@freescale.com wrote:
>> --- a/sound/soc/generic/simple-card.c
>> +++ b/sound/soc/generic/simple-card.c
>> @@ -165,7 +165,7 @@ static int asoc_simple_card_parse_of(struct device_node
>> *node,
>> snd_soc_of_parse_card_name(&priv->snd_card, "simple-audio-card,name");
>>
>> /* get CPU/CODEC common format via simple-audio-card,format */
>> - priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") &
>> + priv->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,format")
>
>
> @Peter
>
> Sorry, the interface of snd_soc_of_parse_daifmt(struct device_node *np,
> const char *prefix), it's intended not only to parse the 'XXX,format', but also
> 'XXX,continuous-clock', 'XXX, bitclock-inversion', 'XXX, frame-inversion',
> 'XXX,bitclock-master' and 'XXX,frame-master' at the same time.
Yes, I overlooked that. I have not checked the snd_soc_of_parse_daifmt() before.
> Maybe just the comment here is not very correct.
Probably it would be better to re-word it since the code at this point only
interested on the i2s coding and the bit/frame inversion.
> Thanks,
>
> --
> Best Regards,
> Xiubo
>
>
>> &
>> (SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK);
>>
>> /* off-codec widgets */
>> --
>> 1.9.0
>>
>>
>
--
Péter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-10 9:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-07 12:18 [PATCH] ASoC: simple-card: Fix property name for simple-audio-card, format Peter Ujfalusi
2014-03-09 8:41 ` Mark Brown
2014-03-10 2:25 ` Li.Xiubo
2014-03-10 7:53 ` Mark Brown
2014-03-10 9:54 ` Peter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).