From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org, tiwai@suse.de,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: Re: [PATCH 13/14] ASoC: SOF: Intel: allow for coexistence between SOF and catpt drivers
Date: Thu, 19 Nov 2020 11:52:22 -0600 [thread overview]
Message-ID: <569716f0-a52f-e9af-dd83-5c622b8073d4@linux.intel.com> (raw)
In-Reply-To: <20201119140650.GA37066@sirena.org.uk>
On 11/19/20 8:06 AM, Mark Brown wrote:
> On Thu, Nov 12, 2020 at 04:38:24PM -0600, Pierre-Louis Bossart wrote:
>> Now that we have all the support needed for coexistence between ACPI
>> drivers for Broadwell, remove mutual exclusion in the Kconfig
>> file. The selection is done by playing with the snd_intel_dspcfg
>> module 'dsp_driver' parameter.
>
> This breaks x86 allmodconfig builds for me:
>
> /mnt/kernel/sound/soc/intel/atom/sst/sst_acpi.c: In function 'sst_acpi_probe':
> /mnt/kernel/sound/soc/intel/atom/sst/sst_acpi.c:251:8: error: implicit declaration of function 'snd_intel_acpi_dsp_driver_probe'; did you mean 'snd_intel_dsp_driver_probe'? [-Werror=implicit-function-declaration]
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> snd_intel_dsp_driver_probe
> /mnt/kernel/sound/soc/intel/catpt/device.c: In function 'catpt_acpi_probe':
> /mnt/kernel/sound/soc/intel/catpt/device.c:251:8: error: implicit declaration of function 'snd_intel_acpi_dsp_driver_probe'; did you mean 'snd_intel_dsp_driver_probe'? [-Werror=implicit-function-declaration]
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> snd_intel_dsp_driver_probe
> /mnt/kernel/sound/soc/sof/sof-acpi-dev.c: In function 'sof_acpi_probe':
> /mnt/kernel/sound/soc/sof/sof-acpi-dev.c:134:8: error: implicit declaration of function 'snd_intel_acpi_dsp_driver_probe'; did you mean 'snd_intel_dsp_driver_probe'? [-Werror=implicit-function-declaration]
> ret = snd_intel_acpi_dsp_driver_probe(dev, id->id);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> snd_intel_dsp_driver_probe
>
Humm, I just tried and it works fine for me on top of your for-5.11
branch. That error across the board seems weird, there's even a
fall-back with a static inline if the Kconfig is not selected.
Could it be that Patch3 was not applied somehow? That's where the
prototype was added.
next prev parent reply other threads:[~2020-11-19 17:53 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 22:38 [PATCH 00/14] ASoC: Intel/SOF: extend run-time driver selection to ACPI devices Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 01/14] ASoC: Intel: broadwell: add missing pm_ops Pierre-Louis Bossart
2020-11-13 11:17 ` Rojewski, Cezary
2020-11-12 22:38 ` [PATCH 02/14] ASoC: Intel: bdw-rt5677: " Pierre-Louis Bossart
2020-11-13 11:19 ` Rojewski, Cezary
2020-11-12 22:38 ` [PATCH 03/14] ALSA: hda: intel-dsp-config: add helper for ACPI DSP driver selection Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 04/14] ASoC: soc-acpi: add helper to identify parent driver Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 05/14] ASoC: Intel: boards: byt/cht: set card and driver name at run time Pierre-Louis Bossart
2021-04-25 18:13 ` youling257
2021-04-26 15:12 ` Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 06/14] ASoC: Intel: byt/cht: set pm ops dynamically Pierre-Louis Bossart
2020-11-17 17:18 ` Mark Brown
2020-11-17 17:39 ` Pierre-Louis Bossart
2020-11-18 13:31 ` Mark Brown
2020-11-12 22:38 ` [PATCH 07/14] ASoC: SOF: acpi: add dynamic selection of DSP driver Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 08/14] ASoC: Intel: Atom: " Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 09/14] ASoC: SOF: Intel: allow for coexistence between SOF and Atom/SST drivers Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 10/14] ALSA: hda: intel-dsp-config: add Broadwell ACPI DSP driver selection Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 11/14] ASoC: Intel: broadwell: set card and driver name dynamically Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 12/14] ASoC: Intel: catpt: add dynamic selection of DSP driver Pierre-Louis Bossart
2020-11-12 22:38 ` [PATCH 13/14] ASoC: SOF: Intel: allow for coexistence between SOF and catpt drivers Pierre-Louis Bossart
2020-11-19 14:06 ` Mark Brown
2020-11-19 17:52 ` Pierre-Louis Bossart [this message]
2020-11-19 18:25 ` Mark Brown
2020-11-12 22:38 ` [PATCH 14/14] ALSA: hda: intel-dsp-config: ignore dsp_driver parameter for PCI legacy devices Pierre-Louis Bossart
2020-11-12 23:04 ` [PATCH 00/14] ASoC: Intel/SOF: extend run-time driver selection to ACPI devices Rojewski, Cezary
2020-11-13 13:06 ` Rojewski, Cezary
2020-11-13 14:40 ` Pierre-Louis Bossart
2020-11-13 16:49 ` Mark Brown
2020-11-13 17:06 ` Hans de Goede
2020-11-16 15:39 ` Rojewski, Cezary
2020-11-16 17:47 ` Pierre-Louis Bossart
2020-11-17 14:04 ` Takashi Iwai
2020-11-17 17:31 ` Mark Brown
2020-11-17 17:46 ` Takashi Iwai
2020-11-17 22:13 ` Rojewski, Cezary
2020-11-17 22:53 ` Pierre-Louis Bossart
2020-11-18 20:15 ` Rojewski, Cezary
2020-11-18 20:25 ` Pierre-Louis Bossart
2020-11-20 15:40 ` Rojewski, Cezary
2020-11-20 16:48 ` Mark Brown
2020-11-20 17:10 ` Rojewski, Cezary
2020-11-20 18:06 ` Mark Brown
2020-11-20 21:02 ` Rojewski, Cezary
2020-11-23 17:35 ` Mark Brown
2020-11-24 11:56 ` Rojewski, Cezary
2020-11-24 14:01 ` Mark Brown
2020-11-24 14:15 ` Takashi Iwai
2020-11-24 16:07 ` Rojewski, Cezary
2020-11-24 16:14 ` Mark Brown
2020-11-24 16:14 ` Takashi Iwai
2020-11-24 16:12 ` Mark Brown
2020-11-18 7:49 ` Takashi Iwai
2020-11-18 20:59 ` Rojewski, Cezary
2020-11-20 21:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569716f0-a52f-e9af-dd83-5c622b8073d4@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).