From: Perry Yuan <perry979106@gmail.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"Yuan, Perry" <Perry.Yuan@dell.com>,
"pobrn@protonmail.com" <pobrn@protonmail.com>,
"oder_chiou@realtek.com" <oder_chiou@realtek.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"Limonciello, Mario" <Mario.Limonciello@dell.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Sun, 21 Mar 2021 23:32:45 +0800 [thread overview]
Message-ID: <58d2e2f2-e552-6ecf-b1c3-bf38ad5d2e35@gmail.com> (raw)
In-Reply-To: <ab14a0b2-3f3a-3796-8baf-76e635d82340@linux.intel.com>
Hi Pierre:
Thanks for your review!
On 2021/3/8 23:59, Pierre-Louis Bossart wrote:
>
>
>
>>>> module_param(force_rfkill, bool, 0444);
>>>> MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted
>>>> models");
>>>>
>>>> +
>>>
>>> spurious line change
>> I just want to make them separate with more space .
>> If it cause concern, I will remote the line in V5.
>
> it's fine to improve spaces/alignment, just do it in a separate patch.
>
>>
>>>
>>>> static const struct dmi_system_id dell_device_table[] __initconst
>>>> = {
>>>> {
>>>> .ident = "Dell laptop",
>>>> @@ -2205,11 +2209,17 @@ static int __init dell_init(void)
>>>> dell_laptop_register_notifier(&dell_laptop_notifier);
>>>>
>>>> if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
>>>> - dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) {
>>>> - micmute_led_cdev.brightness =
>>> ledtrig_audio_get(LED_AUDIO_MICMUTE);
>>>> - ret = led_classdev_register(&platform_device->dev,
>>> &micmute_led_cdev);
>>>> - if (ret < 0)
>>>> - goto fail_led;
>>>> +
>>> dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) {
>>>
>>> not sure why you changed the alignment?
>> The previous alignment is a little not correct.
>> So I adjust it
>> If it cause concern, will restore it to original shape.
>
> same here, use a different patch.
>
As you suggested,I should add the alignment change in another patch.
But if i keep the old alignment, the code will be very odd.
Seems like that I have to change the below code to new alignment in this
patch.
if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { <<--- changed back
if (!privacy_valid)
has_privacy = true;
else
has_privacy = false;
if (!has_privacy) {
micmute_led_cdev.brightness <<----------- new alignment
...
}
...
}
next prev parent reply other threads:[~2021-03-21 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 9:37 [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2021-03-01 14:28 ` Pierre-Louis Bossart
2021-03-08 9:49 ` Yuan, Perry
2021-03-08 15:59 ` Pierre-Louis Bossart
2021-03-21 15:32 ` Perry Yuan [this message]
2021-03-22 14:49 ` Pierre-Louis Bossart
2021-03-23 6:22 ` Yuan, Perry
2021-03-01 17:09 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58d2e2f2-e552-6ecf-b1c3-bf38ad5d2e35@gmail.com \
--to=perry979106@gmail.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).