From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Perry Yuan <perry979106@gmail.com>,
"Yuan, Perry" <Perry.Yuan@dell.com>,
"pobrn@protonmail.com" <pobrn@protonmail.com>,
"oder_chiou@realtek.com" <oder_chiou@realtek.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"Limonciello, Mario" <Mario.Limonciello@dell.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Mon, 22 Mar 2021 09:49:48 -0500 [thread overview]
Message-ID: <7e0fc125-5a26-47d6-aa2a-7cd1b2580adf@linux.intel.com> (raw)
In-Reply-To: <58d2e2f2-e552-6ecf-b1c3-bf38ad5d2e35@gmail.com>
> As you suggested,I should add the alignment change in another patch.
> But if i keep the old alignment, the code will be very odd.
> Seems like that I have to change the below code to new alignment in this
> patch.
>
> if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
> dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { <<--- changed back
> if (!privacy_valid)
> has_privacy = true;
> else
> has_privacy = false;
> if (!has_privacy) {
> micmute_led_cdev.brightness <<----------- new alignment
> ...
> }
> ...
> }
I don't get the point, sorry. The code above doesn't seem properly
indented or there were spurious tab/spaces conversions?
next prev parent reply other threads:[~2021-03-22 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 9:37 [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2021-03-01 14:28 ` Pierre-Louis Bossart
2021-03-08 9:49 ` Yuan, Perry
2021-03-08 15:59 ` Pierre-Louis Bossart
2021-03-21 15:32 ` Perry Yuan
2021-03-22 14:49 ` Pierre-Louis Bossart [this message]
2021-03-23 6:22 ` Yuan, Perry
2021-03-01 17:09 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e0fc125-5a26-47d6-aa2a-7cd1b2580adf@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=perry979106@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).