From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
mperttunen@nvidia.com, gregkh@linuxfoundation.org,
sboyd@kernel.org, tglx@linutronix.de, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: alsa-devel@alsa-project.org, pgaikwad@nvidia.com,
spujar@nvidia.com, linux-kernel@vger.kernel.org,
josephl@nvidia.com, linux-clk@vger.kernel.org, arnd@arndb.de,
daniel.lezcano@linaro.org, krzk@kernel.org,
mturquette@baylibre.com, devicetree@vger.kernel.org,
mmaddireddy@nvidia.com, markz@nvidia.com,
alexios.zavras@intel.com, broonie@kernel.org,
linux-tegra@vger.kernel.org, horms+renesas@verge.net.au,
tiwai@suse.com, allison@lohutok.net, pdeschrijver@nvidia.com,
lgirdwood@gmail.com, vidyas@nvidia.com,
Jisheng.Zhang@synaptics.com
Subject: Re: [alsa-devel] [PATCH v3 06/15] clk: tegra: Remove tegra_pmc_clk_init along with clk ids
Date: Sat, 7 Dec 2019 18:04:14 +0300 [thread overview]
Message-ID: <5938df22-2474-3950-fc33-3e19cbf3da9c@gmail.com> (raw)
In-Reply-To: <e342a6e7-f213-53b4-1388-23cf61cf6fbb@gmail.com>
07.12.2019 17:43, Dmitry Osipenko пишет:
> 07.12.2019 17:33, Dmitry Osipenko пишет:
>> 06.12.2019 05:48, Sowjanya Komatineni пишет:
>>> Current Tegra clock driver registers PMC clocks clk_out_1, clk_out_2,
>>> clk_out_3 and blink output in tegra_pmc_init() which does direct Tegra
>>> PMC access during clk_ops and these PMC register read and write access
>>> will not happen when PMC is in secure mode.
>>>
>>> Any direct PMC register access from non-secure world will not go
>>> through and all the PMC clocks and blink control are done in Tegra PMC
>>> driver with PMC as clock provider.
>>>
>>> This patch removes tegra_pmc_clk_init along with corresponding clk ids
>>> from Tegra clock driver.
>>>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>
>> [snip]
>>
>>> @@ -1230,9 +1222,6 @@ static struct tegra_clk_init_table init_table[] __initdata = {
>>
>>> { TEGRA30_CLK_PLL_A, TEGRA30_CLK_CLK_MAX, 564480000, 1 },
>>> { TEGRA30_CLK_PLL_A_OUT0, TEGRA30_CLK_CLK_MAX, 11289600, 1 },
>>> { TEGRA30_CLK_EXTERN1, TEGRA30_CLK_PLL_A_OUT0, 0, 1 },
>>
>> Perhaps these clocks do not need to be always-enabled?
>>
>> [snip]
>>
>
> Also, EXTERN1 parent configuration should be moved to the audio
> driver/device-tree as well.
Ah, I missed that it's done in the patch #10.
> Maybe it even makes sense to move the whole configuration, including
> PLLA. I don't see why clk driver need to do something for the audio driver.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-09 10:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 2:48 [alsa-devel] [PATCH v3 00/15] Move PMC clocks into Tegra PMC driver Sowjanya Komatineni
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 01/15] dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings Sowjanya Komatineni
2019-12-06 18:58 ` Michał Mirosław
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 02/15] dt-bindings: tegra: Convert Tegra PMC bindings to YAML Sowjanya Komatineni
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 03/15] soc: tegra: Add Tegra PMC clock registrations into PMC driver Sowjanya Komatineni
2019-12-07 14:28 ` Dmitry Osipenko
2019-12-07 15:47 ` Dmitry Osipenko
2019-12-07 15:53 ` Dmitry Osipenko
2019-12-07 16:00 ` Dmitry Osipenko
[not found] ` <78644d45-2ae3-121f-99fc-0a46f205907d@nvidia.com>
[not found] ` <b35916e1-c6ee-52ca-9111-5ae109437b6e@nvidia.com>
2019-12-09 20:12 ` Dmitry Osipenko
[not found] ` <ee1d39d4-9a57-da9b-fce6-8130dac1d2fd@nvidia.com>
2019-12-10 17:41 ` Dmitry Osipenko
[not found] ` <22a2f8bd-561d-f4c6-4eef-bb61095c53b2@nvidia.com>
2019-12-10 18:30 ` Dmitry Osipenko
[not found] ` <302d8483-513c-9c20-e4d4-1e24f2b317d6@nvidia.com>
2019-12-10 20:31 ` Dmitry Osipenko
[not found] ` <49da77dc-b346-68eb-9ef8-42cfb3221489@nvidia.com>
[not found] ` <3f1c9325-3017-62be-1e3b-82fd28540fdf@nvidia.com>
2019-12-10 17:41 ` Dmitry Osipenko
2019-12-11 15:10 ` Peter De Schrijver
2019-12-12 1:43 ` Dmitry Osipenko
2019-12-16 12:20 ` Peter De Schrijver
2019-12-16 14:23 ` Dmitry Osipenko
2019-12-16 15:11 ` Peter De Schrijver
2019-12-16 15:24 ` Peter De Schrijver
2019-12-16 15:49 ` Dmitry Osipenko
[not found] ` <8eb792ad-cded-05cc-93fc-763be7ee66aa@nvidia.com>
[not found] ` <bb966cf2-50f6-6729-7644-54d71d55bbcb@nvidia.com>
2019-12-12 1:39 ` Dmitry Osipenko
[not found] ` <01bf40ae-393d-3cb1-9ba2-acdd10385cb8@nvidia.com>
[not found] ` <56b7d160-6156-59e5-66ec-712d64e1927a@nvidia.com>
2019-12-12 22:13 ` Dmitry Osipenko
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 04/15] dt-bindings: soc: tegra-pmc: Add id for Tegra PMC blink control Sowjanya Komatineni
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 05/15] soc: pmc: Add blink output clock registration to Tegra PMC Sowjanya Komatineni
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 06/15] clk: tegra: Remove tegra_pmc_clk_init along with clk ids Sowjanya Komatineni
2019-12-07 14:33 ` Dmitry Osipenko
2019-12-07 14:43 ` Dmitry Osipenko
2019-12-07 15:04 ` Dmitry Osipenko [this message]
[not found] ` <c81ccd45-781e-0fce-4f20-65281b8c6119@nvidia.com>
2019-12-07 23:24 ` Dmitry Osipenko
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 07/15] dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings Sowjanya Komatineni
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 08/15] ASoC: tegra: Add audio mclk control through clk_out_1 and extern1 Sowjanya Komatineni
2019-12-07 14:58 ` Dmitry Osipenko
[not found] ` <2eeceabe-b5f0-6f9e-ff8c-4ac6167b7cc3@nvidia.com>
2019-12-09 20:06 ` Dmitry Osipenko
[not found] ` <79661e2f-dcd4-6dd5-9b4d-9dcc40de478a@nvidia.com>
2019-12-09 23:12 ` Dmitry Osipenko
[not found] ` <41a7325c-9bb9-f681-4d30-d19079869d12@nvidia.com>
2019-12-17 15:36 ` Dmitry Osipenko
[not found] ` <fc491006-a316-5910-acb1-659c768b1038@nvidia.com>
2019-12-17 16:16 ` Dmitry Osipenko
[not found] ` <8fabffb2-f03a-dccb-94b6-4db16604f57d@nvidia.com>
2019-12-17 16:46 ` Dmitry Osipenko
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 09/15] ASoC: tegra: Add fallback for audio mclk Sowjanya Komatineni
2019-12-06 17:49 ` Sowjanya Komatineni
2019-12-06 17:56 ` Greg KH
2019-12-09 16:40 ` Mark Brown
2019-12-09 20:31 ` Dmitry Osipenko
2019-12-09 20:47 ` Mark Brown
2019-12-10 18:24 ` Dmitry Osipenko
2019-12-10 18:59 ` Mark Brown
2019-12-12 2:17 ` Dmitry Osipenko
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 10/15] clk: tegra: Remove extern1 and cdev1 from clocks inittable Sowjanya Komatineni
2019-12-06 2:48 ` [alsa-devel] [PATCH v3 11/15] ARM: dts: tegra: Add clock-cells property to pmc Sowjanya Komatineni
2019-12-07 14:26 ` [alsa-devel] [PATCH v3 00/15] Move PMC clocks into Tegra PMC driver Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5938df22-2474-3950-fc33-3e19cbf3da9c@gmail.com \
--to=digetx@gmail.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=markz@nvidia.com \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=spujar@nvidia.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).