alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E
@ 2021-01-25  8:11 Kai Vehmanen
  2021-01-25 14:17 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Kai Vehmanen @ 2021-01-25  8:11 UTC (permalink / raw)
  To: alsa-devel, broonie
  Cc: Libin Yang, cezary.rojewski, kai.vehmanen, yang.jie,
	pierre-louis.bossart, lgirdwood, Hui Wang, Bard Liao

From: Libin Yang <libin.yang@intel.com>

Add flag "SOF_RT711_JD_SRC_JD2", flag "SOF_RT715_DAI_ID_FIX"
and "SOF_SDW_FOUR_SPK" to the Dell TGL-H based SKU "0A5E".

Signed-off-by: Libin Yang <libin.yang@intel.com>
Co-developed-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Reviewed-by: Bard Liao <bard.liao@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
 sound/soc/intel/boards/sof_sdw.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index ca968901ac96..6d0d6ef711e0 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -67,6 +67,16 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = {
 		.driver_data = (void *)(SOF_RT711_JD_SRC_JD2 |
 					SOF_RT715_DAI_ID_FIX),
 	},
+	{
+		.callback = sof_sdw_quirk_cb,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "0A5E")
+		},
+		.driver_data = (void *)(SOF_RT711_JD_SRC_JD2 |
+					SOF_RT715_DAI_ID_FIX |
+					SOF_SDW_FOUR_SPK),
+	},
 	{
 		.callback = sof_sdw_quirk_cb,
 		.matches = {
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E
  2021-01-25  8:11 [PATCH] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E Kai Vehmanen
@ 2021-01-25 14:17 ` Mark Brown
  2021-01-25 14:39   ` Jaroslav Kysela
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2021-01-25 14:17 UTC (permalink / raw)
  To: Kai Vehmanen, alsa-devel
  Cc: Libin Yang, cezary.rojewski, yang.jie, lgirdwood,
	pierre-louis.bossart, Hui Wang, Bard Liao

On Mon, 25 Jan 2021 10:11:17 +0200, Kai Vehmanen wrote:
> Add flag "SOF_RT711_JD_SRC_JD2", flag "SOF_RT715_DAI_ID_FIX"
> and "SOF_SDW_FOUR_SPK" to the Dell TGL-H based SKU "0A5E".

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E
      commit: 9ad9bc59dde106e56dd59ce2bec7c1b08e1f0eb4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E
  2021-01-25 14:17 ` Mark Brown
@ 2021-01-25 14:39   ` Jaroslav Kysela
  0 siblings, 0 replies; 3+ messages in thread
From: Jaroslav Kysela @ 2021-01-25 14:39 UTC (permalink / raw)
  To: Mark Brown, Kai Vehmanen, alsa-devel
  Cc: Libin Yang, cezary.rojewski, yang.jie, lgirdwood,
	pierre-louis.bossart, Hui Wang, Bard Liao

Dne 25. 01. 21 v 15:17 Mark Brown napsal(a):
> On Mon, 25 Jan 2021 10:11:17 +0200, Kai Vehmanen wrote:
>> Add flag "SOF_RT711_JD_SRC_JD2", flag "SOF_RT715_DAI_ID_FIX"
>> and "SOF_SDW_FOUR_SPK" to the Dell TGL-H based SKU "0A5E".
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/1] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E
>       commit: 9ad9bc59dde106e56dd59ce2bec7c1b08e1f0eb4

Hi Mark,

Those fw selection related patches should be applied together to enable support for this machine, too:

ASoC: SOF: allow soundwire use desc->default_fw_filename
  https://lore.kernel.org/alsa-devel/20210125070500.807474-1-kai.vehmanen@linux.intel.com/
ASoC: Intel: tgl: remove sof_fw_filename set for tgl_3_in_1_default
  https://lore.kernel.org/alsa-devel/20210125070500.807474-2-kai.vehmanen@linux.intel.com/

Unrelated to this machine but a cleanup for future:

ASoC: Intel: adl: remove sof_fw_filename setting in ADL snd_soc_acpi_mach
  https://lore.kernel.org/alsa-devel/20210125070500.807474-3-kai.vehmanen@linux.intel.com/

					Thank you,
						Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-25 14:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25  8:11 [PATCH] ASoC: Intel: sof_sdw: set proper flags for Dell TGL-H SKU 0A5E Kai Vehmanen
2021-01-25 14:17 ` Mark Brown
2021-01-25 14:39   ` Jaroslav Kysela

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).