Re: [PATCH v3 0/7] ASoC: add soc-link

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 5/21/20 7:13 PM, Kuninori Morimoto wrote:
> 
> Hi Mark
> 
> Current ALSA SoC is handling dai_link related operation,
> but it is implmemented directly without using function/macro,
> and at random place.
> 
> This v3 patch-set creates new snd_soc_link_xxx() functions
> which handles dai_link related operation,
> and implmement these at new soc-link.c.

For the series

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
> v2 -> v3
> 
> 	- add missing #include <sound/soc-link.h> in soc-link.c
> 
> v1 -> v2
> 	- #include <sound/soc-link.h> is added on each c source file
> 	  instead of soc.h
> 	- not have extra error message after snd_soc_link_xxx(),
> 	  because it already indicate it via snc_link_ret()
> 	- snd_soc_link_compr_xxx() doesn't have rtd parameter,
> 	  because it can be created from cstream
> 
> Link: https://lore.kernel.org/r/874ksa59wc.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/877dx868op.wl-kuninori.morimoto.gx@renesas.com
> 
> Kuninori Morimoto (7):
>    ASoC: add soc-link.c
>    ASoC: soc-link: move soc_rtd_xxx()
>    ASoC: soc-link: remove unneeded parameter from snd_soc_link_xxx()
>    ASoC: soc-link: add snd_soc_link_be_hw_params_fixup()
>    ASoC: soc-link: add snd_soc_link_compr_startup()
>    ASoC: soc-link: add snd_soc_link_compr_shutdown()
>    ASoC: soc-link: add snd_soc_link_compr_set_params()
> 
>   include/sound/soc-link.h |  27 +++++++
>   sound/soc/Makefile       |   2 +-
>   sound/soc/soc-compress.c |  46 ++++--------
>   sound/soc/soc-core.c     |  18 ++---
>   sound/soc/soc-dai.c      |   9 ++-
>   sound/soc/soc-link.c     | 150 +++++++++++++++++++++++++++++++++++++++
>   sound/soc/soc-pcm.c      |  86 ++++------------------
>   7 files changed, 219 insertions(+), 119 deletions(-)
>   create mode 100644 include/sound/soc-link.h
>   create mode 100644 sound/soc/soc-link.c
>