* [PATCH v3 28/56] slimbus: fix a kernel-doc markup
[not found] <cover.1603469755.git.mchehab+huawei@kernel.org>
@ 2020-10-23 16:33 ` Mauro Carvalho Chehab
2020-10-26 14:52 ` Srinivas Kandagatla
2020-10-23 16:33 ` [PATCH v3 48/56] sound: fix kernel-doc markups Mauro Carvalho Chehab
1 sibling, 1 reply; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2020-10-23 16:33 UTC (permalink / raw)
To: Linux Doc Mailing List
Cc: Mauro Carvalho Chehab, alsa-devel, Srinivas Kandagatla,
linux-kernel, Jonathan Corbet
Fix the name of the enum on its kernel-doc markup:
enum slim_ch_aux_fmt -> enum slim_ch_aux_bit_fmt
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/slimbus/slimbus.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h
index c73035915f1d..00a7f112574b 100644
--- a/drivers/slimbus/slimbus.h
+++ b/drivers/slimbus/slimbus.h
@@ -244,7 +244,7 @@ enum slim_ch_data_fmt {
};
/**
- * enum slim_ch_aux_fmt: SLIMbus channel Aux Field format IDs according to
+ * enum slim_ch_aux_bit_fmt: SLIMbus channel Aux Field format IDs according to
* Table 63 of SLIMbus Spec 2.0
* @SLIM_CH_AUX_FMT_NOT_APPLICABLE: Undefined
* @SLIM_CH_AUX_FMT_ZCUV_TUNNEL_IEC60958: ZCUV for tunneling IEC60958
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 48/56] sound: fix kernel-doc markups
[not found] <cover.1603469755.git.mchehab+huawei@kernel.org>
2020-10-23 16:33 ` [PATCH v3 28/56] slimbus: fix a kernel-doc markup Mauro Carvalho Chehab
@ 2020-10-23 16:33 ` Mauro Carvalho Chehab
2020-10-23 18:26 ` Mark Brown
2020-10-26 13:46 ` Takashi Iwai
1 sibling, 2 replies; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2020-10-23 16:33 UTC (permalink / raw)
To: Linux Doc Mailing List
Cc: alsa-devel, Lars-Peter Clausen, Arnd Bergmann, Baolin Wang,
Mauro Carvalho Chehab, linux-kernel, Jonathan Corbet,
Liam Girdwood, Michał Mirosław, Vinod Koul, Mark Brown,
Takashi Iwai, paulhsia, Dan Carpenter
Kernel-doc markups should use this format:
identifier - description
There is a common comment marked, instead, with kernel-doc
notation.
Some identifiers have different names between their prototypes
and the kernel-doc markup.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
include/sound/core.h | 3 ++-
include/sound/pcm.h | 4 ++--
include/uapi/sound/compress_offload.h | 2 +-
sound/core/control.c | 4 ++--
sound/core/pcm_dmaengine.c | 3 ++-
sound/core/pcm_lib.c | 2 +-
sound/core/pcm_native.c | 4 ++--
sound/soc/soc-core.c | 2 +-
sound/soc/soc-dapm.c | 2 +-
9 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/include/sound/core.h b/include/sound/core.h
index 381a010a1bd4..0462c577d7a3 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -332,7 +332,8 @@ void __snd_printk(unsigned int level, const char *file, int line,
#define snd_BUG() WARN(1, "BUG?\n")
/**
- * Suppress high rates of output when CONFIG_SND_DEBUG is enabled.
+ * snd_printd_ratelimit - Suppress high rates of output when
+ * CONFIG_SND_DEBUG is enabled.
*/
#define snd_printd_ratelimit() printk_ratelimit()
diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index 2ba5df2c9e23..2336bf9243e1 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -1284,8 +1284,8 @@ snd_pcm_sgbuf_get_ptr(struct snd_pcm_substream *substream, unsigned int ofs)
}
/**
- * snd_pcm_sgbuf_chunk_size - Compute the max size that fits within the contig.
- * page from the given size
+ * snd_pcm_sgbuf_get_chunk_size - Compute the max size that fits within the
+ * contig. page from the given size
* @substream: PCM substream
* @ofs: byte offset
* @size: byte size to examine
diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
index 7184265c0b0d..9555f31c8425 100644
--- a/include/uapi/sound/compress_offload.h
+++ b/include/uapi/sound/compress_offload.h
@@ -144,7 +144,7 @@ struct snd_compr_metadata {
__u32 value[8];
} __attribute__((packed, aligned(4)));
-/**
+/*
* compress path ioctl definitions
* SNDRV_COMPRESS_GET_CAPS: Query capability of DSP
* SNDRV_COMPRESS_GET_CODEC_CAPS: Query capability of a codec
diff --git a/sound/core/control.c b/sound/core/control.c
index 421ddc76f264..4373de42a5a0 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1925,8 +1925,8 @@ EXPORT_SYMBOL(snd_ctl_unregister_ioctl);
#ifdef CONFIG_COMPAT
/**
- * snd_ctl_unregister_ioctl - de-register the device-specific compat 32bit
- * control-ioctls
+ * snd_ctl_unregister_ioctl_compat - de-register the device-specific compat
+ * 32bit control-ioctls
* @fcn: ioctl callback function to unregister
*/
int snd_ctl_unregister_ioctl_compat(snd_kctl_ioctl_func_t fcn)
diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c
index 4d059ff2b2e4..4d0e8fe535a1 100644
--- a/sound/core/pcm_dmaengine.c
+++ b/sound/core/pcm_dmaengine.c
@@ -356,7 +356,8 @@ int snd_dmaengine_pcm_close(struct snd_pcm_substream *substream)
EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_close);
/**
- * snd_dmaengine_pcm_release_chan_close - Close a dmaengine based PCM substream and release channel
+ * snd_dmaengine_pcm_close_release_chan - Close a dmaengine based PCM
+ * substream and release channel
* @substream: PCM substream
*
* Releases the DMA channel associated with the PCM substream.
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index d531e1bc2b81..bda3514c7b2d 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -490,7 +490,7 @@ void snd_pcm_set_ops(struct snd_pcm *pcm, int direction,
EXPORT_SYMBOL(snd_pcm_set_ops);
/**
- * snd_pcm_sync - set the PCM sync id
+ * snd_pcm_set_sync - set the PCM sync id
* @substream: the pcm substream
*
* Sets the PCM sync identifier for the card.
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 9e0b2d73faf6..47b155a49226 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -112,7 +112,7 @@ void snd_pcm_stream_lock(struct snd_pcm_substream *substream)
EXPORT_SYMBOL_GPL(snd_pcm_stream_lock);
/**
- * snd_pcm_stream_lock - Unlock the PCM stream
+ * snd_pcm_stream_unlock - Unlock the PCM stream
* @substream: PCM substream
*
* This unlocks the PCM stream that has been locked via snd_pcm_stream_lock().
@@ -595,7 +595,7 @@ static void snd_pcm_sync_stop(struct snd_pcm_substream *substream)
}
/**
- * snd_pcm_hw_param_choose - choose a configuration defined by @params
+ * snd_pcm_hw_params_choose - choose a configuration defined by @params
* @pcm: PCM instance
* @params: the hw_params instance
*
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index ea3986a46c12..05a085f6dc7c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2341,7 +2341,7 @@ struct snd_soc_dai *snd_soc_register_dai(struct snd_soc_component *component,
}
/**
- * snd_soc_unregister_dai - Unregister DAIs from the ASoC core
+ * snd_soc_unregister_dais - Unregister DAIs from the ASoC core
*
* @component: The component for which the DAIs should be unregistered
*/
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 980f2c330b87..7f87b449f950 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1276,7 +1276,7 @@ static int is_connected_input_ep(struct snd_soc_dapm_widget *widget,
}
/**
- * snd_soc_dapm_get_connected_widgets - query audio path and it's widgets.
+ * snd_soc_dapm_dai_get_connected_widgets - query audio path and it's widgets.
* @dai: the soc DAI.
* @stream: stream direction.
* @list: list of active widgets for this stream.
--
2.26.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 48/56] sound: fix kernel-doc markups
2020-10-23 16:33 ` [PATCH v3 48/56] sound: fix kernel-doc markups Mauro Carvalho Chehab
@ 2020-10-23 18:26 ` Mark Brown
2020-10-26 13:46 ` Takashi Iwai
1 sibling, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-10-23 18:26 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: alsa-devel, Lars-Peter Clausen, Arnd Bergmann, Jonathan Corbet,
linux-kernel, Baolin Wang, Linux Doc Mailing List, Liam Girdwood,
Michał Mirosław, Vinod Koul, Takashi Iwai, paulhsia,
Dan Carpenter
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
On Fri, Oct 23, 2020 at 06:33:35PM +0200, Mauro Carvalho Chehab wrote:
> Kernel-doc markups should use this format:
> identifier - description
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 48/56] sound: fix kernel-doc markups
2020-10-23 16:33 ` [PATCH v3 48/56] sound: fix kernel-doc markups Mauro Carvalho Chehab
2020-10-23 18:26 ` Mark Brown
@ 2020-10-26 13:46 ` Takashi Iwai
2020-10-26 14:14 ` Mauro Carvalho Chehab
1 sibling, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2020-10-26 13:46 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: alsa-devel, Lars-Peter Clausen, Arnd Bergmann, Jonathan Corbet,
linux-kernel, Baolin Wang, Linux Doc Mailing List, Liam Girdwood,
Michał Mirosław, Vinod Koul, Mark Brown, Takashi Iwai,
paulhsia, Dan Carpenter
On Fri, 23 Oct 2020 18:33:35 +0200,
Mauro Carvalho Chehab wrote:
>
> Kernel-doc markups should use this format:
> identifier - description
>
> There is a common comment marked, instead, with kernel-doc
> notation.
>
> Some identifiers have different names between their prototypes
> and the kernel-doc markup.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Shall I merge this through sound git tree?
Or if this goes via doc tree, feel free to take my ack
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 48/56] sound: fix kernel-doc markups
2020-10-26 13:46 ` Takashi Iwai
@ 2020-10-26 14:14 ` Mauro Carvalho Chehab
2020-10-26 14:25 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2020-10-26 14:14 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel, Lars-Peter Clausen, Arnd Bergmann, Jonathan Corbet,
linux-kernel, Baolin Wang, Linux Doc Mailing List, Liam Girdwood,
Michał Mirosław, Vinod Koul, Mark Brown, Takashi Iwai,
paulhsia, Dan Carpenter
Em Mon, 26 Oct 2020 14:46:03 +0100
Takashi Iwai <tiwai@suse.de> escreveu:
> On Fri, 23 Oct 2020 18:33:35 +0200,
> Mauro Carvalho Chehab wrote:
> >
> > Kernel-doc markups should use this format:
> > identifier - description
> >
> > There is a common comment marked, instead, with kernel-doc
> > notation.
> >
> > Some identifiers have different names between their prototypes
> > and the kernel-doc markup.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Shall I merge this through sound git tree?
>
> Or if this goes via doc tree, feel free to take my ack
> Reviewed-by: Takashi Iwai <tiwai@suse.de>
Thanks for reviewing it!
Feel free to merge it though sound tree.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 48/56] sound: fix kernel-doc markups
2020-10-26 14:14 ` Mauro Carvalho Chehab
@ 2020-10-26 14:25 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2020-10-26 14:25 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: alsa-devel, Lars-Peter Clausen, Arnd Bergmann, Jonathan Corbet,
linux-kernel, Baolin Wang, Linux Doc Mailing List, Liam Girdwood,
Michał Mirosław, Vinod Koul, Mark Brown, Takashi Iwai,
paulhsia, Dan Carpenter
On Mon, 26 Oct 2020 15:14:23 +0100,
Mauro Carvalho Chehab wrote:
>
> Em Mon, 26 Oct 2020 14:46:03 +0100
> Takashi Iwai <tiwai@suse.de> escreveu:
>
> > On Fri, 23 Oct 2020 18:33:35 +0200,
> > Mauro Carvalho Chehab wrote:
> > >
> > > Kernel-doc markups should use this format:
> > > identifier - description
> > >
> > > There is a common comment marked, instead, with kernel-doc
> > > notation.
> > >
> > > Some identifiers have different names between their prototypes
> > > and the kernel-doc markup.
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> >
> > Shall I merge this through sound git tree?
> >
> > Or if this goes via doc tree, feel free to take my ack
> > Reviewed-by: Takashi Iwai <tiwai@suse.de>
>
> Thanks for reviewing it!
>
> Feel free to merge it though sound tree.
OK, applied now. Thanks!
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 28/56] slimbus: fix a kernel-doc markup
2020-10-23 16:33 ` [PATCH v3 28/56] slimbus: fix a kernel-doc markup Mauro Carvalho Chehab
@ 2020-10-26 14:52 ` Srinivas Kandagatla
0 siblings, 0 replies; 7+ messages in thread
From: Srinivas Kandagatla @ 2020-10-26 14:52 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Doc Mailing List
Cc: alsa-devel, linux-kernel, Jonathan Corbet
On 23/10/2020 17:33, Mauro Carvalho Chehab wrote:
> Fix the name of the enum on its kernel-doc markup:
> enum slim_ch_aux_fmt -> enum slim_ch_aux_bit_fmt
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/slimbus/slimbus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/slimbus.h b/drivers/slimbus/slimbus.h
> index c73035915f1d..00a7f112574b 100644
> --- a/drivers/slimbus/slimbus.h
> +++ b/drivers/slimbus/slimbus.h
> @@ -244,7 +244,7 @@ enum slim_ch_data_fmt {
> };
>
> /**
> - * enum slim_ch_aux_fmt: SLIMbus channel Aux Field format IDs according to
> + * enum slim_ch_aux_bit_fmt: SLIMbus channel Aux Field format IDs according to
> * Table 63 of SLIMbus Spec 2.0
> * @SLIM_CH_AUX_FMT_NOT_APPLICABLE: Undefined
> * @SLIM_CH_AUX_FMT_ZCUV_TUNNEL_IEC60958: ZCUV for tunneling IEC60958
>
Applied thanks!
srini
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-26 14:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1603469755.git.mchehab+huawei@kernel.org>
2020-10-23 16:33 ` [PATCH v3 28/56] slimbus: fix a kernel-doc markup Mauro Carvalho Chehab
2020-10-26 14:52 ` Srinivas Kandagatla
2020-10-23 16:33 ` [PATCH v3 48/56] sound: fix kernel-doc markups Mauro Carvalho Chehab
2020-10-23 18:26 ` Mark Brown
2020-10-26 13:46 ` Takashi Iwai
2020-10-26 14:14 ` Mauro Carvalho Chehab
2020-10-26 14:25 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).