From: "Martin Povišer" <povik+lin@cutebit.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
asahi@lists.linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/3] ASoC: apple: mca: Start new platform driver
Date: Tue, 9 Aug 2022 10:54:27 +0200 [thread overview]
Message-ID: <82B580B4-85BF-4ABA-B098-98E3CA9EE247@cutebit.org> (raw)
In-Reply-To: <53c8f062-a760-c65f-479e-53e7991b3f66@linaro.org>
> On 9. 8. 2022, at 10:47, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/08/2022 01:41, Martin Povišer wrote:
>> + mca->switch_base =
>> + devm_platform_ioremap_resource_byname(pdev, "switch");
>> + if (IS_ERR(mca->switch_base))
>> + return PTR_ERR(mca->switch_base);
>
> How does it work exactly? There is no such property... Can you submit
> also DTS using the bindings so we can validate they are real/correct?
Ah, I thought I fixed that. There’s supposed to be
mca->switch_base = devm_platform_ioremap_resource(pdev, 1);
of course. My bad, I guess didn’t reexport the patches after these last
minute changes.
>> +
>> + mca->rstc = devm_reset_control_get_shared(&pdev->dev, NULL);
>> + if (IS_ERR(mca->rstc)) {
>> + dev_dbg(&pdev->dev, "couldn't obtain reset control: %pe\n", mca->rstc);
>> + mca->rstc = NULL;
>> + }
>
> Similar question.
Same as above, there’s supposed to be
resets:
maxItems: 1
in the schema.
> Best regards,
> Krzysztof
>
Martin
next prev parent reply other threads:[~2022-08-09 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 22:41 [PATCH 0/3] ASoC platform driver for Apple MCA Martin Povišer
2022-08-08 22:41 ` [PATCH 1/3] dt-bindings: sound: Add Apple MCA I2S transceiver Martin Povišer
2022-08-09 8:15 ` Krzysztof Kozlowski
2022-08-09 8:40 ` Martin Povišer
2022-08-09 8:47 ` Krzysztof Kozlowski
2022-08-09 8:55 ` Martin Povišer
2022-08-08 22:41 ` [PATCH 2/3] ASoC: apple: mca: Start new platform driver Martin Povišer
2022-08-09 8:32 ` Philipp Zabel
2022-08-09 8:47 ` Krzysztof Kozlowski
2022-08-09 8:54 ` Martin Povišer [this message]
2022-08-18 17:54 ` Martin Povišer
2022-08-19 6:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82B580B4-85BF-4ABA-B098-98E3CA9EE247@cutebit.org \
--to=povik+lin@cutebit.org \
--cc=alsa-devel@alsa-project.org \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).