From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
asahi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: apple: mca: Start new platform driver
Date: Tue, 09 Aug 2022 10:32:45 +0200 [thread overview]
Message-ID: <b18ef07670c09d4a58b70dc3671549a9b7d5b4e2.camel@pengutronix.de> (raw)
In-Reply-To: <20220808224153.3634-3-povik+lin@cutebit.org>
Hi Martin,
On Di, 2022-08-09 at 00:41 +0200, Martin Povišer wrote:
> + mca->rstc = devm_reset_control_get_shared(&pdev->dev, NULL);
> + if (IS_ERR(mca->rstc)) {
> + dev_dbg(&pdev->dev, "couldn't obtain reset control: %pe\n", mca->rstc);
> + mca->rstc = NULL;
> + }
Please don't ignore errors, this could be -ENOMEM.
For optional resets, use devm_reset_control_get_optional_shared(),
which returns NULL if there is no resets property in the device tree.
regards
Philipp
next prev parent reply other threads:[~2022-08-09 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 22:41 [PATCH 0/3] ASoC platform driver for Apple MCA Martin Povišer
2022-08-08 22:41 ` [PATCH 1/3] dt-bindings: sound: Add Apple MCA I2S transceiver Martin Povišer
2022-08-09 8:15 ` Krzysztof Kozlowski
2022-08-09 8:40 ` Martin Povišer
2022-08-09 8:47 ` Krzysztof Kozlowski
2022-08-09 8:55 ` Martin Povišer
2022-08-08 22:41 ` [PATCH 2/3] ASoC: apple: mca: Start new platform driver Martin Povišer
2022-08-09 8:32 ` Philipp Zabel [this message]
2022-08-09 8:47 ` Krzysztof Kozlowski
2022-08-09 8:54 ` Martin Povišer
2022-08-18 17:54 ` Martin Povišer
2022-08-19 6:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18ef07670c09d4a58b70dc3671549a9b7d5b4e2.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).