[alsa-devel] alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[alsa-devel] alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Elimar Riesebieter]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

Hi ALSA devs,

please notice the attached suggestion from Lenovo to support sound
for whiskeylake sof-skl_hda_card audio.

Thanks
Elimar
-- 
  You cannot propel yourself forward by
  patting yourself on the back.

[-- Attachment #2: Type: message/rfc822, Size: 13925 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1708 bytes --]

Package: alsa-utils
Version: 1.1.8-2
Severity: important
Tags: patch

Dear Maintainer,

   * What led up to the situation?
The Lenovo X1 Carbon Gen 7 is using the whiskeylake processor and the audio is
not working on it.
A large part of this is the kernel SOF driver - for which a separate bug is
submitted - but we also need some new files under /usr/share/alsa/ucm/sof-
skl_hda_card to support the new audio devices.

   * What exactly did you do (or not do) that was effective (or ineffective)?
Add the attached HiFi and sof-skl_hda_card.conf files to the
/usr/share/alsa/ucm/sof-skl_hda_card directory

   * What was the outcome of this action?
Devices are correctly detected and configured.

   * What outcome did you expect instead?
NA

Let me know if any questions or concerns. Thanks for all the help!
Mark



-- System Information:
Debian Release: 10.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.2.9 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages alsa-utils depends on:
ii  kmod              26-1
ii  libasound2        1.1.8-1
ii  libc6             2.28-10
ii  libfftw3-single3  3.3.8-2
ii  libncursesw6      6.1+20181013-2+deb10u1
ii  libsamplerate0    0.1.9-2
ii  libtinfo6         6.1+20181013-2+deb10u1
ii  lsb-base          10.2019051400
ii  whiptail          0.52.20-8

alsa-utils recommends no packages.

alsa-utils suggests no packages.

-- no debconf information

[-- Attachment #2.1.2: sof-skl_hda_card.conf --]
[-- Type: text/plain, Size: 75 bytes --]

SectionUseCase."HiFi" {
	File "HiFi"
	Comment "Play HiFi quality Music"
}


[-- Attachment #2.1.3: HiFi --]
[-- Type: text/plain, Size: 5166 bytes --]

# Use case Configuration for skl-hda-card

SectionVerb {

	EnableSequence [
		cdev "hw:sofsklhdacard"
		cset "name='Master Playback Switch' on"
		cset "name='Capture Switch' on"
		
	]

	DisableSequence [
		cdev "hw:sofsklhdacard"
	]

        Value {
        }
}

SectionDevice."Headphone" {
	Comment "Headphone"

	#ConflictingDevice [
        #        "Speaker"
        #]
	
	EnableSequence [
		cdev "hw:sofsklhdacard"
		cset "name='Headphone Playback Volume' 80"
		#cset "name='Headphone Mic Boost Volume' 1"
		cset "name='Headphone Playback Switch' on"
	]

	DisableSequence [
		cdev "hw:sofsklhdacard"
		cset "name='Headphone Playback Switch' off"
	]

	Value {
		PlaybackPCM "hw:sofsklhdacard,0"
		PlaybackChannels "2"
		#JackHWMute "Speaker"
		JackName "sof-skl_hda_card Headphone"
		JackType "gpio"
		JackSwitch "12"
		JackControl "Headphone Jack"
	}
}

SectionDevice."Speaker" {
        Comment "Speaker"

        #ConflictingDevice [
        #        "Headphone"
        #]

        EnableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='Speaker Playback Switch' on"
                cset "name='Speaker Playback Volume' 80"
        ]

        DisableSequence [
                cset "name='Speaker Playback Switch' off"
        ]

        Value {
		PlaybackPCM "hw:sofsklhdacard,0"
		JackHWMute "Headphone"
                PlaybackChannels "2"
        }
}

SectionDevice."Bass Speaker" {
        Comment "Bass Speaker"

#       ConflictingDevice [
#                "Headphone"
#        ]

        EnableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='Bass Speaker Playback Switch' on"
		cset "name='Speaker Playback Switch' on"
		cset "name='Speaker Playback Volume' 80"
        ]

        DisableSequence [
                cset "name='Speaker Playback Switch' off"
                cset "name='Bass Speaker Playback Switch' off"
        ]
        Value {
                PlaybackPCM "hw:sofsklhdacard,0"
                JackHWMute "Headphone"
                PlaybackChannels "2"
        }
}

SectionDevice."Headset" {
	Comment "Headset Mic"

        ConflictingDevice [
                "DMIC Stereo"
        ]

        EnableSequence [
                cdev "hw:sofsklhdacard"
#		cset "name='Headphone Mic Boost Volume' 1"
#		cset "name='Capture Switch' on"
        ]

        DisableSequence [
                cdev "hw:sofsklhdacard"
#		cset "name='Capture Switch' off"
        ]

        Value {
                CapturePCM "hw:0,0"
                CaptureChannels "2"
		JackControl "Mic Jack"
#		JackHWMute "DMIC Stereo"
        }
}

SectionDevice."Dmic" {
        Comment "DMIC Stereo"

        ConflictingDevice [
                "Headset Mic"
        ]

        EnableSequence [
                cdev "hw:sofsklhdacard"
#		cset "name='Capture Switch' on"
                cset "name='PGA10.0 10 Master Capture Volume' 75"
        ]

        DisableSequence [
                cdev "hw:sofsklhdacard"
#		cset "name='Capture Switch' off"
        ]

        Value {
                CapturePCM "hw:0,6"
                CaptureChannels "2"
#		JackHWMute "Headset Mic"
        }
}

SectionDevice."HDMI1" {
        Comment "HDMI1/DP1 Output"

#        ConflictingDevice [
                # "Headset"
#        ]

        EnableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='hif5-0 Jack Switch' on"
                cset "name='Pin5-Port0 Mux' 1"
        ]

        DisableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='Pin5-Port0 Mux' 0"
                cset "name='hif5-0 Jack Switch' off"
        ]

        Value {
                PlaybackPCM "hw:0,3"
                PlaybackChannels "2"
                JackControl "HDMI/DP, pcm=11 Jack"
                # JackHWMute "Headset"
        }
}

SectionDevice."HDMI2" {
        Comment "HDMI2/DP2 Output"

#        ConflictingDevice [
                # "Headset"
#        ]

        EnableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='hif6-0 Jack Switch' on"
                cset "name='Pin6-Port0 Mux' 2"
        ]

        DisableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='Pin6-Port0 Mux' 0"
                cset "name='hif6-0 Jack Switch' off"
        ]

        Value {
                PlaybackPCM "hw:0,4"
                PlaybackChannels "2"
                JackControl "HDMI/DP, pcm=12 Jack"
                # JackHWMute "Headset"
        }
}

SectionDevice."HDMI3" {
        Comment "HDMI3/DP3 Output"

#        ConflictingDevice [
                # "Headset"
#        ]

        EnableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='hif7-0 Jack Switch' on"
                cset "name='Pin7-Port0 Mux' 3"
        ]

        DisableSequence [
                cdev "hw:sofsklhdacard"
                cset "name='Pin7-Port0 Mux' 0"
                cset "name='hif7-0 Jack Switch' off"
        ]

        Value {
                PlaybackPCM "hw:0,5"
                PlaybackChannels "2"
                JackControl "HDMI/DP, pcm=13 Jack"
                # JackHWMute "Headset"
        }
}


[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Pierre-Louis Bossart]

On 9/19/19 9:23 AM, Elimar Riesebieter wrote:
> Hi ALSA devs,
> 
> please notice the attached suggestion from Lenovo to support sound
> for whiskeylake sof-skl_hda_card audio.

Indeed UCM is required for all cases where SOF and PulseAudio are used.

Our thinking was however to add this UCM file to the new repository 
outside of alsa-lib [1]. There is an on-going thread started by Jaroslav 
to move those files and relicense them as BSD-3-Clause [2]

[1] 
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-July/153257.html
[2] 
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-September/155246.html
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaroslav Kysela]

Dne 19. 09. 19 v 16:23 Elimar Riesebieter napsal(a):
> Hi ALSA devs,
> 
> please notice the attached suggestion from Lenovo to support sound
> for whiskeylake sof-skl_hda_card audio.

Too many commmented lines inside without any explanation. The author should
send the patch with the signed-off-by line. Also, we are working on the LGPL
to BSD 3-Clause licence change, so it would be nice to indicate the agreement
with this.

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Mark Pearson]

> 
> Too many commmented lines inside without any explanation. The author
> should send the patch with the signed-off-by line. Also, we are working on
> the LGPL to BSD 3-Clause licence change, so it would be nice to indicate the
> agreement with this.
> 
Thanks Jaroslav,

I originally got this file from Ubuntu where they worked with Lenovo when certifying our X1 Carbon Gen7 system with Ubuntu. I believe it originally came from Intel but I will confirm. I hadn't even considered licence issues as there isn't a licence in the file - my bad. 

I'm working my way through the steps to make sure support for our platforms gets into Debian but am new to the process. All pointers would be much appreciated - I'm assuming the two files are going to be generic to all platforms using the whiskeylake processor (and likely over Intel processors?) so the SOF and Intel team likely already have plans for this. 

I can certainly clean up the file and confirm its original providence. 

A dumb question - but what do you mean by the signed-off-by line? I looked for a guideline to submitting bugs on the alsa-project wiki and couldn't find any details. 

Thanks
Mark
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Pierre-Louis Bossart]

On 9/19/19 9:54 AM, Mark Pearson wrote:
>>
>> Indeed UCM is required for all cases where SOF and PulseAudio are used.
>>
>> Our thinking was however to add this UCM file to the new repository outside
>> of alsa-lib [1]. There is an on-going thread started by Jaroslav to move those
>> files and relicense them as BSD-3-Clause [2]
>>
>> [1]
>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>> July/153257.html
>> [2]
>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>> September/155246.html
> 
> Thanks Pierre.
> 
> Do we have any approximate timelines on when and how this will happen? (I'm new to this)
> 
> One of my main aims is that we have a customer using Debian and one of our platforms that require this change - I need to make sure I understand how this would roll out and what actions they need to take in the meantime if it's not going to be available in Debian.

I think the first order would be to have the file cleaned-up, with its 
Intel origin clearly stated with a signed-off-by tag.

Then once this is done, the Debian package creation needs to be handled 
(using either the ALSA repo or the cloned version on SOF GitHub). I 
don't have any experience with Debian packages so can't really comment 
on the effort it would take.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaroslav Kysela]

Dne 19. 09. 19 v 17:15 Pierre-Louis Bossart napsal(a):
> On 9/19/19 9:54 AM, Mark Pearson wrote:
>>>
>>> Indeed UCM is required for all cases where SOF and PulseAudio are used.
>>>
>>> Our thinking was however to add this UCM file to the new repository outside
>>> of alsa-lib [1]. There is an on-going thread started by Jaroslav to move those
>>> files and relicense them as BSD-3-Clause [2]
>>>
>>> [1]
>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>>> July/153257.html
>>> [2]
>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>>> September/155246.html
>>
>> Thanks Pierre.
>>
>> Do we have any approximate timelines on when and how this will happen? (I'm new to this)
>>
>> One of my main aims is that we have a customer using Debian and one of our platforms that require this change - I need to make sure I understand how this would roll out and what actions they need to take in the meantime if it's not going to be available in Debian.
> 
> I think the first order would be to have the file cleaned-up, with its 
> Intel origin clearly stated with a signed-off-by tag.
> 
> Then once this is done, the Debian package creation needs to be handled 
> (using either the ALSA repo or the cloned version on SOF GitHub). I 
> don't have any experience with Debian packages so can't really comment 
> on the effort it would take.

I did some cleanups here:

https://github.com/alsa-project/alsa-ucm-conf/commit/f796f0852a097e238fa9f5efb174e95b5ee6c8b7

Pierre, could you confirm the original source and are you ok with that?

			Thank you,
				Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Mark Pearson]

> >
> > I think the first order would be to have the file cleaned-up, with its
> > Intel origin clearly stated with a signed-off-by tag.
> >
> > Then once this is done, the Debian package creation needs to be
> > handled (using either the ALSA repo or the cloned version on SOF
> > GitHub). I don't have any experience with Debian packages so can't
> > really comment on the effort it would take.
> 
> I did some cleanups here:
> 
> https://github.com/alsa-project/alsa-ucm-
> conf/commit/f796f0852a097e238fa9f5efb174e95b5ee6c8b7
> 
> Pierre, could you confirm the original source and are you ok with that?
> 
I got confirmation from Intel that they are the original source - they provided me with the files (as an aside in case it is important, originally they were working with Canonical on getting Ubuntu working on one of our (Lenovo) platforms). I was following up with Canonical to just check what they had done but haven't heard back yet.

Since Intel has provided the files to me directly - can I act as an original source confirmation?


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Hui Wang]

So far, the alsa-lib still depends on the card->name/long-name to find 
the needed UCM, I know some Dell machines also uses sof driver (so the 
card->name/long-name is also sof-skl_hda_card), so if this UCM is 
merged, it will be shared with Dell machines. But on those Dell 
machines, there is no BASS Speaker, and Dell machines have sth that 
Lenovo machines don't have, like headset-mic and headphone-mic. How to 
make this UCM work on both Lenovo and Dell machines?

Regards,

Hui.


On 2019/9/24 下午8:06, Mark Pearson wrote:
>>> I think the first order would be to have the file cleaned-up, with its
>>> Intel origin clearly stated with a signed-off-by tag.
>>>
>>> Then once this is done, the Debian package creation needs to be
>>> handled (using either the ALSA repo or the cloned version on SOF
>>> GitHub). I don't have any experience with Debian packages so can't
>>> really comment on the effort it would take.
>> I did some cleanups here:
>>
>> https://github.com/alsa-project/alsa-ucm-
>> conf/commit/f796f0852a097e238fa9f5efb174e95b5ee6c8b7
>>
>> Pierre, could you confirm the original source and are you ok with that?
>>
> I got confirmation from Intel that they are the original source - they provided me with the files (as an aside in case it is important, originally they were working with Canonical on getting Ubuntu working on one of our (Lenovo) platforms). I was following up with Canonical to just check what they had done but haven't heard back yet.
>
> Since Intel has provided the files to me directly - can I act as an original source confirmation?
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaroslav Kysela]

Dne 27. 09. 19 v 10:21 Hui Wang napsal(a):
> So far, the alsa-lib still depends on the card->name/long-name to find 
> the needed UCM, I know some Dell machines also uses sof driver (so the 
> card->name/long-name is also sof-skl_hda_card), so if this UCM is 
> merged, it will be shared with Dell machines. But on those Dell 
> machines, there is no BASS Speaker, and Dell machines have sth that 
> Lenovo machines don't have, like headset-mic and headphone-mic. How to 
> make this UCM work on both Lenovo and Dell machines?

Thanks for this info. The long-name contains DMI info, so I updated the
configuration in this way:

https://github.com/alsa-project/alsa-ucm-conf/commit/ac8319245e1213e46a1ae5c2de4ddd4a0c8926e2

https://github.com/alsa-project/alsa-ucm-conf/commit/9bd0bf34a571a4a3c38d74098972d82c58fac80e

(everything is in the updated 'import' branch)

So you can add the specific config for the Dell device, too.

					Jaroslav


> 
> Regards,
> 
> Hui.
> 
> 
> On 2019/9/24 下午8:06, Mark Pearson wrote:
>>>> I think the first order would be to have the file cleaned-up, with its
>>>> Intel origin clearly stated with a signed-off-by tag.
>>>>
>>>> Then once this is done, the Debian package creation needs to be
>>>> handled (using either the ALSA repo or the cloned version on SOF
>>>> GitHub). I don't have any experience with Debian packages so can't
>>>> really comment on the effort it would take.
>>> I did some cleanups here:
>>>
>>> https://github.com/alsa-project/alsa-ucm-
>>> conf/commit/f796f0852a097e238fa9f5efb174e95b5ee6c8b7
>>>
>>> Pierre, could you confirm the original source and are you ok with that?
>>>
>> I got confirmation from Intel that they are the original source - they provided me with the files (as an aside in case it is important, originally they were working with Canonical on getting Ubuntu working on one of our (Lenovo) platforms). I was following up with Canonical to just check what they had done but haven't heard back yet.
>>
>> Since Intel has provided the files to me directly - can I act as an original source confirmation?
>>
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>


-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaska Uimonen]

On Tue, 2019-09-24 at 13:53 +0200, Jaroslav Kysela wrote:
> Dne 19. 09. 19 v 17:15 Pierre-Louis Bossart napsal(a):
> > On 9/19/19 9:54 AM, Mark Pearson wrote:
> > > > 
> > > > Indeed UCM is required for all cases where SOF and PulseAudio
> > > > are used.
> > > > 
> > > > Our thinking was however to add this UCM file to the new
> > > > repository outside
> > > > of alsa-lib [1]. There is an on-going thread started by
> > > > Jaroslav to move those
> > > > files and relicense them as BSD-3-Clause [2]
> > > > 
> > > > [1]
> > > > https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
> > > > July/153257.html
> > > > [2]
> > > > https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
> > > > September/155246.html
> > > 
> > > Thanks Pierre.
> > > 
> > > Do we have any approximate timelines on when and how this will
> > > happen? (I'm new to this)
> > > 
> > > One of my main aims is that we have a customer using Debian and
> > > one of our platforms that require this change - I need to make
> > > sure I understand how this would roll out and what actions they
> > > need to take in the meantime if it's not going to be available in
> > > Debian.
> > 
> > I think the first order would be to have the file cleaned-up, with
> > its 
> > Intel origin clearly stated with a signed-off-by tag.
> > 
> > Then once this is done, the Debian package creation needs to be
> > handled 
> > (using either the ALSA repo or the cloned version on SOF GitHub).
> > I 
> > don't have any experience with Debian packages so can't really
> > comment 
> > on the effort it would take.
> 
> I did some cleanups here:
> 
> https://github.com/alsa-project/alsa-ucm-conf/commit/f796f0852a097e23
> 8fa9f5efb174e95b5ee6c8b7
> 
> Pierre, could you confirm the original source and are you ok with
> that?

Cleanup looks fine to me, we should add still UCM "PlaybackVolume" and
"CaptureVolume" settings, because otherwise Pulseaudio will use SW
volume only. This will make for example HDA led quirks useless...
(and actually CaptureVolume and PlaybackVolume in pulseaudio ucm
support is still not integrated, hopefully soon). Defining Capture and
PlaybackVolume should not do any harm currently for user space.

I can do that, Jaroslav you want PR against github or patches here 
to mailing list?

br,
Jaska


> 
> 			Thank you,
> 				Jaroslav
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaroslav Kysela]

Dne 27. 09. 19 v 12:07 Jaska Uimonen napsal(a):
> On Tue, 2019-09-24 at 13:53 +0200, Jaroslav Kysela wrote:
>> Dne 19. 09. 19 v 17:15 Pierre-Louis Bossart napsal(a):
>>> On 9/19/19 9:54 AM, Mark Pearson wrote:
>>>>>
>>>>> Indeed UCM is required for all cases where SOF and PulseAudio
>>>>> are used.
>>>>>
>>>>> Our thinking was however to add this UCM file to the new
>>>>> repository outside
>>>>> of alsa-lib [1]. There is an on-going thread started by
>>>>> Jaroslav to move those
>>>>> files and relicense them as BSD-3-Clause [2]
>>>>>
>>>>> [1]
>>>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>>>>> July/153257.html
>>>>> [2]
>>>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>>>>> September/155246.html
>>>>
>>>> Thanks Pierre.
>>>>
>>>> Do we have any approximate timelines on when and how this will
>>>> happen? (I'm new to this)
>>>>
>>>> One of my main aims is that we have a customer using Debian and
>>>> one of our platforms that require this change - I need to make
>>>> sure I understand how this would roll out and what actions they
>>>> need to take in the meantime if it's not going to be available in
>>>> Debian.
>>>
>>> I think the first order would be to have the file cleaned-up, with
>>> its 
>>> Intel origin clearly stated with a signed-off-by tag.
>>>
>>> Then once this is done, the Debian package creation needs to be
>>> handled 
>>> (using either the ALSA repo or the cloned version on SOF GitHub).
>>> I 
>>> don't have any experience with Debian packages so can't really
>>> comment 
>>> on the effort it would take.
>>
>> I did some cleanups here:
>>
>> https://github.com/alsa-project/alsa-ucm-conf/commit/f796f0852a097e23
>> 8fa9f5efb174e95b5ee6c8b7
>>
>> Pierre, could you confirm the original source and are you ok with
>> that?
> 
> Cleanup looks fine to me, we should add still UCM "PlaybackVolume" and
> "CaptureVolume" settings, because otherwise Pulseaudio will use SW
> volume only. This will make for example HDA led quirks useless...
> (and actually CaptureVolume and PlaybackVolume in pulseaudio ucm
> support is still not integrated, hopefully soon). Defining Capture and
> PlaybackVolume should not do any harm currently for user space.
> 
> I can do that, Jaroslav you want PR against github or patches here 
> to mailing list?

As you wish. Both ways are acceptable for me. Note that I did another cleanup
for 'Bass Speaker' for Carbon X1 7th and merged 'import' branch to 'master'
branch on github (so do the PR against master, if you like).

				Thanks,
					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaska Uimonen]

On Fri, 2019-09-27 at 12:57 +0200, Jaroslav Kysela wrote:
> Dne 27. 09. 19 v 12:07 Jaska Uimonen napsal(a):
> > On Tue, 2019-09-24 at 13:53 +0200, Jaroslav Kysela wrote:
> > > Dne 19. 09. 19 v 17:15 Pierre-Louis Bossart napsal(a):
> > > > On 9/19/19 9:54 AM, Mark Pearson wrote:
> > > > > > 
> > > > > > Indeed UCM is required for all cases where SOF and
> > > > > > PulseAudio
> > > > > > are used.
> > > > > > 
> > > > > > Our thinking was however to add this UCM file to the new
> > > > > > repository outside
> > > > > > of alsa-lib [1]. There is an on-going thread started by
> > > > > > Jaroslav to move those
> > > > > > files and relicense them as BSD-3-Clause [2]
> > > > > > 
> > > > > > [1]
> > > > > > https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
> > > > > > July/153257.html
> > > > > > [2]
> > > > > > https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
> > > > > > September/155246.html
> > > > > 
> > > > > Thanks Pierre.
> > > > > 
> > > > > Do we have any approximate timelines on when and how this
> > > > > will
> > > > > happen? (I'm new to this)
> > > > > 
> > > > > One of my main aims is that we have a customer using Debian
> > > > > and
> > > > > one of our platforms that require this change - I need to
> > > > > make
> > > > > sure I understand how this would roll out and what actions
> > > > > they
> > > > > need to take in the meantime if it's not going to be
> > > > > available in
> > > > > Debian.
> > > > 
> > > > I think the first order would be to have the file cleaned-up,
> > > > with
> > > > its 
> > > > Intel origin clearly stated with a signed-off-by tag.
> > > > 
> > > > Then once this is done, the Debian package creation needs to be
> > > > handled 
> > > > (using either the ALSA repo or the cloned version on SOF
> > > > GitHub).
> > > > I 
> > > > don't have any experience with Debian packages so can't really
> > > > comment 
> > > > on the effort it would take.
> > > 
> > > I did some cleanups here:
> > > 
> > > https://github.com/alsa-project/alsa-ucm-conf/commit/f796f0852a09
> > > 7e23
> > > 8fa9f5efb174e95b5ee6c8b7
> > > 
> > > Pierre, could you confirm the original source and are you ok with
> > > that?
> > 
> > Cleanup looks fine to me, we should add still UCM "PlaybackVolume"
> > and
> > "CaptureVolume" settings, because otherwise Pulseaudio will use SW
> > volume only. This will make for example HDA led quirks useless...
> > (and actually CaptureVolume and PlaybackVolume in pulseaudio ucm
> > support is still not integrated, hopefully soon). Defining Capture
> > and
> > PlaybackVolume should not do any harm currently for user space.
> > 
> > I can do that, Jaroslav you want PR against github or patches here 
> > to mailing list?
> 
> As you wish. Both ways are acceptable for me. Note that I did another
> cleanup
> for 'Bass Speaker' for Carbon X1 7th and merged 'import' branch to
> 'master'
> branch on github (so do the PR against master, if you like).
> 
> 				Thanks,
> 					Jaroslav
> 

I made now:
https://github.com/alsa-project/alsa-ucm-conf/pull/1
and
https://github.com/alsa-project/alsa-ucm-conf/pull/2

It would be good if Lenovo and Canonical folks also check these.

I'm testing this in Dell device with Ubuntu and twiddling outputs 
and volumes/mutes from UI. PR 2 is assuming Pulseaudio HW control, 
so not sure if the changes bad without it. 

br,
Jaska 



_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaroslav Kysela]

Dne 27. 09. 19 v 16:00 Jaska Uimonen napsal(a):
> On Fri, 2019-09-27 at 12:57 +0200, Jaroslav Kysela wrote:
>> Dne 27. 09. 19 v 12:07 Jaska Uimonen napsal(a):
>>> On Tue, 2019-09-24 at 13:53 +0200, Jaroslav Kysela wrote:
>>>> Dne 19. 09. 19 v 17:15 Pierre-Louis Bossart napsal(a):
>>>>> On 9/19/19 9:54 AM, Mark Pearson wrote:
>>>>>>>
>>>>>>> Indeed UCM is required for all cases where SOF and
>>>>>>> PulseAudio
>>>>>>> are used.
>>>>>>>
>>>>>>> Our thinking was however to add this UCM file to the new
>>>>>>> repository outside
>>>>>>> of alsa-lib [1]. There is an on-going thread started by
>>>>>>> Jaroslav to move those
>>>>>>> files and relicense them as BSD-3-Clause [2]
>>>>>>>
>>>>>>> [1]
>>>>>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>>>>>>> July/153257.html
>>>>>>> [2]
>>>>>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
>>>>>>> September/155246.html
>>>>>>
>>>>>> Thanks Pierre.
>>>>>>
>>>>>> Do we have any approximate timelines on when and how this
>>>>>> will
>>>>>> happen? (I'm new to this)
>>>>>>
>>>>>> One of my main aims is that we have a customer using Debian
>>>>>> and
>>>>>> one of our platforms that require this change - I need to
>>>>>> make
>>>>>> sure I understand how this would roll out and what actions
>>>>>> they
>>>>>> need to take in the meantime if it's not going to be
>>>>>> available in
>>>>>> Debian.
>>>>>
>>>>> I think the first order would be to have the file cleaned-up,
>>>>> with
>>>>> its 
>>>>> Intel origin clearly stated with a signed-off-by tag.
>>>>>
>>>>> Then once this is done, the Debian package creation needs to be
>>>>> handled 
>>>>> (using either the ALSA repo or the cloned version on SOF
>>>>> GitHub).
>>>>> I 
>>>>> don't have any experience with Debian packages so can't really
>>>>> comment 
>>>>> on the effort it would take.
>>>>
>>>> I did some cleanups here:
>>>>
>>>> https://github.com/alsa-project/alsa-ucm-conf/commit/f796f0852a09
>>>> 7e23
>>>> 8fa9f5efb174e95b5ee6c8b7
>>>>
>>>> Pierre, could you confirm the original source and are you ok with
>>>> that?
>>>
>>> Cleanup looks fine to me, we should add still UCM "PlaybackVolume"
>>> and
>>> "CaptureVolume" settings, because otherwise Pulseaudio will use SW
>>> volume only. This will make for example HDA led quirks useless...
>>> (and actually CaptureVolume and PlaybackVolume in pulseaudio ucm
>>> support is still not integrated, hopefully soon). Defining Capture
>>> and
>>> PlaybackVolume should not do any harm currently for user space.
>>>
>>> I can do that, Jaroslav you want PR against github or patches here 
>>> to mailing list?
>>
>> As you wish. Both ways are acceptable for me. Note that I did another
>> cleanup
>> for 'Bass Speaker' for Carbon X1 7th and merged 'import' branch to
>> 'master'
>> branch on github (so do the PR against master, if you like).
>>
>> 				Thanks,
>> 					Jaroslav
>>
> 
> I made now:
> https://github.com/alsa-project/alsa-ucm-conf/pull/1
> and
> https://github.com/alsa-project/alsa-ucm-conf/pull/2

Thanks. Why switches (PlaybackSwitch/CaptureSwitch) are not defined, too?

> It would be good if Lenovo and Canonical folks also check these.
> 
> I'm testing this in Dell device with Ubuntu and twiddling outputs 
> and volumes/mutes from UI. PR 2 is assuming Pulseaudio HW control, 
> so not sure if the changes bad without it. 

BTW: Could you, Intel guys, review other UCM profiles for the SST drivers,
too? It seems that PlaybackVolume is only in few other profiles and no one is
using switches and capture CTL ID definitions. It basically means, that all
UCM profiles are broken and only software volume is used in PA :-(

				Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Hui Wang]

On 2019/9/27 下午5:01, Jaroslav Kysela wrote:
> Dne 27. 09. 19 v 10:21 Hui Wang napsal(a):
>> So far, the alsa-lib still depends on the card->name/long-name to find
>> the needed UCM, I know some Dell machines also uses sof driver (so the
>> card->name/long-name is also sof-skl_hda_card), so if this UCM is
>> merged, it will be shared with Dell machines. But on those Dell
>> machines, there is no BASS Speaker, and Dell machines have sth that
>> Lenovo machines don't have, like headset-mic and headphone-mic. How to
>> make this UCM work on both Lenovo and Dell machines?
> Thanks for this info. The long-name contains DMI info, so I updated the
> configuration in this way:
>
> https://github.com/alsa-project/alsa-ucm-conf/commit/ac8319245e1213e46a1ae5c2de4ddd4a0c8926e2
>
> https://github.com/alsa-project/alsa-ucm-conf/commit/9bd0bf34a571a4a3c38d74098972d82c58fac80e
>
> (everything is in the updated 'import' branch)
>
> So you can add the specific config for the Dell device, too.

OK, that is good, thanks.

Regards,

Hui.

>
> 					Jaroslav
>
>
>> Regards,
>>
>> Hui.
>>
>>
>> On 2019/9/24 下午8:06, Mark Pearson wrote:
>>>>> I think the first order would be to have the file cleaned-up, with its
>>>>> Intel origin clearly stated with a signed-off-by tag.
>>>>>
>>>>> Then once this is done, the Debian package creation needs to be
>>>>> handled (using either the ALSA repo or the cloned version on SOF
>>>>> GitHub). I don't have any experience with Debian packages so can't
>>>>> really comment on the effort it would take.
>>>> I did some cleanups here:
>>>>
>>>> https://github.com/alsa-project/alsa-ucm-
>>>> conf/commit/f796f0852a097e238fa9f5efb174e95b5ee6c8b7
>>>>
>>>> Pierre, could you confirm the original source and are you ok with that?
>>>>
>>> I got confirmation from Intel that they are the original source - they provided me with the files (as an aside in case it is important, originally they were working with Canonical on getting Ubuntu working on one of our (Lenovo) platforms). I was following up with Canonical to just check what they had done but haven't heard back yet.
>>>
>>> Since Intel has provided the files to me directly - can I act as an original source confirmation?
>>>
>>>
>>> _______________________________________________
>>> Alsa-devel mailing list
>>> Alsa-devel@alsa-project.org
>>> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Jaska Uimonen]

On Fri, Sep 27, 2019 at 04:49:29PM +0200, Jaroslav Kysela wrote:
> Dne 27. 09. 19 v 16:00 Jaska Uimonen napsal(a):
> > On Fri, 2019-09-27 at 12:57 +0200, Jaroslav Kysela wrote:
> >> Dne 27. 09. 19 v 12:07 Jaska Uimonen napsal(a):
> >>> On Tue, 2019-09-24 at 13:53 +0200, Jaroslav Kysela wrote:
> >>>> Dne 19. 09. 19 v 17:15 Pierre-Louis Bossart napsal(a):
> >>>>> On 9/19/19 9:54 AM, Mark Pearson wrote:
> >>>>>>>
> >>>>>>> Indeed UCM is required for all cases where SOF and
> >>>>>>> PulseAudio
> >>>>>>> are used.
> >>>>>>>
> >>>>>>> Our thinking was however to add this UCM file to the new
> >>>>>>> repository outside
> >>>>>>> of alsa-lib [1]. There is an on-going thread started by
> >>>>>>> Jaroslav to move those
> >>>>>>> files and relicense them as BSD-3-Clause [2]
> >>>>>>>
> >>>>>>> [1]
> >>>>>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
> >>>>>>> July/153257.html
> >>>>>>> [2]
> >>>>>>> https://mailman.alsa-project.org/pipermail/alsa-devel/2019-
> >>>>>>> September/155246.html
> >>>>>>
> >>>>>> Thanks Pierre.
> >>>>>>
> >>>>>> Do we have any approximate timelines on when and how this
> >>>>>> will
> >>>>>> happen? (I'm new to this)
> >>>>>>
> >>>>>> One of my main aims is that we have a customer using Debian
> >>>>>> and
> >>>>>> one of our platforms that require this change - I need to
> >>>>>> make
> >>>>>> sure I understand how this would roll out and what actions
> >>>>>> they
> >>>>>> need to take in the meantime if it's not going to be
> >>>>>> available in
> >>>>>> Debian.
> >>>>>
> >>>>> I think the first order would be to have the file cleaned-up,
> >>>>> with
> >>>>> its 
> >>>>> Intel origin clearly stated with a signed-off-by tag.
> >>>>>
> >>>>> Then once this is done, the Debian package creation needs to be
> >>>>> handled 
> >>>>> (using either the ALSA repo or the cloned version on SOF
> >>>>> GitHub).
> >>>>> I 
> >>>>> don't have any experience with Debian packages so can't really
> >>>>> comment 
> >>>>> on the effort it would take.
> >>>>
> >>>> I did some cleanups here:
> >>>>
> >>>> https://github.com/alsa-project/alsa-ucm-conf/commit/f796f0852a09
> >>>> 7e23
> >>>> 8fa9f5efb174e95b5ee6c8b7
> >>>>
> >>>> Pierre, could you confirm the original source and are you ok with
> >>>> that?
> >>>
> >>> Cleanup looks fine to me, we should add still UCM "PlaybackVolume"
> >>> and
> >>> "CaptureVolume" settings, because otherwise Pulseaudio will use SW
> >>> volume only. This will make for example HDA led quirks useless...
> >>> (and actually CaptureVolume and PlaybackVolume in pulseaudio ucm
> >>> support is still not integrated, hopefully soon). Defining Capture
> >>> and
> >>> PlaybackVolume should not do any harm currently for user space.
> >>>
> >>> I can do that, Jaroslav you want PR against github or patches here 
> >>> to mailing list?
> >>
> >> As you wish. Both ways are acceptable for me. Note that I did another
> >> cleanup
> >> for 'Bass Speaker' for Carbon X1 7th and merged 'import' branch to
> >> 'master'
> >> branch on github (so do the PR against master, if you like).
> >>
> >> 				Thanks,
> >> 					Jaroslav
> >>
> > 
> > I made now:
> > https://github.com/alsa-project/alsa-ucm-conf/pull/1
> > and
> > https://github.com/alsa-project/alsa-ucm-conf/pull/2
> 
> Thanks. Why switches (PlaybackSwitch/CaptureSwitch) are not defined, too?

Currently the pulseaudio patch I'm testing uses only PlaybackVolume and
CaptureVolume. However Pulseaudio searches also for related switch
control. So if you have combined alsa volume element with switch, both
are set in hardware. With PlaybackSwitch we could define switch in
separate element to volume, which actually could be useful in some use
cases. Most cases however I see the mute switch combined with the
volume.

So maybe incremental addition when this gets implemented by Pulseaudio?
OTH should not do harm either, so in that sense I could add it.. 

> 
> > It would be good if Lenovo and Canonical folks also check these.
> > 
> > I'm testing this in Dell device with Ubuntu and twiddling outputs 
> > and volumes/mutes from UI. PR 2 is assuming Pulseaudio HW control, 
> > so not sure if the changes bad without it. 
> 
> BTW: Could you, Intel guys, review other UCM profiles for the SST drivers,
> too? It seems that PlaybackVolume is only in few other profiles and no one is
> using switches and capture CTL ID definitions. It basically means, that all
> UCM profiles are broken and only software volume is used in PA :-(
> 

I will surely go through all SOF related UCM's and fix/add them to repo.
AFAIK most legacy drivers are used without UCM by Pulseaudio in major
distros. So not sure how useful this is? To be honest, I think most
older UCM's are not really well tested with full audio stack (including
Pulseaudio), probably with command line ucm tools only.

br,
Jaska

> 				Jaroslav
> 
> -- 
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio

[Hui Wang]

On 2019/9/28 上午11:33, Hui Wang wrote:
>
> On 2019/9/27 下午5:01, Jaroslav Kysela wrote:
>> Dne 27. 09. 19 v 10:21 Hui Wang napsal(a):
>>> So far, the alsa-lib still depends on the card->name/long-name to find
>>> the needed UCM, I know some Dell machines also uses sof driver (so the
>>> card->name/long-name is also sof-skl_hda_card), so if this UCM is
>>> merged, it will be shared with Dell machines. But on those Dell
>>> machines, there is no BASS Speaker, and Dell machines have sth that
>>> Lenovo machines don't have, like headset-mic and headphone-mic. How to
>>> make this UCM work on both Lenovo and Dell machines?
>> Thanks for this info. The long-name contains DMI info, so I updated the
>> configuration in this way:
>>
Hello Jaroslav,

For the long->name with DMI info, is it a new feature or an old feature 
that existing for a long time? If it is a new feature, is it implemented 
by kernel driver or by alsa-lib, already upstreamed?

Thanks,

Hui.


>> https://github.com/alsa-project/alsa-ucm-conf/commit/ac8319245e1213e46a1ae5c2de4ddd4a0c8926e2 
>>
>>
>> https://github.com/alsa-project/alsa-ucm-conf/commit/9bd0bf34a571a4a3c38d74098972d82c58fac80e 
>>
>>
>> (everything is in the updated 'import' branch)
>>
>> So you can add the specific config for the Dell device, too.
>
> OK, that is good, thanks.
>
> Regards,
>
> Hui.
>
>>
>>                     Jaroslav
>>
>>
>>> Regards,
>>>
>>> Hui.
>>>
>>>
>>> On 2019/9/24 下午8:06, Mark Pearson wrote:
>>>>>> I think the first order would be to have the file cleaned-up, 
>>>>>> with its
>>>>>> Intel origin clearly stated with a signed-off-by tag.
>>>>>>
>>>>>> Then once this is done, the Debian package creation needs to be
>>>>>> handled (using either the ALSA repo or the cloned version on SOF
>>>>>> GitHub). I don't have any experience with Debian packages so can't
>>>>>> really comment on the effort it would take.
>>>>> I did some cleanups here:
>>>>>
>>>>> https://github.com/alsa-project/alsa-ucm-
>>>>> conf/commit/f796f0852a097e238fa9f5efb174e95b5ee6c8b7
>>>>>
>>>>> Pierre, could you confirm the original source and are you ok with 
>>>>> that?
>>>>>
>>>> I got confirmation from Intel that they are the original source - 
>>>> they provided me with the files (as an aside in case it is 
>>>> important, originally they were working with Canonical on getting 
>>>> Ubuntu working on one of our (Lenovo) platforms). I was following 
>>>> up with Canonical to just check what they had done but haven't 
>>>> heard back yet.
>>>>
>>>> Since Intel has provided the files to me directly - can I act as an 
>>>> original source confirmation?
>>>>
>>>>
>>>> _______________________________________________
>>>> Alsa-devel mailing list
>>>> Alsa-devel@alsa-project.org
>>>> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>>
>>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel