* [alsa-devel] [PATCH] ASoC: soc-dpcm: tidyup for_each_dpcm_xx() macro
@ 2019-10-23 2:10 Kuninori Morimoto
2019-10-24 11:48 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2019-10-23 2:10 UTC (permalink / raw)
To: Mark Brown, Pavel Machek; +Cc: Linux-ALSA
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
for_each_dpcm_xx() macro is using "dpcm" as parameter (1),
but, it is also struct member (2).
#define for_each_dpcm_fe(be, stream, dpcm) \
list_for_each_entry(dpcm, &(be)->dpcm[stream]...)
^^^^(1) ^^^^(2)
Thus, it will be compile error if user not used "dpcm" as parameter
for_each_dpcm_fe(be, stream, dp)
^^
This patch fixup it.
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
include/sound/soc-dpcm.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/sound/soc-dpcm.h b/include/sound/soc-dpcm.h
index ff53037..fbe9e3d 100644
--- a/include/sound/soc-dpcm.h
+++ b/include/sound/soc-dpcm.h
@@ -103,13 +103,13 @@ struct snd_soc_dpcm_runtime {
int trigger_pending; /* trigger cmd + 1 if pending, 0 if not */
};
-#define for_each_dpcm_fe(be, stream, dpcm) \
- list_for_each_entry(dpcm, &(be)->dpcm[stream].fe_clients, list_fe)
+#define for_each_dpcm_fe(be, stream, _dpcm) \
+ list_for_each_entry(_dpcm, &(be)->dpcm[stream].fe_clients, list_fe)
-#define for_each_dpcm_be(fe, stream, dpcm) \
- list_for_each_entry(dpcm, &(fe)->dpcm[stream].be_clients, list_be)
-#define for_each_dpcm_be_safe(fe, stream, dpcm, _dpcm) \
- list_for_each_entry_safe(dpcm, _dpcm, &(fe)->dpcm[stream].be_clients, list_be)
+#define for_each_dpcm_be(fe, stream, _dpcm) \
+ list_for_each_entry(_dpcm, &(fe)->dpcm[stream].be_clients, list_be)
+#define for_each_dpcm_be_safe(fe, stream, _dpcm, __dpcm) \
+ list_for_each_entry_safe(_dpcm, __dpcm, &(fe)->dpcm[stream].be_clients, list_be)
/* can this BE stop and free */
int snd_soc_dpcm_can_be_free_stop(struct snd_soc_pcm_runtime *fe,
--
2.7.4
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: soc-dpcm: tidyup for_each_dpcm_xx() macro
2019-10-23 2:10 [alsa-devel] [PATCH] ASoC: soc-dpcm: tidyup for_each_dpcm_xx() macro Kuninori Morimoto
@ 2019-10-24 11:48 ` Mark Brown
2019-10-25 0:52 ` Kuninori Morimoto
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2019-10-24 11:48 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Pavel Machek, Linux-ALSA
[-- Attachment #1.1: Type: text/plain, Size: 307 bytes --]
On Wed, Oct 23, 2019 at 11:10:29AM +0900, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> for_each_dpcm_xx() macro is using "dpcm" as parameter (1),
> but, it is also struct member (2).
This doesn't apply against current code, please check and resend.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: soc-dpcm: tidyup for_each_dpcm_xx() macro
2019-10-24 11:48 ` Mark Brown
@ 2019-10-25 0:52 ` Kuninori Morimoto
0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2019-10-25 0:52 UTC (permalink / raw)
To: Mark Brown; +Cc: Pavel Machek, Linux-ALSA
Hi Mark
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > for_each_dpcm_xx() macro is using "dpcm" as parameter (1),
> > but, it is also struct member (2).
>
> This doesn't apply against current code, please check and resend.
Oops. OK, I will post v2 patch soon.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-25 0:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 2:10 [alsa-devel] [PATCH] ASoC: soc-dpcm: tidyup for_each_dpcm_xx() macro Kuninori Morimoto
2019-10-24 11:48 ` Mark Brown
2019-10-25 0:52 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).