From: Marian Postevca <posteuca@mutex.one>
To: Mark Brown <broonie@kernel.org>
Cc: 沈一超 <zhuning0077@gmail.com>,
yangxiaohua <yangxiaohua@everest-semi.com>,
"Zhu Ning" <zhuning@everest-semi.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec
Date: Sun, 20 Aug 2023 12:32:52 +0300 [thread overview]
Message-ID: <878ra683ej.fsf@mutex.one> (raw)
In-Reply-To: <8cddbe1c-20d7-4b8f-ba02-f86bbb5a54c5@sirena.org.uk>
Mark Brown <broonie@kernel.org> writes:
> You'd need to pull the relevant supplies out of DAPM and handle them in
> the CODEC suspend/resume callback.
Can you please suggest an approach that would be acceptable to you?
In the original patch series I sent, you didn't agree to the approach
to disable the jack detection in the machine driver suspend callback
and re-enable it in the resume callback. You suggested to do it in the
CODEC suspend/resume callbacks. As I explained previously (and Zhu Ning
confirmed in his email) this wouldn't work, since as long as the jack
detection is enabled, the CODEC suspend/resume callbacks do not get
called.
The second option (which you also do not seem to agree) is to enable
idle_bias_on.
So I don't know how to continue with this and merge this new machine
driver.
next prev parent reply other threads:[~2023-08-20 9:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 20:35 [PATCH 0/4] ASoC: amd: acp: Add sound support for a line of HUAWEI laptops Marian Postevca
2023-03-20 20:35 ` [PATCH 1/4] ASoC: es8316: Enable support for S32 LE format and MCLK div by 2 Marian Postevca
2023-03-20 20:43 ` Mark Brown
2023-03-21 17:09 ` Marian Postevca
2023-03-21 17:21 ` Mark Brown
2023-03-20 20:35 ` [PATCH 2/4] ASoC: amd: acp: Add support for splitting the codec specific code from the ACP driver Marian Postevca
2023-03-20 20:35 ` [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Marian Postevca
2023-03-20 20:54 ` Mark Brown
2023-03-21 22:17 ` Marian Postevca
2023-03-22 1:58 ` Pierre-Louis Bossart
2023-03-22 13:07 ` Mark Brown
2023-03-22 20:48 ` Marian Postevca
2023-03-22 21:27 ` Mark Brown
2023-03-27 21:20 ` Marian Postevca
2023-03-29 13:52 ` Mark Brown
2023-08-17 21:09 ` Marian Postevca
2023-08-17 21:47 ` Mark Brown
2023-08-17 22:20 ` Marian Postevca
2023-08-18 12:52 ` Mark Brown
2023-08-20 9:32 ` Marian Postevca [this message]
2023-08-21 14:09 ` Mark Brown
2023-03-21 0:54 ` kernel test robot
2023-03-20 20:35 ` [PATCH 4/4] ASoC: amd: acp: Improve support for speaker power events Marian Postevca
2023-03-20 21:01 ` Mark Brown
2023-03-22 21:01 ` Marian Postevca
2023-03-22 21:35 ` Mark Brown
2023-03-23 1:56 [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec 沈一超
2023-03-23 13:54 ` Mark Brown
2023-03-24 1:54 Zhu Ning
2023-03-29 14:01 ` Mark Brown
2023-08-18 7:58 Zhu Ning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ra683ej.fsf@mutex.one \
--to=posteuca@mutex.one \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).