From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Marian Postevca <posteuca@mutex.one>, Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec
Date: Tue, 21 Mar 2023 20:58:23 -0500 [thread overview]
Message-ID: <cf458a5a-a0c0-ded7-1819-a85e548cb491@linux.intel.com> (raw)
In-Reply-To: <87lejpwxzf.fsf@mutex.one>
>>> +static int acp3x_es83xx_speaker_power_event(struct snd_soc_dapm_widget *w,
>>> + struct snd_kcontrol *kcontrol, int event)
>>> +{
>>> + struct acp3x_es83xx_private *priv = get_mach_priv(w->dapm->card);
>>> +
>>> + dev_dbg(priv->codec_dev, "speaker power event: %d\n", event);
>>> + if (SND_SOC_DAPM_EVENT_ON(event))
>>> + acp3x_es83xx_set_gpios_values(priv, 1, 0);
>>> + else
>>> + acp3x_es83xx_set_gpios_values(priv, 0, 1);
>>
>> Why are these two GPIOs tied together like this?
>>
>
> These GPIOs represent the speaker and the headphone switches. When
> activating the speaker GPIO you have to deactivate the headphone GPIO
> and vice versa. The logic is taken from the discussion on the sofproject
> pull request:
> https://github.com/thesofproject/linux/pull/4112/commits/810d03e0aecdf0caf580a5179ee6873fb33485ab
> and
> https://github.com/thesofproject/linux/pull/4066
These threads didn't exactly lead to a firm conclusion on how the GPIOs
should be used, IIRC there are cases where the levels are inverted and
all kinds of issues still not clear at all even after reading the tables
from ACPI _DSM methods.
I personally gave up, and I would recommend you take these threads as
inputs rather than firm directions.
next prev parent reply other threads:[~2023-03-22 1:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 20:35 [PATCH 0/4] ASoC: amd: acp: Add sound support for a line of HUAWEI laptops Marian Postevca
2023-03-20 20:35 ` [PATCH 1/4] ASoC: es8316: Enable support for S32 LE format and MCLK div by 2 Marian Postevca
2023-03-20 20:43 ` Mark Brown
2023-03-21 17:09 ` Marian Postevca
2023-03-21 17:21 ` Mark Brown
2023-03-20 20:35 ` [PATCH 2/4] ASoC: amd: acp: Add support for splitting the codec specific code from the ACP driver Marian Postevca
2023-03-20 20:35 ` [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec Marian Postevca
2023-03-20 20:54 ` Mark Brown
2023-03-21 22:17 ` Marian Postevca
2023-03-22 1:58 ` Pierre-Louis Bossart [this message]
2023-03-22 13:07 ` Mark Brown
2023-03-22 20:48 ` Marian Postevca
2023-03-22 21:27 ` Mark Brown
2023-03-27 21:20 ` Marian Postevca
2023-03-29 13:52 ` Mark Brown
2023-08-17 21:09 ` Marian Postevca
2023-08-17 21:47 ` Mark Brown
2023-08-17 22:20 ` Marian Postevca
2023-08-18 12:52 ` Mark Brown
2023-08-20 9:32 ` Marian Postevca
2023-08-21 14:09 ` Mark Brown
2023-03-21 0:54 ` kernel test robot
2023-03-20 20:35 ` [PATCH 4/4] ASoC: amd: acp: Improve support for speaker power events Marian Postevca
2023-03-20 21:01 ` Mark Brown
2023-03-22 21:01 ` Marian Postevca
2023-03-22 21:35 ` Mark Brown
2023-03-23 1:56 [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec 沈一超
2023-03-23 13:54 ` Mark Brown
2023-03-24 1:54 Zhu Ning
2023-03-29 14:01 ` Mark Brown
2023-08-18 7:58 Zhu Ning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf458a5a-a0c0-ded7-1819-a85e548cb491@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=posteuca@mutex.one \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).