* [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up
@ 2023-04-06 13:25 Oswald Buddenhagen
2023-04-06 14:43 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Oswald Buddenhagen @ 2023-04-06 13:25 UTC (permalink / raw)
To: alsa-devel
I'm not the first one to run into this, see e.g.
https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---
include/uapi/sound/asound.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
index de6810e94abe..7eecc99ddef7 100644
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -570,7 +570,8 @@ struct __snd_pcm_mmap_status64 {
struct __snd_pcm_mmap_control64 {
__pad_before_uframe __pad1;
snd_pcm_uframes_t appl_ptr; /* RW: appl ptr (0...boundary-1) */
- __pad_before_uframe __pad2;
+ __pad_before_uframe __pad2; // This should be __pad_after_uframe, but binary
+ // backwards compatibility constraints prevent a fix.
__pad_before_uframe __pad3;
snd_pcm_uframes_t avail_min; /* RW: min available frames for wakeup */
--
2.40.0.152.g15d061e6df
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up
2023-04-06 13:25 [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up Oswald Buddenhagen
@ 2023-04-06 14:43 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2023-04-06 14:43 UTC (permalink / raw)
To: Oswald Buddenhagen; +Cc: alsa-devel
On Thu, 06 Apr 2023 15:25:21 +0200,
Oswald Buddenhagen wrote:
>
> I'm not the first one to run into this, see e.g.
> https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Applied now to for-next branch.
BTW, it'd be helpful if you put maintainers to Cc at the next time.
This will avoid overlooking patches that have been posted on ML.
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up
2023-04-06 12:34 ` Oswald Buddenhagen
@ 2023-04-06 13:23 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2023-04-06 13:23 UTC (permalink / raw)
To: Oswald Buddenhagen; +Cc: alsa-devel
On Thu, 06 Apr 2023 14:34:36 +0200,
Oswald Buddenhagen wrote:
>
> On Thu, Apr 06, 2023 at 02:29:44PM +0200, Takashi Iwai wrote:
> > Care to resubmit v2 patch?
> >
> that *was* a v2 patch - you can git-am the mail with --scissors (at
> least if i got it right). not acceptable?
Please resubmit properly. Nowadays commits have the link to the mail
of the patch submission, and such mixup makes it harder to follow.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up
2023-04-06 12:29 ` Takashi Iwai
@ 2023-04-06 12:34 ` Oswald Buddenhagen
2023-04-06 13:23 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Oswald Buddenhagen @ 2023-04-06 12:34 UTC (permalink / raw)
To: alsa-devel
On Thu, Apr 06, 2023 at 02:29:44PM +0200, Takashi Iwai wrote:
>Care to resubmit v2 patch?
>
that *was* a v2 patch - you can git-am the mail with --scissors (at
least if i got it right). not acceptable?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up
2023-04-06 11:15 ` [PATCH v2] " Oswald Buddenhagen
@ 2023-04-06 12:29 ` Takashi Iwai
2023-04-06 12:34 ` Oswald Buddenhagen
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2023-04-06 12:29 UTC (permalink / raw)
To: Oswald Buddenhagen; +Cc: alsa-devel
On Thu, 06 Apr 2023 13:15:45 +0200,
Oswald Buddenhagen wrote:
>
> On Thu, Apr 06, 2023 at 09:48:40AM +0200, Takashi Iwai wrote:
> >The "BUG:" suffix should be dropped. This would catch eyes of (badly)
> >trained kernel programmers as if it were a kernel panic message :)
> >
> done
>
> >Also the term "binary compatibility" is ambiguous in this context --
> >especially because we're dealing with the code that treats the
> >32/64bit binary compatibility.
> >
> i wasn't sure what to make of that. how about this:
>
> -- >8 --
>
> I'm not the first one to run into this, see e.g.
> https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> ---
> include/uapi/sound/asound.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index de6810e94abe..7eecc99ddef7 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -570,7 +570,8 @@ struct __snd_pcm_mmap_status64 {
> struct __snd_pcm_mmap_control64 {
> __pad_before_uframe __pad1;
> snd_pcm_uframes_t appl_ptr; /* RW: appl ptr (0...boundary-1) */
> - __pad_before_uframe __pad2;
> + __pad_before_uframe __pad2; // This should be __pad_after_uframe, but binary
> + // backwards compatibility constraints prevent a fix.
Looks much better.
Care to resubmit v2 patch?
Thanks!
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up
2023-04-06 7:48 [PATCH] " Takashi Iwai
@ 2023-04-06 11:15 ` Oswald Buddenhagen
2023-04-06 12:29 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Oswald Buddenhagen @ 2023-04-06 11:15 UTC (permalink / raw)
To: alsa-devel
On Thu, Apr 06, 2023 at 09:48:40AM +0200, Takashi Iwai wrote:
>The "BUG:" suffix should be dropped. This would catch eyes of (badly)
>trained kernel programmers as if it were a kernel panic message :)
>
done
>Also the term "binary compatibility" is ambiguous in this context --
>especially because we're dealing with the code that treats the
>32/64bit binary compatibility.
>
i wasn't sure what to make of that. how about this:
-- >8 --
I'm not the first one to run into this, see e.g.
https://lore.kernel.org/all/29QBMJU8DE71E.2YZSH8IHT5HMH@mforney.org/
Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
---
include/uapi/sound/asound.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
index de6810e94abe..7eecc99ddef7 100644
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -570,7 +570,8 @@ struct __snd_pcm_mmap_status64 {
struct __snd_pcm_mmap_control64 {
__pad_before_uframe __pad1;
snd_pcm_uframes_t appl_ptr; /* RW: appl ptr (0...boundary-1) */
- __pad_before_uframe __pad2;
+ __pad_before_uframe __pad2; // This should be __pad_after_uframe, but binary
+ // backwards compatibility constraints prevent a fix.
__pad_before_uframe __pad3;
snd_pcm_uframes_t avail_min; /* RW: min available frames for wakeup */
--
2.40.0.152.g15d061e6df
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-06 14:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 13:25 [PATCH v2] ALSA: document that struct __snd_pcm_mmap_control64 is messed up Oswald Buddenhagen
2023-04-06 14:43 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2023-04-06 7:48 [PATCH] " Takashi Iwai
2023-04-06 11:15 ` [PATCH v2] " Oswald Buddenhagen
2023-04-06 12:29 ` Takashi Iwai
2023-04-06 12:34 ` Oswald Buddenhagen
2023-04-06 13:23 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).