From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] soc-core: Questions about cpus->name && cpus->of_node
Date: 20 Jan 2020 09:32:23 +0900 [thread overview]
Message-ID: <87ftgbynl4.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <VI1PR0402MB38390D33CFFE4CC0D6AD59AEF9310@VI1PR0402MB3839.eurprd04.prod.outlook.com>
Hi Daniel
> » /*
> » * CPU device may be specified by either name or OF node, but
> » * can be left unspecified, and will be matched based on DAI
> » * name alone..
> » */
> » if (link->cpus->name && link->cpus->of_node) {
> » » dev_err(card->dev,
> » » » "ASoC: Neither/both cpu name/of_node are set for %s\n",
> » » » link->name);
> » » return -EINVAL;
> » }
>
> Here either the warning message is wrong OR the if () condition is wrong.
>
> If the link->cpus->name = NULL && link->cpus->of_node == NULL
> the warning message will be not be printed.
It seems it was added by this patch
bc92657a11c0982783979bbb84ceaf58ba222124
("ASoC: make snd_soc_dai_link more symmetrical")
it removes
- if (!!link->cpu_dai_name == !!link->cpu_dai_of_node) {
Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2020-01-20 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 8:32 [alsa-devel] soc-core: Questions about cpus->name && cpus->of_node Daniel Baluta
2020-01-20 0:32 ` Kuninori Morimoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftgbynl4.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.baluta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).