From: Dan Murphy <dmurphy@ti.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>, <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: tas2770: Fix calling reset in probe
Date: Fri, 18 Sep 2020 13:18:39 -0500 [thread overview]
Message-ID: <8bf4ae51-6cf7-aa43-e00b-c875ea5a0548@ti.com> (raw)
In-Reply-To: <20200918161842.4451-1-dmurphy@ti.com>
All
On 9/18/20 11:18 AM, Dan Murphy wrote:
> tas2770_reset is called during i2c probe. The reset calls the
> snd_soc_component_write which depends on the tas2770->component being
> available. The component pointer is not set until codec_probe so move
> the reset to the codec_probe after the pointer is set.
I have been updating the tas2770 to add another device to the driver and
I have quite a few unexpected patches on top of these.
I am not even sure how this driver is even working at the moment.
I will re-submit the complete set of patches as Mark pointed out in
another email chain.
So please ignore these patches for now plus the DT binding patch.
Dan
prev parent reply other threads:[~2020-09-18 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:18 [PATCH 1/2] ASoC: tas2770: Fix calling reset in probe Dan Murphy
2020-09-18 16:18 ` [PATCH 2/2] ASoC: tas2770: Add missing bias level power states Dan Murphy
2020-09-18 18:18 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf4ae51-6cf7-aa43-e00b-c875ea5a0548@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).