* [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message
@ 2022-05-07 12:31 Pieterjan Camerlynck
2022-05-08 7:58 ` Shengjiu Wang
2022-08-05 3:07 ` Shengjiu Wang
0 siblings, 2 replies; 4+ messages in thread
From: Pieterjan Camerlynck @ 2022-05-07 12:31 UTC (permalink / raw)
To: shengjiu.wang, Xiubo.Lee
Cc: alsa-devel, linuxppc-dev, linux-kernel, Pieterjan Camerlynck
In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support")
the loop was changed to start iterating from 1 instead of 0. The error
message however was not updated, reporting the wrong clock to the user.
Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
---
sound/soc/fsl/fsl_sai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index ffc24afb5a7a..f0602077b385 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device *pdev)
sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp);
if (IS_ERR(sai->mclk_clk[i])) {
dev_err(&pdev->dev, "failed to get mclk%d clock: %ld\n",
- i + 1, PTR_ERR(sai->mclk_clk[i]));
+ i, PTR_ERR(sai->mclk_clk[i]));
sai->mclk_clk[i] = NULL;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message
2022-05-07 12:31 [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message Pieterjan Camerlynck
@ 2022-05-08 7:58 ` Shengjiu Wang
2022-08-05 3:07 ` Shengjiu Wang
1 sibling, 0 replies; 4+ messages in thread
From: Shengjiu Wang @ 2022-05-08 7:58 UTC (permalink / raw)
To: Pieterjan Camerlynck; +Cc: alsa-devel, linuxppc-dev, linux-kernel, Xiubo Li
On Sat, May 7, 2022 at 8:31 PM Pieterjan Camerlynck <
pieterjan.camerlynck@gmail.com> wrote:
> In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support")
> the loop was changed to start iterating from 1 instead of 0. The error
> message however was not updated, reporting the wrong clock to the user.
>
> Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Best Regards
Wang Shengjiu
> ---
> sound/soc/fsl/fsl_sai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index ffc24afb5a7a..f0602077b385 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device
> *pdev)
> sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp);
> if (IS_ERR(sai->mclk_clk[i])) {
> dev_err(&pdev->dev, "failed to get mclk%d clock:
> %ld\n",
> - i + 1, PTR_ERR(sai->mclk_clk[i]));
> + i, PTR_ERR(sai->mclk_clk[i]));
> sai->mclk_clk[i] = NULL;
> }
> }
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message
2022-05-07 12:31 [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message Pieterjan Camerlynck
2022-05-08 7:58 ` Shengjiu Wang
@ 2022-08-05 3:07 ` Shengjiu Wang
1 sibling, 0 replies; 4+ messages in thread
From: Shengjiu Wang @ 2022-08-05 3:07 UTC (permalink / raw)
To: Pieterjan Camerlynck, Mark Brown
Cc: alsa-devel, linuxppc-dev, linux-kernel, Xiubo Li
On Sat, May 7, 2022 at 8:31 PM Pieterjan Camerlynck <
pieterjan.camerlynck@gmail.com> wrote:
> In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support")
> the loop was changed to start iterating from 1 instead of 0. The error
> message however was not updated, reporting the wrong clock to the user.
>
> Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
>
Please resend it and cc Mark
Best regards
Wang shengjiu
> ---
> sound/soc/fsl/fsl_sai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index ffc24afb5a7a..f0602077b385 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device
> *pdev)
> sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp);
> if (IS_ERR(sai->mclk_clk[i])) {
> dev_err(&pdev->dev, "failed to get mclk%d clock:
> %ld\n",
> - i + 1, PTR_ERR(sai->mclk_clk[i]));
> + i, PTR_ERR(sai->mclk_clk[i]));
> sai->mclk_clk[i] = NULL;
> }
> }
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message
@ 2022-08-05 6:39 Pieterjan Camerlynck
0 siblings, 0 replies; 4+ messages in thread
From: Pieterjan Camerlynck @ 2022-08-05 6:39 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linuxppc-dev, linux-kernel, Pieterjan Camerlynck
In commit <c3ecef21c3f26> ("ASoC: fsl_sai: add sai master mode support")
the loop was changed to start iterating from 1 instead of 0. The error
message however was not updated, reporting the wrong clock to the user.
Signed-off-by: Pieterjan Camerlynck <pieterjan.camerlynck@gmail.com>
---
sound/soc/fsl/fsl_sai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index ffc24afb5a7a..f0602077b385 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -1054,7 +1054,7 @@ static int fsl_sai_probe(struct platform_device *pdev)
sai->mclk_clk[i] = devm_clk_get(&pdev->dev, tmp);
if (IS_ERR(sai->mclk_clk[i])) {
dev_err(&pdev->dev, "failed to get mclk%d clock: %ld\n",
- i + 1, PTR_ERR(sai->mclk_clk[i]));
+ i, PTR_ERR(sai->mclk_clk[i]));
sai->mclk_clk[i] = NULL;
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-05 6:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 12:31 [PATCH] ASoC: fsl_sai: fix incorrect mclk number in error message Pieterjan Camerlynck
2022-05-08 7:58 ` Shengjiu Wang
2022-08-05 3:07 ` Shengjiu Wang
2022-08-05 6:39 Pieterjan Camerlynck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).