From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH] ASoC: Intel: Skylake: Compile when any configuration is selected
Date: Tue, 2 Feb 2021 13:52:11 +0800 [thread overview]
Message-ID: <CAAd53p4gqyuFPWX55fnPGHORXXf58++ZRMH9WFYp+QwS1=xDJQ@mail.gmail.com> (raw)
In-Reply-To: <324dc8a5-c4d3-6ebf-c8e9-6321d6c93dab@intel.com>
On Wed, Jan 27, 2021 at 11:22 PM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
>
> On 2021-01-27 9:03 AM, Kai-Heng Feng wrote:
> > On Mon, Jan 25, 2021 at 7:55 PM Cezary Rojewski
> > <cezary.rojewski@intel.com> wrote:
> >>
> >> Skylake is dependent on SND_SOC_INTEL_SKYLAKE (aka "all SST platforms")
> >> whereas selecting specific configuration such as KBL-only will not
> >> cause driver code to compile. Switch to SND_SOC_INTEL_SKYLAKE_COMMON
> >> dependency so selecting any configuration causes the driver to be built.
> >>
> >> Reported-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> Suggested-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> >> Fixes: 35bc99aaa1a3 ("ASoC: Intel: Skylake: Add more platform granularity")
> >> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> >
> > Still not working:
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1902457/comments/66
> >
>
> Hello,
>
> Thanks for your reply Kai-Heng.
> I believe you're relating to completely different issue than the one
> this very patch is targeting.
Understood.
>
> From the logs you've provided one can see that snd_soc_skl did attempt
> to probe() so the code compiled just fine. Again, compilation issue is
> the one I've addressed here. While we're here, I'd appreciate kconfig
> being provided along dmesg file. Logs alone do not show the entire
> picture, unfortunately.
Config file here:
https://pastebin.ubuntu.com/p/kGBv6XgHms/
>
> In regard to missing sound, (looks like we're talking about HDA dsp +
> DMIC configuration) kconfig mentioned above will be required. Pretty
> sure HDAudio support for skylake-driver is not enabled on your machine
> and thus driver exists probe() early without registering any sound card.
Do you mean CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC needs to be enabled?
Kai-Heng
>
> Regards,
> Czarek
next prev parent reply other threads:[~2021-02-02 5:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 11:54 [PATCH] ASoC: Intel: Skylake: Compile when any configuration is selected Cezary Rojewski
2021-01-27 8:03 ` Kai-Heng Feng
2021-01-27 15:22 ` Cezary Rojewski
2021-02-02 5:52 ` Kai-Heng Feng [this message]
2021-02-02 10:12 ` Cezary Rojewski
2021-02-02 10:56 ` Cezary Rojewski
2021-02-02 12:41 ` Kai-Heng Feng
2021-02-07 14:49 ` Cezary Rojewski
2021-02-15 15:43 ` Cezary Rojewski
2021-02-22 15:04 ` Kai-Heng Feng
2021-03-01 12:37 ` Cezary Rojewski
2021-03-08 2:52 ` Kai-Heng Feng
2021-03-01 23:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAd53p4gqyuFPWX55fnPGHORXXf58++ZRMH9WFYp+QwS1=xDJQ@mail.gmail.com' \
--to=kai.heng.feng@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).