From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH] ASoC: Intel: Skylake: Compile when any configuration is selected
Date: Mon, 22 Feb 2021 23:04:08 +0800 [thread overview]
Message-ID: <CAAd53p6ZyuAzNJWLyONkbFndSRF2HBLn=6HLzb5RUShCmNWdVQ@mail.gmail.com> (raw)
In-Reply-To: <f20e5e2b-3761-5e13-3166-5f026d088aa1@intel.com>
Hi Cezary,
On Mon, Feb 15, 2021 at 11:43 PM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
>
> On 2021-02-07 3:49 PM, Cezary Rojewski wrote:
> >
> > On 2021-02-02 1:41 PM, Kai-Heng Feng wrote:
> >> On Tue, Feb 2, 2021 at 6:56 PM Cezary Rojewski
> >> <cezary.rojewski@intel.com> wrote:
>
> ...
>
> >> Commit cc2d025a81a9 ("ASoC: Intel: Skylake: Update description for
> >> HDaudio kconfig") removed "DEPRECATED" from the
> >> SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC, does that mean the option is safe
> >> and should be enabled in downstream distros?
> >
> > Skylake driver - sound/soc/intel/skylake - is your only option if you
> > want to enable HDA (dsp) + DMIC configuration on SPT platforms
> > (skl/kbl/kbl-r/aml/cml-s).
>
> Hello Kai-Heng,
>
> I'd like to close the compilation issue which this patch is addressing.
> Could you confirm that the presented change fixes the issue on your end?
No, the SST regression is not fixed.
However, it's not the scope of this patch, which is to fix a different issue.
So please proceed to merge the patch. We can discuss the SST
regression in other thread.
Kai-Heng
>
> Regards,
> Czarek
next prev parent reply other threads:[~2021-02-22 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 11:54 [PATCH] ASoC: Intel: Skylake: Compile when any configuration is selected Cezary Rojewski
2021-01-27 8:03 ` Kai-Heng Feng
2021-01-27 15:22 ` Cezary Rojewski
2021-02-02 5:52 ` Kai-Heng Feng
2021-02-02 10:12 ` Cezary Rojewski
2021-02-02 10:56 ` Cezary Rojewski
2021-02-02 12:41 ` Kai-Heng Feng
2021-02-07 14:49 ` Cezary Rojewski
2021-02-15 15:43 ` Cezary Rojewski
2021-02-22 15:04 ` Kai-Heng Feng [this message]
2021-03-01 12:37 ` Cezary Rojewski
2021-03-08 2:52 ` Kai-Heng Feng
2021-03-01 23:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAd53p6ZyuAzNJWLyONkbFndSRF2HBLn=6HLzb5RUShCmNWdVQ@mail.gmail.com' \
--to=kai.heng.feng@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).