From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 5/6] ASoC: samsung: tm2_wm5110: check of_parse return value
Date: Mon, 22 Feb 2021 18:28:33 +0100 [thread overview]
Message-ID: <CAJKOXPfDEkFPe+kAoH-dYveSTy8OPEzXJDnFN4AMqZgeW88PRQ@mail.gmail.com> (raw)
In-Reply-To: <ac9fd25e-d5dd-6c47-07fc-ba05e33f60dd@linux.intel.com>
On Mon, 22 Feb 2021 at 17:45, Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> >> diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
> >> index 9300fef9bf26..da6204248f82 100644
> >> --- a/sound/soc/samsung/tm2_wm5110.c
> >> +++ b/sound/soc/samsung/tm2_wm5110.c
> >> @@ -553,7 +553,7 @@ static int tm2_probe(struct platform_device *pdev)
> >>
> >> ret = of_parse_phandle_with_args(dev->of_node, "i2s-controller",
> >> cells_name, i, &args);
> >> - if (!args.np) {
> >> + if (ret || !args.np) {
> >
> > Only "if (ret)" because args.np won't be initialized on errors.
>
> Thanks Krzysztof for the review, I will make that change in a v2.
> But just to be clear, there's no need to test args.np then?
Correct, no need to test args.np.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-02-22 17:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:09 [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Pierre-Louis Bossart
2021-02-19 23:09 ` [PATCH 1/6] ASoC: samsung: i2s: remove unassigned variable Pierre-Louis Bossart
2021-02-21 10:53 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 2/6] ASoC: samsung: s3c24xx_simtec: add missing error check Pierre-Louis Bossart
2021-02-21 10:55 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 3/6] ASoC: samsung: smdk_wm8994: add missing return Pierre-Louis Bossart
2021-02-21 10:59 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 4/6] ASoC: samsung: snow: remove useless test Pierre-Louis Bossart
2021-02-21 11:04 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 5/6] ASoC: samsung: tm2_wm5110: check of_parse return value Pierre-Louis Bossart
2021-02-21 11:10 ` Krzysztof Kozlowski
2021-02-22 15:35 ` Pierre-Louis Bossart
2021-02-22 17:28 ` Krzysztof Kozlowski [this message]
2021-02-19 23:09 ` [PATCH 6/6] ASoC: samsung: tm2_wm5510: remove shadowing variable Pierre-Louis Bossart
2021-02-21 11:12 ` Krzysztof Kozlowski
2021-02-22 15:36 ` Pierre-Louis Bossart
2021-02-23 11:30 ` Sylwester Nawrocki
2021-02-22 16:07 ` (subset) [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Mark Brown
2021-02-22 17:31 ` Krzysztof Kozlowski
2021-02-22 20:19 ` Mark Brown
2021-02-22 20:39 ` Pierre-Louis Bossart
2021-03-01 23:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPfDEkFPe+kAoH-dYveSTy8OPEzXJDnFN4AMqZgeW88PRQ@mail.gmail.com \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).