From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: (subset) [PATCH 0/6] ASoC: samsung: remove cppcheck warnings
Date: Mon, 22 Feb 2021 20:19:29 +0000 [thread overview]
Message-ID: <20210222201929.GF6127@sirena.org.uk> (raw)
In-Reply-To: <CAJKOXPe6LZuuL0ntPAEwudEtMcGreBLMHzBFg5jw_3=DpG8KVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Mon, Feb 22, 2021 at 06:31:15PM +0100, Krzysztof Kozlowski wrote:
> Hmmm, I had comments about this one so it should not have been
> applied. The check if (ret || !args.np) is still not good (or
> confusing) because args is an uninitialized stack value.
Ah, I saw the "this is actually a fix CC stable" bit, the bit saying
there were issues was hidden - it looked like you'd just not deleted
context.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-22 20:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:09 [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Pierre-Louis Bossart
2021-02-19 23:09 ` [PATCH 1/6] ASoC: samsung: i2s: remove unassigned variable Pierre-Louis Bossart
2021-02-21 10:53 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 2/6] ASoC: samsung: s3c24xx_simtec: add missing error check Pierre-Louis Bossart
2021-02-21 10:55 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 3/6] ASoC: samsung: smdk_wm8994: add missing return Pierre-Louis Bossart
2021-02-21 10:59 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 4/6] ASoC: samsung: snow: remove useless test Pierre-Louis Bossart
2021-02-21 11:04 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 5/6] ASoC: samsung: tm2_wm5110: check of_parse return value Pierre-Louis Bossart
2021-02-21 11:10 ` Krzysztof Kozlowski
2021-02-22 15:35 ` Pierre-Louis Bossart
2021-02-22 17:28 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 6/6] ASoC: samsung: tm2_wm5510: remove shadowing variable Pierre-Louis Bossart
2021-02-21 11:12 ` Krzysztof Kozlowski
2021-02-22 15:36 ` Pierre-Louis Bossart
2021-02-23 11:30 ` Sylwester Nawrocki
2021-02-22 16:07 ` (subset) [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Mark Brown
2021-02-22 17:31 ` Krzysztof Kozlowski
2021-02-22 20:19 ` Mark Brown [this message]
2021-02-22 20:39 ` Pierre-Louis Bossart
2021-03-01 23:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222201929.GF6127@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=krzk@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).