From: Nick Desaulniers <ndesaulniers@google.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>
Cc: alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>,
Sia Jee Heng <jee.heng.sia@intel.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Mark Brown <broonie@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] ASoC: Intel: KeemBay: Fix header guard
Date: Tue, 30 Jun 2020 15:22:25 -0700 [thread overview]
Message-ID: <CAKwvOdkXfW0vncswB_OjLfVu4-dAqZXaotw44y6TZSVEezWW0Q@mail.gmail.com> (raw)
In-Reply-To: <20200617010232.23222-1-natechancellor@gmail.com>
On Tue, Jun 16, 2020 at 6:02 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns:
>
> In file included from sound/soc/intel/keembay/kmb_platform.c:14:
> sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_'
> is used as a header guard here, followed by #define of a different
> macro [-Wheader-guard]
> #ifndef KMB_PLATFORM_H_
> ^~~~~~~~~~~~~~~
> sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_'
> is defined here; did you mean 'KMB_PLATFORM_H_'?
> #define KMB_PLATFORMP_H_
> ^~~~~~~~~~~~~~~~
> KMB_PLATFORM_H_
> 1 warning generated.
>
> Fix the typo so that the header guard works as intended.
>
> Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1053
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> sound/soc/intel/keembay/kmb_platform.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/keembay/kmb_platform.h b/sound/soc/intel/keembay/kmb_platform.h
> index 29600652d8f4..6bf221aa8fff 100644
> --- a/sound/soc/intel/keembay/kmb_platform.h
> +++ b/sound/soc/intel/keembay/kmb_platform.h
> @@ -7,7 +7,7 @@
> */
>
> #ifndef KMB_PLATFORM_H_
> -#define KMB_PLATFORMP_H_
> +#define KMB_PLATFORM_H_
>
> #include <linux/bits.h>
> #include <linux/bitfield.h>
>
> base-commit: 27f70ec4fa0e0f419031f1b8d61b1a788244e313
> --
> 2.27.0
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200617010232.23222-1-natechancellor%40gmail.com.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-06-30 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 1:02 [PATCH] ASoC: Intel: KeemBay: Fix header guard Nathan Chancellor
2020-06-22 3:26 ` Sia, Jee Heng
2020-06-30 21:04 ` Nathan Chancellor
2020-06-30 21:57 ` Mark Brown
2020-06-30 22:22 ` Nick Desaulniers [this message]
2020-07-01 22:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkXfW0vncswB_OjLfVu4-dAqZXaotw44y6TZSVEezWW0Q@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jee.heng.sia@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).