* move alc892 to patch_alc882
@ 2014-03-27 9:47 Kailang
2014-03-27 10:06 ` Takashi Iwai
2014-04-05 6:52 ` Raymond Yau
0 siblings, 2 replies; 22+ messages in thread
From: Kailang @ 2014-03-27 9:47 UTC (permalink / raw)
To: Kailang, Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 104 bytes --]
Hi Takashi,
The original was patch to patch_alc662.
Move it into patch_alc882.
Thanks.
BR,
Kailang
[-- Attachment #2: 0000-move-alc892-to-patch_alc882.patch --]
[-- Type: application/octet-stream, Size: 1067 bytes --]
>From 4f59a160db58ab7cbc090ba1d6a80cdc8ac18168 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 27 Mar 2014 17:40:24 +0800
Subject: [PATCH] ALSA: hda/realtek - Move ALC892 to patch_alc882 entry
The old was entry to patch_alc662.
Move it into patch_alc882.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index af5f903..b074d75 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5796,7 +5796,7 @@ static const struct hda_codec_preset snd_hda_preset_realtek[] = {
.patch = patch_alc882 },
{ .id = 0x10ec0888, .name = "ALC888", .patch = patch_alc882 },
{ .id = 0x10ec0889, .name = "ALC889", .patch = patch_alc882 },
- { .id = 0x10ec0892, .name = "ALC892", .patch = patch_alc662 },
+ { .id = 0x10ec0892, .name = "ALC892", .patch = patch_alc882 },
{ .id = 0x10ec0899, .name = "ALC898", .patch = patch_alc882 },
{ .id = 0x10ec0900, .name = "ALC1150", .patch = patch_alc882 },
{} /* terminator */
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-03-27 9:47 move alc892 to patch_alc882 Kailang
@ 2014-03-27 10:06 ` Takashi Iwai
2014-04-05 6:52 ` Raymond Yau
1 sibling, 0 replies; 22+ messages in thread
From: Takashi Iwai @ 2014-03-27 10:06 UTC (permalink / raw)
To: Kailang; +Cc: alsa-devel
At Thu, 27 Mar 2014 17:47:11 +0800,
Kailang wrote:
>
> Hi Takashi,
>
> The original was patch to patch_alc662.
> Move it into patch_alc882.
Could you give a bit more background *why* this change is necessary?
It's the most important part. Please put into the patch description
and resubmit.
thanks,
Takashi
>
> Thanks.
>
> BR,
> Kailang
> [2 0000-move-alc892-to-patch_alc882.patch <application/octet-stream (quoted-printable)>]
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-03-27 9:47 move alc892 to patch_alc882 Kailang
2014-03-27 10:06 ` Takashi Iwai
@ 2014-04-05 6:52 ` Raymond Yau
2014-04-06 7:58 ` Takashi Iwai
1 sibling, 1 reply; 22+ messages in thread
From: Raymond Yau @ 2014-04-05 6:52 UTC (permalink / raw)
To: Kailang; +Cc: Takashi Iwai, ALSA Development Mailing List
Hi Takashi,
>
> The original was patch to patch_alc662.
> Move it into patch_alc882.
>
>
is there any reason not including those PCI QUIRK for alc892 ?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-05 6:52 ` Raymond Yau
@ 2014-04-06 7:58 ` Takashi Iwai
2014-04-07 6:04 ` Kailang
0 siblings, 1 reply; 22+ messages in thread
From: Takashi Iwai @ 2014-04-06 7:58 UTC (permalink / raw)
To: Raymond Yau; +Cc: ALSA Development Mailing List, Kailang
At Sat, 5 Apr 2014 14:52:24 +0800,
Raymond Yau wrote:
>
> Hi Takashi,
>
> >
> > The original was patch to patch_alc662.
> > Move it into patch_alc882.
> >
> >
> is there any reason not including those PCI QUIRK for alc892 ?
Because it's not clarified why this must be applied.
I'm waiting for the updated patch from Kailang.
Takashi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-06 7:58 ` Takashi Iwai
@ 2014-04-07 6:04 ` Kailang
2014-04-07 8:37 ` Takashi Iwai
0 siblings, 1 reply; 22+ messages in thread
From: Kailang @ 2014-04-07 6:04 UTC (permalink / raw)
To: Takashi Iwai, Raymond Yau; +Cc: ALSA Development Mailing List
> At Sat, 5 Apr 2014 14:52:24 +0800,
> Raymond Yau wrote:
>>
>> Hi Takashi,
>>
>> >
>> > The original was patch to patch_alc662.
>> > Move it into patch_alc882.
>> >
>> >
>> is there any reason not including those PCI QUIRK for alc892 ?
>
> Because it's not clarified why this must be applied.
> I'm waiting for the updated patch from Kailang.
>
Sorry!
I just aligned the channel count.
So, move the alc892 to patch_alc882.
>
> Takashi
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-07 6:04 ` Kailang
@ 2014-04-07 8:37 ` Takashi Iwai
2014-04-07 8:59 ` Improve hp pop noise Kailang
2014-04-07 9:19 ` move alc892 to patch_alc882 Kailang
0 siblings, 2 replies; 22+ messages in thread
From: Takashi Iwai @ 2014-04-07 8:37 UTC (permalink / raw)
To: Kailang; +Cc: ALSA Development Mailing List
At Mon, 7 Apr 2014 14:04:34 +0800,
Kailang wrote:
>
>
> > At Sat, 5 Apr 2014 14:52:24 +0800,
> > Raymond Yau wrote:
> >>
> >> Hi Takashi,
> >>
> >> >
> >> > The original was patch to patch_alc662.
> >> > Move it into patch_alc882.
> >> >
> >> >
> >> is there any reason not including those PCI QUIRK for alc892 ?
> >
> > Because it's not clarified why this must be applied.
> > I'm waiting for the updated patch from Kailang.
> >
>
> Sorry!
> I just aligned the channel count.
> So, move the alc892 to patch_alc882.
As I already asked, could you resubmit the patch with the proper
changelog? You have to clarify why the patch is needed and how it's
solved in the patch changelog.
Takashi
>
> >
> > Takashi
> >
> > ------Please consider the environment before printing this e-mail.
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Improve hp pop noise
2014-04-07 8:37 ` Takashi Iwai
@ 2014-04-07 8:59 ` Kailang
2014-04-07 10:33 ` Takashi Iwai
2014-04-07 9:19 ` move alc892 to patch_alc882 Kailang
1 sibling, 1 reply; 22+ messages in thread
From: Kailang @ 2014-04-07 8:59 UTC (permalink / raw)
To: Takashi Iwai; +Cc: ALSA Development Mailing List
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
Hi Takashi,
In our test, it is better to set Mic2-vref control to manual mode.
It will have better result for HP pop noise.
So, I fill it back in this patch.
BR,
Kailang
[-- Attachment #2: 0000-improve-hp-pop-noise.patch --]
[-- Type: application/octet-stream, Size: 1095 bytes --]
>From 91b5643db5db060f21808e22a416540d061181de Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Mon, 7 Apr 2014 16:41:52 +0800
Subject: [PATCH] ALSA: hda/realtek - Improve HP depop when system change power
state
It is better to change Mic2-Vref to manual mode.
Manual control Mic2-Vref will solve pop noise issue.
It will improve pop noise for power on, power off
,S3 and resume.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4ce744b..b36be20 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4005,6 +4005,10 @@ static void alc283_fixup_chromebook(struct hda_codec *codec,
spec->gen.mixer_nid = 0;
break;
case HDA_FIXUP_ACT_INIT:
+ /* MIC2-VREF control */
+ /* Set to manual mode */
+ val = alc_read_coef_idx(codec, 0x06);
+ alc_write_coef_idx(codec, 0x06, val & ~0x000c);
/* Enable Line1 input control by verb */
val = alc_read_coef_idx(codec, 0x1a);
alc_write_coef_idx(codec, 0x1a, val | (1 << 4));
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-07 8:37 ` Takashi Iwai
2014-04-07 8:59 ` Improve hp pop noise Kailang
@ 2014-04-07 9:19 ` Kailang
2014-04-07 11:11 ` Raymond Yau
` (2 more replies)
1 sibling, 3 replies; 22+ messages in thread
From: Kailang @ 2014-04-07 9:19 UTC (permalink / raw)
To: Takashi Iwai; +Cc: ALSA Development Mailing List
> At Mon, 7 Apr 2014 14:04:34 +0800,
> Kailang wrote:
>>
>>
>> > At Sat, 5 Apr 2014 14:52:24 +0800,
>> > Raymond Yau wrote:
>> >>
>> >> Hi Takashi,
>> >>
>> >> >
>> >> > The original was patch to patch_alc662.
>> >> > Move it into patch_alc882.
>> >> >
>> >> >
>> >> is there any reason not including those PCI QUIRK for alc892 ?
>> >
>> > Because it's not clarified why this must be applied.
>> > I'm waiting for the updated patch from Kailang.
>> >
>>
>> Sorry!
>> I just aligned the channel count.
>> So, move the alc892 to patch_alc882.
>
> As I already asked, could you resubmit the patch with the proper
> changelog? You have to clarify why the patch is needed and how it's
> solved in the patch changelog.
>
Yes, but it maybe doesn't solve any thing.
But I remember I solve 8ch issue which run for patch_alc882.
I will check alc892 for run with patch_alc882.
Thanks.
>
> Takashi
>
>
>>
>> >
>> > Takashi
>> >
>> > ------Please consider the environment before printing this e-mail.
>>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: Improve hp pop noise
2014-04-07 8:59 ` Improve hp pop noise Kailang
@ 2014-04-07 10:33 ` Takashi Iwai
2014-04-08 7:34 ` Change module name for Chrome Kailang
0 siblings, 1 reply; 22+ messages in thread
From: Takashi Iwai @ 2014-04-07 10:33 UTC (permalink / raw)
To: Kailang; +Cc: ALSA Development Mailing List
At Mon, 7 Apr 2014 16:59:23 +0800,
Kailang wrote:
>
> Hi Takashi,
>
> In our test, it is better to set Mic2-vref control to manual mode.
> It will have better result for HP pop noise.
> So, I fill it back in this patch.
OK, I applied it now. Thanks.
Takashi
>
> BR,
> Kailang
> [2 0000-improve-hp-pop-noise.patch <application/octet-stream (quoted-printable)>]
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-07 9:19 ` move alc892 to patch_alc882 Kailang
@ 2014-04-07 11:11 ` Raymond Yau
2014-04-08 9:08 ` Kailang
2014-04-10 1:30 ` Raymond Yau
2014-04-10 1:44 ` Raymond Yau
2 siblings, 1 reply; 22+ messages in thread
From: Raymond Yau @ 2014-04-07 11:11 UTC (permalink / raw)
To: Kailang; +Cc: Takashi Iwai, ALSA Development Mailing List
2014-4-7 下午5:20 於 "Kailang" <kailang@realtek.com> 寫道:
>
>
>
>> At Mon, 7 Apr 2014 14:04:34 +0800,
>> Kailang wrote:
>>>
>>>
>>>
>>> > At Sat, 5 Apr 2014 14:52:24 +0800,
>>> > Raymond Yau wrote:
>>> >> >> Hi Takashi,
>>> >> >> >
>>> >> > The original was patch to patch_alc662.
>>> >> > Move it into patch_alc882.
>>> >> >
>>> >> >
>>> >> is there any reason not including those PCI QUIRK for alc892 ?
>>> > > Because it's not clarified why this must be applied.
>>> > I'm waiting for the updated patch from Kailang.
>>> >
>>> Sorry!
>>> I just aligned the channel count.
>>> So, move the alc892 to patch_alc882.
>>
>>
>> As I already asked, could you resubmit the patch with the proper
>> changelog? You have to clarify why the patch is needed and how it's
>> solved in the patch changelog.
>>
>
> Yes, but it maybe doesn't solve any thing.
> But I remember I solve 8ch issue which run for patch_alc882.
> I will check alc892 for run with patch_alc882.
> Thanks.
>
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=e16fb6d1408bca0c0b36d490688eba3dc924b1fd
+ { 0x10ec0892, 0xffff, 0x8020, "ALC661" },
+ { 0x10ec0892, 0xffff, 0x8011, "ALC661" },
+ { 0x10ec0892, 0xffff, 0x4011, "ALC656" },
Seem some codec were renamed as alc661 and alc656
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Change module name for Chrome
2014-04-07 10:33 ` Takashi Iwai
@ 2014-04-08 7:34 ` Kailang
2014-04-08 7:58 ` Takashi Iwai
0 siblings, 1 reply; 22+ messages in thread
From: Kailang @ 2014-04-08 7:34 UTC (permalink / raw)
To: Takashi Iwai; +Cc: ALSA Development Mailing List
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
Hi Takashi,
Chrome OS was use alc283-dac-wcaps module name as default in their kernel.
I was create the change patch for future support.
Thanks.
BR,
Kailang
[-- Attachment #2: 0000-change-module-name-for-chrome.patch --]
[-- Type: application/octet-stream, Size: 1137 bytes --]
>From 5ed939f4dde9b88af829c1bd25486edbea8f2da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Tue, 8 Apr 2014 15:19:49 +0800
Subject: [PATCH] ALSA: hda/realtek - Change module name alias for ChromeOS
Chrome OS was use module name of alc283-dac-wcaps for loading module as default.
Change the module name to same as module name of Chrome OS for future support.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b36be20..237867d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4783,7 +4783,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
{.id = ALC269_FIXUP_HP_GPIO_LED, .name = "hp-gpio-led"},
{.id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, .name = "dell-headset-multi"},
{.id = ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, .name = "dell-headset-dock"},
- {.id = ALC283_FIXUP_CHROME_BOOK, .name = "alc283-chrome"},
+ {.id = ALC283_FIXUP_CHROME_BOOK, .name = "alc283-dac-wcaps"},
{.id = ALC283_FIXUP_SENSE_COMBO_JACK, .name = "alc283-sense-combo"},
{}
};
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: Change module name for Chrome
2014-04-08 7:34 ` Change module name for Chrome Kailang
@ 2014-04-08 7:58 ` Takashi Iwai
2014-04-08 8:06 ` Kailang
0 siblings, 1 reply; 22+ messages in thread
From: Takashi Iwai @ 2014-04-08 7:58 UTC (permalink / raw)
To: Kailang; +Cc: alsa-devel
At Tue, 8 Apr 2014 15:34:18 +0800,
Kailang wrote:
>
> Hi Takashi,
>
> Chrome OS was use alc283-dac-wcaps module name as default in their kernel.
> I was create the change patch for future support.
You mean "model" name, right? If so, please correct and resubmit the
patch.
thanks,
Takashi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: Change module name for Chrome
2014-04-08 7:58 ` Takashi Iwai
@ 2014-04-08 8:06 ` Kailang
2014-04-08 8:39 ` Takashi Iwai
0 siblings, 1 reply; 22+ messages in thread
From: Kailang @ 2014-04-08 8:06 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
Oh! sorry..
Attach again.
> At Tue, 8 Apr 2014 15:34:18 +0800,
> Kailang wrote:
>>
>> Hi Takashi,
>>
>> Chrome OS was use alc283-dac-wcaps module name as default in their
>> kernel.
>> I was create the change patch for future support.
>
> You mean "model" name, right? If so, please correct and resubmit the
> patch.
>
>
> thanks,
>
> Takashi
>
> ------Please consider the environment before printing this e-mail.
[-- Attachment #2: 0000-change-model-name-for-chrome.patch --]
[-- Type: application/octet-stream, Size: 1132 bytes --]
>From 5ed939f4dde9b88af829c1bd25486edbea8f2da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Tue, 8 Apr 2014 15:19:49 +0800
Subject: [PATCH] ALSA: hda/realtek - Change model name alias for ChromeOS
Chrome OS was use model name of alc283-dac-wcaps for loading model as default.
Change the model name to same as model name of Chrome OS for future support.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b36be20..237867d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4783,7 +4783,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
{.id = ALC269_FIXUP_HP_GPIO_LED, .name = "hp-gpio-led"},
{.id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, .name = "dell-headset-multi"},
{.id = ALC269_FIXUP_DELL2_MIC_NO_PRESENCE, .name = "dell-headset-dock"},
- {.id = ALC283_FIXUP_CHROME_BOOK, .name = "alc283-chrome"},
+ {.id = ALC283_FIXUP_CHROME_BOOK, .name = "alc283-dac-wcaps"},
{.id = ALC283_FIXUP_SENSE_COMBO_JACK, .name = "alc283-sense-combo"},
{}
};
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: Change module name for Chrome
2014-04-08 8:06 ` Kailang
@ 2014-04-08 8:39 ` Takashi Iwai
2014-04-08 8:56 ` Kailang
2014-04-08 9:22 ` Add eapd shutup to alc283 Kailang
0 siblings, 2 replies; 22+ messages in thread
From: Takashi Iwai @ 2014-04-08 8:39 UTC (permalink / raw)
To: Kailang; +Cc: alsa-devel
At Tue, 8 Apr 2014 16:06:22 +0800,
Kailang wrote:
>
>
> Oh! sorry..
> Attach again.
Thanks, applied.
Takashi
>
>
> > At Tue, 8 Apr 2014 15:34:18 +0800,
> > Kailang wrote:
> >>
> >> Hi Takashi,
> >>
> >> Chrome OS was use alc283-dac-wcaps module name as default in their
> >> kernel.
> >> I was create the change patch for future support.
> >
> > You mean "model" name, right? If so, please correct and resubmit the
> > patch.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > ------Please consider the environment before printing this e-mail.
> [2 0000-change-model-name-for-chrome.patch <application/octet-stream (quoted-printable)>]
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: Change module name for Chrome
2014-04-08 8:39 ` Takashi Iwai
@ 2014-04-08 8:56 ` Kailang
2014-04-08 9:22 ` Add eapd shutup to alc283 Kailang
1 sibling, 0 replies; 22+ messages in thread
From: Kailang @ 2014-04-08 8:56 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
git clone git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
sound.git
I use upper to download kernel source code.
It only has master branch.
If i run git pull, it couldn't update for-linus branch. Right?
When is the for-linus or for-next will be merged into master?
Thanks
> At Tue, 8 Apr 2014 16:06:22 +0800,
> Kailang wrote:
>>
>>
>> Oh! sorry..
>> Attach again.
>
> Thanks, applied.
>
>
> Takashi
>
>>
>>
>> > At Tue, 8 Apr 2014 15:34:18 +0800,
>> > Kailang wrote:
>> >>
>> >> Hi Takashi,
>> >>
>> >> Chrome OS was use alc283-dac-wcaps module name as default in their
>> >> kernel.
>> >> I was create the change patch for future support.
>> >
>> > You mean "model" name, right? If so, please correct and resubmit the
>> > patch.
>> >
>> >
>> > thanks,
>> >
>> > Takashi
>> >
>> > ------Please consider the environment before printing this e-mail.
>> [2 0000-change-model-name-for-chrome.patch <application/octet-stream
>> (quoted-printable)>]
>>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-07 11:11 ` Raymond Yau
@ 2014-04-08 9:08 ` Kailang
2014-04-09 4:53 ` Raymond Yau
0 siblings, 1 reply; 22+ messages in thread
From: Kailang @ 2014-04-08 9:08 UTC (permalink / raw)
To: Raymond Yau; +Cc: Takashi Iwai, ALSA Development Mailing List
>2014-4-7 下午5:20 於 "Kailang" <kailang@realtek.com> 寫道:
>
>
>
>> At Mon, 7 Apr 2014 14:04:34 +0800,
>> Kailang wrote:
>>>
>>>
>>>
>>> > At Sat, 5 Apr 2014 14:52:24 +0800,
>>> > Raymond Yau wrote:
>>> >> >> Hi Takashi,
>>> >> >> >
>>> >> > The original was patch to patch_alc662.
>>> >> > Move it into patch_alc882.
>>> >> >
>>> >> >
>>> >> is there any reason not including those PCI QUIRK for alc892 ?
>>> > > Because it's not clarified why this must be applied.
>>> > I'm waiting for the updated patch from Kailang.
>>> >
>>> Sorry!
>>> I just aligned the channel count.
>>> So, move the alc892 to patch_alc882.
>>
>>
>> As I already asked, could you resubmit the patch with the proper
>> changelog? You have to clarify why the patch is needed and how it's
>> solved in the patch changelog.
>>
>
> Yes, but it maybe doesn't solve any thing.
> But I remember I solve 8ch issue which run for patch_alc882.
> I will check alc892 for run with patch_alc882.
> Thanks.
>
>https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=e16fb6d1408bca0c0b36d490688eba3dc924b1fd
>+ { 0x10ec0892, 0xffff, 0x8020, "ALC661" },
>+ { 0x10ec0892, 0xffff, 0x8011, "ALC661" },
>+ { 0x10ec0892, 0xffff, 0x4011, "ALC656" },
>Seem some codec were renamed as alc661 and alc656
Yes, it's the same body. IC mark shows different.
------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Add eapd shutup to alc283
2014-04-08 8:39 ` Takashi Iwai
2014-04-08 8:56 ` Kailang
@ 2014-04-08 9:22 ` Kailang
1 sibling, 0 replies; 22+ messages in thread
From: Kailang @ 2014-04-08 9:22 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Hi Takashi,
Maybe internal speaker will have pop noise when system enter to suspend.
Add eapd shutup to alc283_shutup.
Thanks.
BR,
Kailang
[-- Attachment #2: 0000-add-eapd-shutup-for-alc283.patch --]
[-- Type: application/octet-stream, Size: 771 bytes --]
>From 81b05a94bb3d9d29bf3f431766ba95b5cce43e68 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Tue, 8 Apr 2014 17:14:14 +0800
Subject: [PATCH] ALSA: hda/realtek - Add eapd shutup to ALC283
Add eapd shutup function to alc283_shutup.
It could avoid pop noise from speaker.
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ca1298a..5a9879a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3095,6 +3095,7 @@ static void alc283_shutup(struct hda_codec *codec)
if (hp_pin_sense)
msleep(100);
+ alc_auto_setup_eapd(codec, false);
snd_hda_shutup_pins(codec);
alc_write_coef_idx(codec, 0x43, 0x9614);
}
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-08 9:08 ` Kailang
@ 2014-04-09 4:53 ` Raymond Yau
2014-04-09 6:30 ` Kailang
0 siblings, 1 reply; 22+ messages in thread
From: Raymond Yau @ 2014-04-09 4:53 UTC (permalink / raw)
To: Kailang; +Cc: Takashi Iwai, ALSA Development Mailing List
>>>> >> >> >
>>>> >> > The original was patch to patch_alc662.
>>>> >> > Move it into patch_alc882.
>>>> >> >
>>>> >> >
>>>> >> is there any reason not including those PCI QUIRK for alc892 ?
>>>> > > Because it's not clarified why this must be applied.
>>>> > I'm waiting for the updated patch from Kailang.
>>>> >
>>>> Sorry!
>>>> I just aligned the channel count.
>>>> So, move the alc892 to patch_alc882.
>>>
>>>
>>>
>>> As I already asked, could you resubmit the patch with the proper
>>> changelog? You have to clarify why the patch is needed and how it's
>>> solved in the patch changelog.
>>>
>>
>> Yes, but it maybe doesn't solve any thing.
>> But I remember I solve 8ch issue which run for patch_alc882.
>> I will check alc892 for run with patch_alc882.
>> Thanks.
>>
>
>>
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=e16fb6d1408bca0c0b36d490688eba3dc924b1fd
>
>
>> + { 0x10ec0892, 0xffff, 0x8020, "ALC661" },
>> + { 0x10ec0892, 0xffff, 0x8011, "ALC661" },
>> + { 0x10ec0892, 0xffff, 0x4011, "ALC656" },
>> Seem some codec were renamed as alc661 and alc656
>
>
> Yes, it's the same body. IC mark shows different.
>
Can the driver assume all desktop with alc8xx codecs support multistreaming
playback ?
It seem that alc6xx does not support multistreaming playback
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-09 4:53 ` Raymond Yau
@ 2014-04-09 6:30 ` Kailang
2014-04-09 7:24 ` Raymond Yau
0 siblings, 1 reply; 22+ messages in thread
From: Kailang @ 2014-04-09 6:30 UTC (permalink / raw)
To: Raymond Yau; +Cc: Takashi Iwai, ALSA Development Mailing List
Hi Raymond,
Your multi-streaming means muti channel out or separate output at the same time.
BR,
Kailang
----- Original Message -----
寄件者: Raymond Yau
收件者: Kailang
副本: Takashi Iwai ; ALSA Development Mailing List
傳送日期: 2014年4月9日 下午 12:53
主旨: Re: [alsa-devel] move alc892 to patch_alc882
>>>> >> >> >
>>>> >> > The original was patch to patch_alc662.
>>>> >> > Move it into patch_alc882.
>>>> >> >
>>>> >> >
>>>> >> is there any reason not including those PCI QUIRK for alc892 ?
>>>> > > Because it's not clarified why this must be applied.
>>>> > I'm waiting for the updated patch from Kailang.
>>>> >
>>>> Sorry!
>>>> I just aligned the channel count.
>>>> So, move the alc892 to patch_alc882.
>>>
>>>
>>>
>>> As I already asked, could you resubmit the patch with the proper
>>> changelog? You have to clarify why the patch is needed and how it's
>>> solved in the patch changelog.
>>>
>>
>> Yes, but it maybe doesn't solve any thing.
>> But I remember I solve 8ch issue which run for patch_alc882.
>> I will check alc892 for run with patch_alc882.
>> Thanks.
>>
>
>> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=e16fb6d1408bca0c0b36d490688eba3dc924b1fd
>
>
>> + { 0x10ec0892, 0xffff, 0x8020, "ALC661" },
>> + { 0x10ec0892, 0xffff, 0x8011, "ALC661" },
>> + { 0x10ec0892, 0xffff, 0x4011, "ALC656" },
>> Seem some codec were renamed as alc661 and alc656
>
>
> Yes, it's the same body. IC mark shows different.
>
Can the driver assume all desktop with alc8xx codecs support multistreaming playback ?
It seem that alc6xx does not support multistreaming playback
------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-09 6:30 ` Kailang
@ 2014-04-09 7:24 ` Raymond Yau
0 siblings, 0 replies; 22+ messages in thread
From: Raymond Yau @ 2014-04-09 7:24 UTC (permalink / raw)
To: Kailang; +Cc: Takashi Iwai, ALSA Development Mailing List
2014-4-9 下午2:30 於 "Kailang" <kailang@realtek.com> 寫道:
>
> Hi Raymond,
>
> Your multi-streaming means muti channel out or separate output at the
same time.
Seem most 6 channels codecs does not support multisteaming playback
The ALC892 provides ten DAC channels that simultaneously support 7.1
channel sound playback, plus 2 channels of independent stereo sound output
(multiple streaming) through the front panel stereo outputs
The ALC231 is a High Definition Audio Codec that integrates a 4-channel
DAC, 4-channel ADC, and a mono and filter-less Class-D Speaker Amplifier
with 2Watt (rms) output power.
The 4-channel DAC and 4-channel ADC support two independent stereo sound
outputs and two independent stereo inputs simultaneously; allowing multiple
streaming playback and output for multimedia applications and voice
communication.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-07 9:19 ` move alc892 to patch_alc882 Kailang
2014-04-07 11:11 ` Raymond Yau
@ 2014-04-10 1:30 ` Raymond Yau
2014-04-10 1:44 ` Raymond Yau
2 siblings, 0 replies; 22+ messages in thread
From: Raymond Yau @ 2014-04-10 1:30 UTC (permalink / raw)
To: Kailang; +Cc: Takashi Iwai, ALSA Development Mailing List
>>>
>>>
>>> > At Sat, 5 Apr 2014 14:52:24 +0800,
>>> > Raymond Yau wrote:
>>> >> >> Hi Takashi,
>>> >> >> >
>>> >> > The original was patch to patch_alc662.
>>> >> > Move it into patch_alc882.
>>> >> >
>>> >> >
>>> >> is there any reason not including those PCI QUIRK for alc892 ?
>>> > > Because it's not clarified why this must be applied.
>>> > I'm waiting for the updated patch from Kailang.
>>> >
>>> Sorry!
>>> I just aligned the channel count.
>>> So, move the alc892 to patch_alc882.
>>
>>
>> As I already asked, could you resubmit the patch with the proper
>> changelog? You have to clarify why the patch is needed and how it's
>> solved in the patch changelog.
>>
>
> Yes, but it maybe doesn't solve any thing.
> But I remember I solve 8ch issue which run for patch_alc882.
> I will check alc892 for run with patch_alc882.
The driver seem assume unique PCI ssid but it seem gigabyte motherboards
use same ssid 0x1458, 0xa002
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=b2c53e206967d01fd4fb6dd525f89ae738beb2e6
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=78f8baf138311be3e170526388b0530a172bdbff
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/sound/pci/hda/patch_realtek.c?id=8f2392142346f2754c8292a94cc62a157ed1e093
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: move alc892 to patch_alc882
2014-04-07 9:19 ` move alc892 to patch_alc882 Kailang
2014-04-07 11:11 ` Raymond Yau
2014-04-10 1:30 ` Raymond Yau
@ 2014-04-10 1:44 ` Raymond Yau
2 siblings, 0 replies; 22+ messages in thread
From: Raymond Yau @ 2014-04-10 1:44 UTC (permalink / raw)
To: Kailang; +Cc: Takashi Iwai, ALSA Development Mailing List
>>> >
>>> Sorry!
>>> I just aligned the channel count.
>>> So, move the alc892 to patch_alc882.
>>
>>
>> As I already asked, could you resubmit the patch with the proper
>> changelog? You have to clarify why the patch is needed and how it's
>> solved in the patch changelog.
>>
>
> Yes, but it maybe doesn't solve any thing.
> But I remember I solve 8ch issue which run for patch_alc882.
> I will check alc892 for run with patch_alc882.
> Thanks.
>
AFAIK, 8ch is not yet supported by generic driver for those desktop
motherboard
1) with 5 jacks at rear panel (retask line in as side)
2) 10 channel codec with 3 jacks at rear panel(retask front HP as side)
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2014-04-10 1:44 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-27 9:47 move alc892 to patch_alc882 Kailang
2014-03-27 10:06 ` Takashi Iwai
2014-04-05 6:52 ` Raymond Yau
2014-04-06 7:58 ` Takashi Iwai
2014-04-07 6:04 ` Kailang
2014-04-07 8:37 ` Takashi Iwai
2014-04-07 8:59 ` Improve hp pop noise Kailang
2014-04-07 10:33 ` Takashi Iwai
2014-04-08 7:34 ` Change module name for Chrome Kailang
2014-04-08 7:58 ` Takashi Iwai
2014-04-08 8:06 ` Kailang
2014-04-08 8:39 ` Takashi Iwai
2014-04-08 8:56 ` Kailang
2014-04-08 9:22 ` Add eapd shutup to alc283 Kailang
2014-04-07 9:19 ` move alc892 to patch_alc882 Kailang
2014-04-07 11:11 ` Raymond Yau
2014-04-08 9:08 ` Kailang
2014-04-09 4:53 ` Raymond Yau
2014-04-09 6:30 ` Kailang
2014-04-09 7:24 ` Raymond Yau
2014-04-10 1:30 ` Raymond Yau
2014-04-10 1:44 ` Raymond Yau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).