From: Gregor Pintar <grpintar@gmail.com>
To: Alexander Tsoy <alexander@tsoy.me>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Roope Salmi <rpsalmi@gmail.com>
Subject: Re: [PATCH 1/2] ALSA: usb-audio: Improve frames size computation
Date: Fri, 24 Apr 2020 17:02:54 +0200 [thread overview]
Message-ID: <CAOPXC2kF-k9xH8KhP_s+RmebgTdZW7avn9uedMRAooOB5WhzCA@mail.gmail.com> (raw)
In-Reply-To: <20200424022449.14972-1-alexander@tsoy.me>
On Fri, Apr 24, 2020 at 4:24 AM Alexander Tsoy <alexander@tsoy.me> wrote:
>
> This patch fixes this issue by implementing a different algorithm for
> frame size computation. It is based on accumulating of the remainders
> from division fs/fps and it doesn't accumulate errors over time. This
> new method is enabled for synchronous and adaptive playback endpoints.
>
Hm, I still sometimes get click usually in about first 2 seconds,
but it is hard to reproduce.
This will provide better out-of-box experience. Thanks.
next prev parent reply other threads:[~2020-04-24 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 2:24 [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Alexander Tsoy
2020-04-24 2:24 ` [PATCH 2/2] ALSA: usb-audio: Remove async workaround for Scarlett 2nd gen Alexander Tsoy
2020-04-24 6:28 ` Takashi Iwai
2020-04-24 15:21 ` Gregor Pintar
2020-04-24 6:28 ` [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Takashi Iwai
2020-04-24 9:19 ` Pavel Hofman
2020-04-24 9:29 ` Alexander Tsoy
2020-04-24 9:39 ` Pavel Hofman
2020-04-24 15:02 ` Gregor Pintar [this message]
2020-04-24 16:43 ` Alexander Tsoy
2020-04-25 16:50 ` Gregor Pintar
2020-04-25 18:09 ` Gregor Pintar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOPXC2kF-k9xH8KhP_s+RmebgTdZW7avn9uedMRAooOB5WhzCA@mail.gmail.com \
--to=grpintar@gmail.com \
--cc=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=rpsalmi@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).