* [PATCH] ASoC: amd: ps: Make acp63_fill_platform_dev_info static
@ 2023-01-06 2:31 Jiapeng Chong
2023-01-23 13:30 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-01-06 2:31 UTC (permalink / raw)
To: lgirdwood
Cc: Jiapeng Chong, alsa-devel, Abaci Robot, linux-kernel, tiwai, broonie
This symbol is not used outside of pci-ps.c, so marks it static.
sound/soc/amd/ps/pci-ps.c:170:6: warning: no previous prototype for ‘acp63_fill_platform_dev_info’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3640
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
sound/soc/amd/ps/pci-ps.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 401cfd0036be..570736e1b5e8 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -167,10 +167,10 @@ static void get_acp63_device_config(u32 config, struct pci_dev *pci,
}
}
-void acp63_fill_platform_dev_info(struct platform_device_info *pdevinfo, struct device *parent,
- struct fwnode_handle *fw_node, char *name, unsigned int id,
- const struct resource *res, unsigned int num_res,
- const void *data, size_t size_data)
+static void acp63_fill_platform_dev_info(struct platform_device_info *pdevinfo,
+ struct device *parent, struct fwnode_handle *fw_node,
+ char *name, unsigned int id, const struct resource *res,
+ unsigned int num_res, const void *data, size_t size_data)
{
pdevinfo->name = name;
pdevinfo->id = id;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: amd: ps: Make acp63_fill_platform_dev_info static
2023-01-06 2:31 [PATCH] ASoC: amd: ps: Make acp63_fill_platform_dev_info static Jiapeng Chong
@ 2023-01-23 13:30 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-01-23 13:30 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: alsa-devel, lgirdwood, Abaci Robot, linux-kernel, tiwai
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Fri, Jan 06, 2023 at 10:31:16AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of pci-ps.c, so marks it static.
>
> sound/soc/amd/ps/pci-ps.c:170:6: warning: no previous prototype for ‘acp63_fill_platform_dev_info’.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-23 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 2:31 [PATCH] ASoC: amd: ps: Make acp63_fill_platform_dev_info static Jiapeng Chong
2023-01-23 13:30 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).