* [PATCH 1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530
@ 2022-10-05 7:14 Callum Osmotherly
2022-10-05 12:54 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Callum Osmotherly @ 2022-10-05 7:14 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai
From: Callum Osmotherly <callum.osmotherly@gmail.com>
After some feedback from users with Dell Precision 5530 machines, this
patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK.
While it improved the speaker output quality, it caused the headphone
jack to have an audible "pop" sound when power saving was toggled.
Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d35934f..ab6d736 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8836,7 +8836,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC),
SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC),
SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB),
- SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK),
SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530
2022-10-05 7:14 [PATCH 1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Callum Osmotherly
@ 2022-10-05 12:54 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-10-05 12:54 UTC (permalink / raw)
To: Callum Osmotherly; +Cc: alsa-devel
On Wed, 05 Oct 2022 09:14:16 +0200,
Callum Osmotherly wrote:
>
> From: Callum Osmotherly <callum.osmotherly@gmail.com>
>
> After some feedback from users with Dell Precision 5530 machines, this
> patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK.
> While it improved the speaker output quality, it caused the headphone
> jack to have an audible "pop" sound when power saving was toggled.
>
> Signed-off-by: Callum Osmotherly <callum.osmotherly@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-05 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-05 7:14 [PATCH 1/1] ALSA: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Callum Osmotherly
2022-10-05 12:54 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).