alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card
@ 2020-02-24 16:29 František Kučera
  2020-03-04 16:03 ` František Kučera
  0 siblings, 1 reply; 7+ messages in thread
From: František Kučera @ 2020-02-24 16:29 UTC (permalink / raw)
  To: alsa-devel

Hello,

I have created a quirk that adds support for the Pioneer DJ DJM-250MK2 mixer (acts like a USB sound card, but Vendor Specific Class).

Output (from computer to card) is working: 8 channels, 48 000 Hz, S24_3LE.

Input is not working. I tried, but I was unable to make it working even under an officially supported OS with Pioneer drivers - Audacity or Mixxx see the channels, but there is no signal. It probably works only with Pioneer proprietary application. But I hope that even mere output support will be useful for someone. (it is usable for playback, just not for DVS)

Franta

Signed-off-by: František Kučera <franta-linux@frantovo.cz>
---
 sound/usb/quirks-table.h | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index d187aa6d50db..dcaf9eed9a41 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -3592,5 +3592,47 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
                }
        }
 },
+{
+       /*
+        * Pioneer DJ DJM-250MK2
+        * PCM is 8 channels out @ 48 fixed (endpoints 0x01).
+        * The output from computer to the mixer is usable.
+        *
+        * The input (phono or line to computer) is not working.
+        * It should be at endpoint 0x82 and probably also 8 channels,
+        * but it seems that it works only with Pioneer proprietary software.
+        * Even on officially supported OS, the Audacity was unable to record
+        * and Mixxx to recognize the control vinyls.
+        */
+       USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017),
+       .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+               .ifnum = QUIRK_ANY_INTERFACE,
+               .type = QUIRK_COMPOSITE,
+               .data = (const struct snd_usb_audio_quirk[]) {
+                       {
+                               .ifnum = 0,
+                               .type = QUIRK_AUDIO_FIXED_ENDPOINT,
+                               .data = &(const struct audioformat) {
+                                       .formats = SNDRV_PCM_FMTBIT_S24_3LE,
+                                       .channels = 8, // outputs
+                                       .iface = 0,
+                                       .altsetting = 1,
+                                       .altset_idx = 1,
+                                       .endpoint = 0x01,
+                                       .ep_attr = USB_ENDPOINT_XFER_ISOC|
+                                               USB_ENDPOINT_SYNC_ASYNC,
+                                       .rates = SNDRV_PCM_RATE_48000,
+                                       .rate_min = 48000,
+                                       .rate_max = 48000,
+                                       .nr_rates = 1,
+                                       .rate_table = (unsigned int[]) { 48000 }
+                               }
+                       },
+                       {
+                               .ifnum = -1
+                       }
+               }
+       }
+},
 
 #undef USB_DEVICE_VENDOR_SPEC


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card
  2020-02-24 16:29 [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card František Kučera
@ 2020-03-04 16:03 ` František Kučera
  2020-03-26  9:20   ` Jaroslav Kysela
  0 siblings, 1 reply; 7+ messages in thread
From: František Kučera @ 2020-03-04 16:03 UTC (permalink / raw)
  To: alsa-devel

Dne 24. 02. 20 v 17:29 František Kučera napsal(a):
> Hello,
>
> I have created a quirk that adds support for the Pioneer DJ DJM-250MK2 mixer (acts like a USB sound card, but Vendor Specific Class).
>
> Output (from computer to card) is working: 8 channels, 48 000 Hz, S24_3LE.
>
> Input is not working. I tried, but I was unable to make it working even under an officially supported OS with Pioneer drivers - Audacity or Mixxx see the channels, but there is no signal. It probably works only with Pioneer proprietary application. But I hope that even mere output support will be useful for someone. (it is usable for playback, just not for DVS)
>
> Franta
>
> Signed-off-by: František Kučera <franta-linux@frantovo.cz>
> ---
>  sound/usb/quirks-table.h | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index d187aa6d50db..dcaf9eed9a41 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -3592,5 +3592,47 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
>                 }
>         }
>  },
> +{
> +       /*
> +        * Pioneer DJ DJM-250MK2
> +        * PCM is 8 channels out @ 48 fixed (endpoints 0x01).
> +        * The output from computer to the mixer is usable.
> +        *
> +        * The input (phono or line to computer) is not working.
> +        * It should be at endpoint 0x82 and probably also 8 channels,
> +        * but it seems that it works only with Pioneer proprietary software.
> +        * Even on officially supported OS, the Audacity was unable to record
> +        * and Mixxx to recognize the control vinyls.
> +        */
> +       USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017),
> +       .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> +               .ifnum = QUIRK_ANY_INTERFACE,
> +               .type = QUIRK_COMPOSITE,
> +               .data = (const struct snd_usb_audio_quirk[]) {
> +                       {
> +                               .ifnum = 0,
> +                               .type = QUIRK_AUDIO_FIXED_ENDPOINT,
> +                               .data = &(const struct audioformat) {
> +                                       .formats = SNDRV_PCM_FMTBIT_S24_3LE,
> +                                       .channels = 8, // outputs
> +                                       .iface = 0,
> +                                       .altsetting = 1,
> +                                       .altset_idx = 1,
> +                                       .endpoint = 0x01,
> +                                       .ep_attr = USB_ENDPOINT_XFER_ISOC|
> +                                               USB_ENDPOINT_SYNC_ASYNC,
> +                                       .rates = SNDRV_PCM_RATE_48000,
> +                                       .rate_min = 48000,
> +                                       .rate_max = 48000,
> +                                       .nr_rates = 1,
> +                                       .rate_table = (unsigned int[]) { 48000 }
> +                               }
> +                       },
> +                       {
> +                               .ifnum = -1
> +                       }
> +               }
> +       }
> +},
>  
>  #undef USB_DEVICE_VENDOR_SPEC
>
Can anyone review this patch please?

Franta


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card
  2020-03-04 16:03 ` František Kučera
@ 2020-03-26  9:20   ` Jaroslav Kysela
  2020-03-26  9:29     ` Takashi Iwai
  2020-03-26 10:03     ` [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card Fabian Lesniak
  0 siblings, 2 replies; 7+ messages in thread
From: Jaroslav Kysela @ 2020-03-26  9:20 UTC (permalink / raw)
  To: František Kučera, alsa-devel; +Cc: Takashi Iwai

Dne 04. 03. 20 v 17:03 František Kučera napsal(a):
> Dne 24. 02. 20 v 17:29 František Kučera napsal(a):
>> Hello,
>>
>> I have created a quirk that adds support for the Pioneer DJ DJM-250MK2 mixer (acts like a USB sound card, but Vendor Specific Class).
>>
>> Output (from computer to card) is working: 8 channels, 48 000 Hz, S24_3LE.
>>
>> Input is not working. I tried, but I was unable to make it working even under an officially supported OS with Pioneer drivers - Audacity or Mixxx see the channels, but there is no signal. It probably works only with Pioneer proprietary application. But I hope that even mere output support will be useful for someone. (it is usable for playback, just not for DVS)
>>
>> Franta
>>
>> Signed-off-by: František Kučera <franta-linux@frantovo.cz>
>> ---
>>   sound/usb/quirks-table.h | 42 ++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 42 insertions(+)
>>
>> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
>> index d187aa6d50db..dcaf9eed9a41 100644
>> --- a/sound/usb/quirks-table.h
>> +++ b/sound/usb/quirks-table.h
>> @@ -3592,5 +3592,47 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
>>                  }
>>          }
>>   },
>> +{
>> +       /*
>> +        * Pioneer DJ DJM-250MK2
>> +        * PCM is 8 channels out @ 48 fixed (endpoints 0x01).
>> +        * The output from computer to the mixer is usable.
>> +        *
>> +        * The input (phono or line to computer) is not working.
>> +        * It should be at endpoint 0x82 and probably also 8 channels,
>> +        * but it seems that it works only with Pioneer proprietary software.
>> +        * Even on officially supported OS, the Audacity was unable to record
>> +        * and Mixxx to recognize the control vinyls.
>> +        */
>> +       USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017),
>> +       .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
>> +               .ifnum = QUIRK_ANY_INTERFACE,
>> +               .type = QUIRK_COMPOSITE,
>> +               .data = (const struct snd_usb_audio_quirk[]) {
>> +                       {
>> +                               .ifnum = 0,
>> +                               .type = QUIRK_AUDIO_FIXED_ENDPOINT,
>> +                               .data = &(const struct audioformat) {
>> +                                       .formats = SNDRV_PCM_FMTBIT_S24_3LE,
>> +                                       .channels = 8, // outputs
>> +                                       .iface = 0,
>> +                                       .altsetting = 1,
>> +                                       .altset_idx = 1,
>> +                                       .endpoint = 0x01,
>> +                                       .ep_attr = USB_ENDPOINT_XFER_ISOC|
>> +                                               USB_ENDPOINT_SYNC_ASYNC,
>> +                                       .rates = SNDRV_PCM_RATE_48000,
>> +                                       .rate_min = 48000,
>> +                                       .rate_max = 48000,
>> +                                       .nr_rates = 1,
>> +                                       .rate_table = (unsigned int[]) { 48000 }
>> +                               }
>> +                       },
>> +                       {
>> +                               .ifnum = -1
>> +                       }
>> +               }
>> +       }
>> +},
>>   
>>   #undef USB_DEVICE_VENDOR_SPEC
>>
> Can anyone review this patch please?

Takashi, could you put this patch to sound-next ? A partial support is better 
than no support.

						Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card
  2020-03-26  9:20   ` Jaroslav Kysela
@ 2020-03-26  9:29     ` Takashi Iwai
  2020-04-01  9:59       ` [PATCH] ALSA: usb-audio: Add Pioneer DJ DJM-250MK2 quirk František Kučera
  2020-03-26 10:03     ` [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card Fabian Lesniak
  1 sibling, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2020-03-26  9:29 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: František Kučera, alsa-devel

On Thu, 26 Mar 2020 10:20:39 +0100,
Jaroslav Kysela wrote:
> 
> Dne 04. 03. 20 v 17:03 František Kučera napsal(a):
> > Dne 24. 02. 20 v 17:29 František Kučera napsal(a):
> >> Hello,
> >>
> >> I have created a quirk that adds support for the Pioneer DJ DJM-250MK2 mixer (acts like a USB sound card, but Vendor Specific Class).
> >>
> >> Output (from computer to card) is working: 8 channels, 48 000 Hz, S24_3LE.
> >>
> >> Input is not working. I tried, but I was unable to make it working even under an officially supported OS with Pioneer drivers - Audacity or Mixxx see the channels, but there is no signal. It probably works only with Pioneer proprietary application. But I hope that even mere output support will be useful for someone. (it is usable for playback, just not for DVS)
> >>
> >> Franta
> >>
> >> Signed-off-by: František Kučera <franta-linux@frantovo.cz>
> >> ---
> >>   sound/usb/quirks-table.h | 42 ++++++++++++++++++++++++++++++++++++++++++
> >>   1 file changed, 42 insertions(+)
> >>
> >> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> >> index d187aa6d50db..dcaf9eed9a41 100644
> >> --- a/sound/usb/quirks-table.h
> >> +++ b/sound/usb/quirks-table.h
> >> @@ -3592,5 +3592,47 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
> >>                  }
> >>          }
> >>   },
> >> +{
> >> +       /*
> >> +        * Pioneer DJ DJM-250MK2
> >> +        * PCM is 8 channels out @ 48 fixed (endpoints 0x01).
> >> +        * The output from computer to the mixer is usable.
> >> +        *
> >> +        * The input (phono or line to computer) is not working.
> >> +        * It should be at endpoint 0x82 and probably also 8 channels,
> >> +        * but it seems that it works only with Pioneer proprietary software.
> >> +        * Even on officially supported OS, the Audacity was unable to record
> >> +        * and Mixxx to recognize the control vinyls.
> >> +        */
> >> +       USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017),
> >> +       .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> >> +               .ifnum = QUIRK_ANY_INTERFACE,
> >> +               .type = QUIRK_COMPOSITE,
> >> +               .data = (const struct snd_usb_audio_quirk[]) {
> >> +                       {
> >> +                               .ifnum = 0,
> >> +                               .type = QUIRK_AUDIO_FIXED_ENDPOINT,
> >> +                               .data = &(const struct audioformat) {
> >> +                                       .formats = SNDRV_PCM_FMTBIT_S24_3LE,
> >> +                                       .channels = 8, // outputs
> >> +                                       .iface = 0,
> >> +                                       .altsetting = 1,
> >> +                                       .altset_idx = 1,
> >> +                                       .endpoint = 0x01,
> >> +                                       .ep_attr = USB_ENDPOINT_XFER_ISOC|
> >> +                                               USB_ENDPOINT_SYNC_ASYNC,
> >> +                                       .rates = SNDRV_PCM_RATE_48000,
> >> +                                       .rate_min = 48000,
> >> +                                       .rate_max = 48000,
> >> +                                       .nr_rates = 1,
> >> +                                       .rate_table = (unsigned int[]) { 48000 }
> >> +                               }
> >> +                       },
> >> +                       {
> >> +                               .ifnum = -1
> >> +                       }
> >> +               }
> >> +       }
> >> +},
> >>     #undef USB_DEVICE_VENDOR_SPEC
> >>
> > Can anyone review this patch please?
> 
> Takashi, could you put this patch to sound-next ? A partial support is
> better than no support.

František, could you resend the patch in a proper format?
The original post couldn't be applied via git-am, as it was
malformed.

Also, please try to adjust the subject line and the changelog text to
be suitable for merging to the tree.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card
  2020-03-26  9:20   ` Jaroslav Kysela
  2020-03-26  9:29     ` Takashi Iwai
@ 2020-03-26 10:03     ` Fabian Lesniak
  1 sibling, 0 replies; 7+ messages in thread
From: Fabian Lesniak @ 2020-03-26 10:03 UTC (permalink / raw)
  To: František Kučera; +Cc: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 6238 bytes --]

Hi František,

a few months ago, I was working on patches to support the DJM-900MK2
mixer. I guess they are using a similar format on this mixer, at least
your quirk is similar to mine. I did not submit these patches yet
because I could not figure out a proper way to support both input and
output. I'm not an expert on usb audio, but I'll share my thoughts. At
least on the 900MK2, both playback and recording use the same interface:

I:  If#= 0 Alt= 1 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=snd-usb-audio
E:  Ad=01(O) Atr=05(Isoc) MxPS=1024 Ivl=125us
E:  Ad=82(I) Atr=05(Isoc) MxPS=1024 Ivl=125us

Thus, I introduced a quirk with .ifnum=0 for both capture and playback.
The problem is that the device accepts sample rate change commands for
the capture endpoint 0x82 only. Both endpoints are then configured to
that sample rate. Contrary to that, snd-usb-audio expects that playback
and recording is on two independent interface that both accept sample
rate changes and can operate on different sample rates.

My first approach was introducing a quirk in sound/usb/clock.c,
set_sample_rate_v1(). The quirk rejected changes to the sample rate of
one interface when the other was already in use by returning EBUSY. This
did work only if the capture endpoint was started before playback, which
was not predictable when using pulseaudio. Can anyone help on that? Is
there a supported device which I can look at that only allows the same
sample rate on both endpoints?

Cheers

Fabian

Am 26.03.20 um 10:20 schrieb Jaroslav Kysela:
> Dne 04. 03. 20 v 17:03 František Kučera napsal(a):
>> Dne 24. 02. 20 v 17:29 František Kučera napsal(a):
>>> Hello,
>>>
>>> I have created a quirk that adds support for the Pioneer DJ
>>> DJM-250MK2 mixer (acts like a USB sound card, but Vendor Specific
>>> Class).
>>>
>>> Output (from computer to card) is working: 8 channels, 48 000 Hz,
>>> S24_3LE.
>>>
>>> Input is not working. I tried, but I was unable to make it working
>>> even under an officially supported OS with Pioneer drivers -
>>> Audacity or Mixxx see the channels, but there is no signal. It
>>> probably works only with Pioneer proprietary application. But I hope
>>> that even mere output support will be useful for someone. (it is
>>> usable for playback, just not for DVS)
>>>
>>> Franta
>>>
>>> Signed-off-by: František Kučera <franta-linux@frantovo.cz>
>>> ---
>>>   sound/usb/quirks-table.h | 42
>>> ++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 42 insertions(+)
>>>
>>> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
>>> index d187aa6d50db..dcaf9eed9a41 100644
>>> --- a/sound/usb/quirks-table.h
>>> +++ b/sound/usb/quirks-table.h
>>> @@ -3592,5 +3592,47 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge",
>>> "HVR-950Q"),
>>>                  }
>>>          }
>>>   },
>>> +{
>>> +       /*
>>> +        * Pioneer DJ DJM-250MK2
>>> +        * PCM is 8 channels out @ 48 fixed (endpoints 0x01).
>>> +        * The output from computer to the mixer is usable.
>>> +        *
>>> +        * The input (phono or line to computer) is not working.
>>> +        * It should be at endpoint 0x82 and probably also 8 channels,
>>> +        * but it seems that it works only with Pioneer proprietary
>>> software.
>>> +        * Even on officially supported OS, the Audacity was unable
>>> to record
>>> +        * and Mixxx to recognize the control vinyls.
>>> +        */
>>> +       USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017),
>>> +       .driver_info = (unsigned long) &(const struct
>>> snd_usb_audio_quirk) {
>>> +               .ifnum = QUIRK_ANY_INTERFACE,
>>> +               .type = QUIRK_COMPOSITE,
>>> +               .data = (const struct snd_usb_audio_quirk[]) {
>>> +                       {
>>> +                               .ifnum = 0,
>>> +                               .type = QUIRK_AUDIO_FIXED_ENDPOINT,
>>> +                               .data = &(const struct audioformat) {
>>> +                                       .formats =
>>> SNDRV_PCM_FMTBIT_S24_3LE,
>>> +                                       .channels = 8, // outputs
>>> +                                       .iface = 0,
>>> +                                       .altsetting = 1,
>>> +                                       .altset_idx = 1,
>>> +                                       .endpoint = 0x01,
>>> +                                       .ep_attr =
>>> USB_ENDPOINT_XFER_ISOC|
>>> +                                              
>>> USB_ENDPOINT_SYNC_ASYNC,
>>> +                                       .rates = SNDRV_PCM_RATE_48000,
>>> +                                       .rate_min = 48000,
>>> +                                       .rate_max = 48000,
>>> +                                       .nr_rates = 1,
>>> +                                       .rate_table = (unsigned
>>> int[]) { 48000 }
>>> +                               }
>>> +                       },
>>> +                       {
>>> +                               .ifnum = -1
>>> +                       }
>>> +               }
>>> +       }
>>> +},
>>>     #undef USB_DEVICE_VENDOR_SPEC
>>>
>> Can anyone review this patch please?
>
> Takashi, could you put this patch to sound-next ? A partial support is
> better than no support.
>
>                         Jaroslav
>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ALSA: usb-audio: Add Pioneer DJ DJM-250MK2 quirk
  2020-03-26  9:29     ` Takashi Iwai
@ 2020-04-01  9:59       ` František Kučera
  2020-04-03  7:41         ` Takashi Iwai
  0 siblings, 1 reply; 7+ messages in thread
From: František Kučera @ 2020-04-01  9:59 UTC (permalink / raw)
  To: alsa-devel, Takashi Iwai, František Kučera

From: František Kučera <franta-linux@frantovo.cz>

Pioneer DJ DJM-250MK2 is a mixer that acts like a USB sound card.
The MIDI controller part is standard but the PCM part is "vendor specific".
Output is enabled by this quirk: 8 channels, 48 000 Hz, S24_3LE.
Input is not working.

Signed-off-by: František Kučera <franta-linux@frantovo.cz>
---
 sound/usb/quirks-table.h | 42 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index d187aa6d50db..dcaf9eed9a41 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -3592,5 +3592,47 @@ AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
 		}
 	}
 },
+{
+	/*
+	 * Pioneer DJ DJM-250MK2
+	 * PCM is 8 channels out @ 48 fixed (endpoints 0x01).
+	 * The output from computer to the mixer is usable.
+	 *
+	 * The input (phono or line to computer) is not working.
+	 * It should be at endpoint 0x82 and probably also 8 channels,
+	 * but it seems that it works only with Pioneer proprietary software.
+	 * Even on officially supported OS, the Audacity was unable to record
+	 * and Mixxx to recognize the control vinyls.
+	 */
+	USB_DEVICE_VENDOR_SPEC(0x2b73, 0x0017),
+	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+		.ifnum = QUIRK_ANY_INTERFACE,
+		.type = QUIRK_COMPOSITE,
+		.data = (const struct snd_usb_audio_quirk[]) {
+			{
+				.ifnum = 0,
+				.type = QUIRK_AUDIO_FIXED_ENDPOINT,
+				.data = &(const struct audioformat) {
+					.formats = SNDRV_PCM_FMTBIT_S24_3LE,
+					.channels = 8, // outputs
+					.iface = 0,
+					.altsetting = 1,
+					.altset_idx = 1,
+					.endpoint = 0x01,
+					.ep_attr = USB_ENDPOINT_XFER_ISOC|
+						USB_ENDPOINT_SYNC_ASYNC,
+					.rates = SNDRV_PCM_RATE_48000,
+					.rate_min = 48000,
+					.rate_max = 48000,
+					.nr_rates = 1,
+					.rate_table = (unsigned int[]) { 48000 }
+				}
+			},
+			{
+				.ifnum = -1
+			}
+		}
+	}
+},
 
 #undef USB_DEVICE_VENDOR_SPEC
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] ALSA: usb-audio: Add Pioneer DJ DJM-250MK2 quirk
  2020-04-01  9:59       ` [PATCH] ALSA: usb-audio: Add Pioneer DJ DJM-250MK2 quirk František Kučera
@ 2020-04-03  7:41         ` Takashi Iwai
  0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2020-04-03  7:41 UTC (permalink / raw)
  To: František Kučera; +Cc: alsa-devel, František Kučera

On Wed, 01 Apr 2020 11:59:07 +0200,
František Kučera wrote:
> 
> From: František Kučera <franta-linux@frantovo.cz>
> 
> Pioneer DJ DJM-250MK2 is a mixer that acts like a USB sound card.
> The MIDI controller part is standard but the PCM part is "vendor specific".
> Output is enabled by this quirk: 8 channels, 48 000 Hz, S24_3LE.
> Input is not working.
> 
> Signed-off-by: František Kučera <franta-linux@frantovo.cz>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-04-03  7:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 16:29 [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card František Kučera
2020-03-04 16:03 ` František Kučera
2020-03-26  9:20   ` Jaroslav Kysela
2020-03-26  9:29     ` Takashi Iwai
2020-04-01  9:59       ` [PATCH] ALSA: usb-audio: Add Pioneer DJ DJM-250MK2 quirk František Kučera
2020-04-03  7:41         ` Takashi Iwai
2020-03-26 10:03     ` [PATCH] quirk for Pioneer DJ DJM-250MK2 usb sound card Fabian Lesniak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).