alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'
@ 2020-04-10  8:11 Jason Yan
  2020-04-10  8:11 ` [PATCH 2/2] ASoC: Intel: soc-acpi-intel-cml-match: " Jason Yan
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Jason Yan @ 2020-04-10  8:11 UTC (permalink / raw)
  To: cezary.rojewski, pierre-louis.bossart, liam.r.girdwood, yang.jie,
	broonie, perex, tiwai, yung-chuan.liao, ranjani.sridharan,
	rander.wang, christophe.jaillet, yanaijie, alsa-devel

Fix the following gcc warning:

sound/soc/intel/common/soc-acpi-intel-icl-match.c:90:45: warning:
‘rt1308_2_adr’ defined but not used [-Wunused-const-variable=]
 static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
                                             ^~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 sound/soc/intel/common/soc-acpi-intel-icl-match.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/sound/soc/intel/common/soc-acpi-intel-icl-match.c b/sound/soc/intel/common/soc-acpi-intel-icl-match.c
index ef8500349f2f..16ec9f382b0f 100644
--- a/sound/soc/intel/common/soc-acpi-intel-icl-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-icl-match.c
@@ -87,14 +87,6 @@ static const struct snd_soc_acpi_adr_device rt1308_1_adr[] = {
 	}
 };
 
-static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
-	{
-		.adr = 0x000210025D130800,
-		.num_endpoints = 1,
-		.endpoints = &single_endpoint,
-	}
-};
-
 static const struct snd_soc_acpi_adr_device rt1308_1_group1_adr[] = {
 	{
 		.adr = 0x000110025D130800,
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ASoC: Intel: soc-acpi-intel-cml-match: remove useless 'rt1308_2_adr'
  2020-04-10  8:11 [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Jason Yan
@ 2020-04-10  8:11 ` Jason Yan
  2020-04-14 14:46   ` Applied "ASoC: Intel: soc-acpi-intel-cml-match: remove useless 'rt1308_2_adr'" to the asoc tree Mark Brown
  2020-04-10 15:17 ` [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Pierre-Louis Bossart
  2020-04-14 14:46 ` Applied "ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'" to the asoc tree Mark Brown
  2 siblings, 1 reply; 5+ messages in thread
From: Jason Yan @ 2020-04-10  8:11 UTC (permalink / raw)
  To: cezary.rojewski, pierre-louis.bossart, liam.r.girdwood, yang.jie,
	broonie, perex, tiwai, yung-chuan.liao, ranjani.sridharan,
	rander.wang, christophe.jaillet, yanaijie, alsa-devel

Fix the following gcc warning:

sound/soc/intel/common/soc-acpi-intel-cml-match.c:116:45: warning:
‘rt1308_2_adr’ defined but not used [-Wunused-const-variable=]
 static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
                                             ^~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 sound/soc/intel/common/soc-acpi-intel-cml-match.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/sound/soc/intel/common/soc-acpi-intel-cml-match.c b/sound/soc/intel/common/soc-acpi-intel-cml-match.c
index bcedec6c6117..7d85bd5aff9f 100644
--- a/sound/soc/intel/common/soc-acpi-intel-cml-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-cml-match.c
@@ -113,14 +113,6 @@ static const struct snd_soc_acpi_adr_device rt1308_1_adr[] = {
 	}
 };
 
-static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
-	{
-		.adr = 0x000210025D130800,
-		.num_endpoints = 1,
-		.endpoints = &single_endpoint,
-	}
-};
-
 static const struct snd_soc_acpi_adr_device rt1308_1_group1_adr[] = {
 	{
 		.adr = 0x000110025D130800,
-- 
2.17.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'
  2020-04-10  8:11 [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Jason Yan
  2020-04-10  8:11 ` [PATCH 2/2] ASoC: Intel: soc-acpi-intel-cml-match: " Jason Yan
@ 2020-04-10 15:17 ` Pierre-Louis Bossart
  2020-04-14 14:46 ` Applied "ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'" to the asoc tree Mark Brown
  2 siblings, 0 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2020-04-10 15:17 UTC (permalink / raw)
  To: Jason Yan, cezary.rojewski, liam.r.girdwood, yang.jie, broonie,
	perex, tiwai, yung-chuan.liao, ranjani.sridharan, rander.wang,
	christophe.jaillet, alsa-devel



On 4/10/20 3:11 AM, Jason Yan wrote:
> Fix the following gcc warning:
> 
> sound/soc/intel/common/soc-acpi-intel-icl-match.c:90:45: warning:
> ‘rt1308_2_adr’ defined but not used [-Wunused-const-variable=]
>   static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
>                                               ^~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Patch 1 and 2:

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>   sound/soc/intel/common/soc-acpi-intel-icl-match.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/sound/soc/intel/common/soc-acpi-intel-icl-match.c b/sound/soc/intel/common/soc-acpi-intel-icl-match.c
> index ef8500349f2f..16ec9f382b0f 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-icl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-icl-match.c
> @@ -87,14 +87,6 @@ static const struct snd_soc_acpi_adr_device rt1308_1_adr[] = {
>   	}
>   };
>   
> -static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
> -	{
> -		.adr = 0x000210025D130800,
> -		.num_endpoints = 1,
> -		.endpoints = &single_endpoint,
> -	}
> -};
> -
>   static const struct snd_soc_acpi_adr_device rt1308_1_group1_adr[] = {
>   	{
>   		.adr = 0x000110025D130800,
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Applied "ASoC: Intel: soc-acpi-intel-cml-match: remove useless 'rt1308_2_adr'" to the asoc tree
  2020-04-10  8:11 ` [PATCH 2/2] ASoC: Intel: soc-acpi-intel-cml-match: " Jason Yan
@ 2020-04-14 14:46   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-04-14 14:46 UTC (permalink / raw)
  To: Jason Yan
  Cc: pierre-louis.bossart, alsa-devel, yanaijie, tiwai, yang.jie,
	cezary.rojewski, liam.r.girdwood, Hulk Robot, Mark Brown,
	christophe.jaillet, ranjani.sridharan, rander.wang,
	yung-chuan.liao

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2530 bytes --]

The patch

   ASoC: Intel: soc-acpi-intel-cml-match: remove useless 'rt1308_2_adr'

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From a306f04511148fade6bead59920dde864a54f017 Mon Sep 17 00:00:00 2001
From: Jason Yan <yanaijie@huawei.com>
Date: Fri, 10 Apr 2020 16:11:17 +0800
Subject: [PATCH] ASoC: Intel: soc-acpi-intel-cml-match: remove useless
 'rt1308_2_adr'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix the following gcc warning:

sound/soc/intel/common/soc-acpi-intel-cml-match.c:116:45: warning:
‘rt1308_2_adr’ defined but not used [-Wunused-const-variable=]
 static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
                                             ^~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Link: https://lore.kernel.org/r/20200410081117.21319-2-yanaijie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/common/soc-acpi-intel-cml-match.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/sound/soc/intel/common/soc-acpi-intel-cml-match.c b/sound/soc/intel/common/soc-acpi-intel-cml-match.c
index bcedec6c6117..7d85bd5aff9f 100644
--- a/sound/soc/intel/common/soc-acpi-intel-cml-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-cml-match.c
@@ -113,14 +113,6 @@ static const struct snd_soc_acpi_adr_device rt1308_1_adr[] = {
 	}
 };
 
-static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
-	{
-		.adr = 0x000210025D130800,
-		.num_endpoints = 1,
-		.endpoints = &single_endpoint,
-	}
-};
-
 static const struct snd_soc_acpi_adr_device rt1308_1_group1_adr[] = {
 	{
 		.adr = 0x000110025D130800,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Applied "ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'" to the asoc tree
  2020-04-10  8:11 [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Jason Yan
  2020-04-10  8:11 ` [PATCH 2/2] ASoC: Intel: soc-acpi-intel-cml-match: " Jason Yan
  2020-04-10 15:17 ` [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Pierre-Louis Bossart
@ 2020-04-14 14:46 ` Mark Brown
  2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-04-14 14:46 UTC (permalink / raw)
  To: Jason Yan
  Cc: Pierre-Louis Bossart, alsa-devel, yanaijie, tiwai, yang.jie,
	cezary.rojewski, liam.r.girdwood, Hulk Robot, Mark Brown,
	christophe.jaillet, ranjani.sridharan, rander.wang,
	yung-chuan.liao

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2597 bytes --]

The patch

   ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From acda42b30fa6b67f07b4560577418df5ada77b52 Mon Sep 17 00:00:00 2001
From: Jason Yan <yanaijie@huawei.com>
Date: Fri, 10 Apr 2020 16:11:16 +0800
Subject: [PATCH] ASoC: intel: soc-acpi-intel-icl-match: remove useless
 'rt1308_2_adr'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix the following gcc warning:

sound/soc/intel/common/soc-acpi-intel-icl-match.c:90:45: warning:
‘rt1308_2_adr’ defined but not used [-Wunused-const-variable=]
 static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
                                             ^~~~~~~~~~~~

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200410081117.21319-1-yanaijie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/common/soc-acpi-intel-icl-match.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/sound/soc/intel/common/soc-acpi-intel-icl-match.c b/sound/soc/intel/common/soc-acpi-intel-icl-match.c
index ef8500349f2f..16ec9f382b0f 100644
--- a/sound/soc/intel/common/soc-acpi-intel-icl-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-icl-match.c
@@ -87,14 +87,6 @@ static const struct snd_soc_acpi_adr_device rt1308_1_adr[] = {
 	}
 };
 
-static const struct snd_soc_acpi_adr_device rt1308_2_adr[] = {
-	{
-		.adr = 0x000210025D130800,
-		.num_endpoints = 1,
-		.endpoints = &single_endpoint,
-	}
-};
-
 static const struct snd_soc_acpi_adr_device rt1308_1_group1_adr[] = {
 	{
 		.adr = 0x000110025D130800,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-04-14 14:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10  8:11 [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Jason Yan
2020-04-10  8:11 ` [PATCH 2/2] ASoC: Intel: soc-acpi-intel-cml-match: " Jason Yan
2020-04-14 14:46   ` Applied "ASoC: Intel: soc-acpi-intel-cml-match: remove useless 'rt1308_2_adr'" to the asoc tree Mark Brown
2020-04-10 15:17 ` [PATCH 1/2] ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr' Pierre-Louis Bossart
2020-04-14 14:46 ` Applied "ASoC: intel: soc-acpi-intel-icl-match: remove useless 'rt1308_2_adr'" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).