alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [bug report] ASoC: qcom: audioreach: fix ADSP ready check
@ 2023-03-23 14:54 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2023-03-23 14:54 UTC (permalink / raw)
  To: srinivas.kandagatla; +Cc: alsa-devel

Hello Srinivas Kandagatla,

The patch dd33c2e7b21d: "ASoC: qcom: audioreach: fix ADSP ready
check" from Feb 9, 2023, leads to the following Smatch static checker
warning:

	sound/soc/qcom/qdsp6/q6apm.c:167 q6apm_is_adsp_ready()
	warn: signedness bug returning '(-12)'

sound/soc/qcom/qdsp6/q6apm.c
    164 bool q6apm_is_adsp_ready(void)
    165 {
    166         if (g_apm)
--> 167                 return q6apm_get_apm_state(g_apm);
                               ^^^^^^^^^^^^^^^^^^^
This can return negative error codes on allocation failure.

    168 
    169         return false;
    170 }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-23 14:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 14:54 [bug report] ASoC: qcom: audioreach: fix ADSP ready check Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).