* Re: [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix COMPILE_TEST error
2019-09-05 6:44 [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix COMPILE_TEST error YueHaibing
@ 2019-09-05 7:52 ` Daniel Baluta
2019-09-05 13:14 ` Pierre-Louis Bossart
2019-09-05 17:38 ` [alsa-devel] Applied "ASoC: SOF: imx8: Fix COMPILE_TEST error" to the asoc tree Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Baluta @ 2019-09-05 7:52 UTC (permalink / raw)
To: dl-linux-imx, yuehaibing, festevam, pierre-louis.bossart,
broonie, tiwai, lgirdwood, shawnguo, perex, kernel, s.hauer
Cc: alsa-devel, linux-kernel, linux-arm-kernel
On Thu, 2019-09-05 at 14:44 +0800, YueHaibing wrote:
> When do compile test, if SND_SOC_SOF_OF is not set, we get:
>
> sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_request':
> imx8.c:(.text+0xb0): undefined reference to `snd_sof_ipc_msgs_rx'
> sound/soc/sof/imx/imx8.o: In function `imx8_ipc_msg_data':
> imx8.c:(.text+0xf4): undefined reference to `sof_mailbox_read'
> sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_reply':
> imx8.c:(.text+0x160): undefined reference to `sof_mailbox_read'
>
> Make SND_SOC_SOF_IMX_TOPLEVEL always depends on SND_SOC_SOF_OF
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> sound/soc/sof/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
> index fd73d84..5acae75 100644
> --- a/sound/soc/sof/imx/Kconfig
> +++ b/sound/soc/sof/imx/Kconfig
> @@ -2,7 +2,8 @@
>
> config SND_SOC_SOF_IMX_TOPLEVEL
> bool "SOF support for NXP i.MX audio DSPs"
> - depends on ARM64 && SND_SOC_SOF_OF || COMPILE_TEST
> + depends on ARM64|| COMPILE_TEST
> + depends on SND_SOC_SOF_OF
> help
> This adds support for Sound Open Firmware for NXP i.MX
> platforms.
> Say Y if you have such a device.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix COMPILE_TEST error
2019-09-05 6:44 [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix COMPILE_TEST error YueHaibing
2019-09-05 7:52 ` Daniel Baluta
@ 2019-09-05 13:14 ` Pierre-Louis Bossart
2019-09-05 17:38 ` [alsa-devel] Applied "ASoC: SOF: imx8: Fix COMPILE_TEST error" to the asoc tree Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2019-09-05 13:14 UTC (permalink / raw)
To: YueHaibing, lgirdwood, broonie, perex, tiwai, shawnguo, s.hauer,
kernel, festevam, linux-imx, daniel.baluta
Cc: alsa-devel, linux-kernel, linux-arm-kernel
On 9/5/19 1:44 AM, YueHaibing wrote:
> When do compile test, if SND_SOC_SOF_OF is not set, we get:
>
> sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_request':
> imx8.c:(.text+0xb0): undefined reference to `snd_sof_ipc_msgs_rx'
> sound/soc/sof/imx/imx8.o: In function `imx8_ipc_msg_data':
> imx8.c:(.text+0xf4): undefined reference to `sof_mailbox_read'
> sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_reply':
> imx8.c:(.text+0x160): undefined reference to `sof_mailbox_read'
>
> Make SND_SOC_SOF_IMX_TOPLEVEL always depends on SND_SOC_SOF_OF
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/sof/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
> index fd73d84..5acae75 100644
> --- a/sound/soc/sof/imx/Kconfig
> +++ b/sound/soc/sof/imx/Kconfig
> @@ -2,7 +2,8 @@
>
> config SND_SOC_SOF_IMX_TOPLEVEL
> bool "SOF support for NXP i.MX audio DSPs"
> - depends on ARM64 && SND_SOC_SOF_OF || COMPILE_TEST
> + depends on ARM64|| COMPILE_TEST
> + depends on SND_SOC_SOF_OF
> help
> This adds support for Sound Open Firmware for NXP i.MX platforms.
> Say Y if you have such a device.
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* [alsa-devel] Applied "ASoC: SOF: imx8: Fix COMPILE_TEST error" to the asoc tree
2019-09-05 6:44 [alsa-devel] [PATCH -next] ASoC: SOF: imx8: Fix COMPILE_TEST error YueHaibing
2019-09-05 7:52 ` Daniel Baluta
2019-09-05 13:14 ` Pierre-Louis Bossart
@ 2019-09-05 17:38 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-09-05 17:38 UTC (permalink / raw)
To: YueHaibing
Cc: pierre-louis.bossart, alsa-devel, daniel.baluta, s.hauer, tiwai,
yuehaibing, lgirdwood, linux-kernel, Hulk Robot, Mark Brown,
linux-imx, kernel, shawnguo, festevam, linux-arm-kernel
The patch
ASoC: SOF: imx8: Fix COMPILE_TEST error
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From f4df4e4042b045c6ddbaff878a17ae169fe68ba6 Mon Sep 17 00:00:00 2001
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 5 Sep 2019 14:44:00 +0800
Subject: [PATCH] ASoC: SOF: imx8: Fix COMPILE_TEST error
When do compile test, if SND_SOC_SOF_OF is not set, we get:
sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_request':
imx8.c:(.text+0xb0): undefined reference to `snd_sof_ipc_msgs_rx'
sound/soc/sof/imx/imx8.o: In function `imx8_ipc_msg_data':
imx8.c:(.text+0xf4): undefined reference to `sof_mailbox_read'
sound/soc/sof/imx/imx8.o: In function `imx8_dsp_handle_reply':
imx8.c:(.text+0x160): undefined reference to `sof_mailbox_read'
Make SND_SOC_SOF_IMX_TOPLEVEL always depends on SND_SOC_SOF_OF
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190905064400.24800-1-yuehaibing@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/sof/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
index fd73d8402dbf..5acae75f5750 100644
--- a/sound/soc/sof/imx/Kconfig
+++ b/sound/soc/sof/imx/Kconfig
@@ -2,7 +2,8 @@
config SND_SOC_SOF_IMX_TOPLEVEL
bool "SOF support for NXP i.MX audio DSPs"
- depends on ARM64 && SND_SOC_SOF_OF || COMPILE_TEST
+ depends on ARM64|| COMPILE_TEST
+ depends on SND_SOC_SOF_OF
help
This adds support for Sound Open Firmware for NXP i.MX platforms.
Say Y if you have such a device.
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread