[PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Alexandrov Stansilav]

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

v2: Splited patch to codec and sst parts

 sound/soc/codecs/rt5640.c           | 1 +
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 2 files changed, 3 insertions(+)

-- 
2.10.2

[PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Alexandrov Stansilav]

Signed-off-by: Alexandrov Stansilav <neko@nya.ai>
---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
index e29a6de..b857a71 100644
--- a/sound/soc/codecs/rt5640.c
+++ b/sound/soc/codecs/rt5640.c
@@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id rt5640_acpi_match[] = {
 	{ "INT33CA", 0 },
+	{ "10EC3276", 0 },
 	{ "10EC5640", 0 },
 	{ "10EC5642", 0 },
 	{ "INTCCFFD", 0 },
-- 
2.10.2

[PATCH v2 2/2] ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Alexandrov Stansilav]

Signed-off-by: Alexandrov Stansilav <neko@nya.ai>
---
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
index f4d92bb..896ced2 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
 	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
 						&chv_platform_data },
+	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+						&chv_platform_data },
 
 	{},
 };
-- 
2.10.2

Re: [PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Pierre-Louis Bossart]

On 1/4/17 6:22 AM, Alexandrov Stansilav wrote:
> Inside DSDT table there is record for this soundcard:
>
>             Device (RTKC)
>             {
>                 Name (_ADR, Zero)  // _ADR: Address
>                 Name (_HID, "10EC3276")  // _HID: Hardware ID
>                 Name (_CID, "10EC3276")  // _CID: Compatible ID
>                 Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
>                 Name (_SUB, "103C827C")  // _SUB: Subsystem ID
>                 Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0
>
> original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621
>
> v2: Splited patch to codec and sst parts
>
>  sound/soc/codecs/rt5640.c           | 1 +
>  sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
>  2 files changed, 3 insertions(+)

The commit message is a tad long but the patch is legit
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Re: [PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Vinod Koul]

On Wed, Jan 04, 2017 at 03:22:12PM +0300, Alexandrov Stansilav wrote:

This looks okay, but title is same for both of the patches. It would be
better to describe the change you are doing and not the outcome.

so a better title could be:

ASoC: rt5640: Add "10EC3276" ACPI ID

and in log say:

HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add
that.

> Signed-off-by: Alexandrov Stansilav <neko@nya.ai>
> ---
>  sound/soc/codecs/rt5640.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
> index e29a6de..b857a71 100644
> --- a/sound/soc/codecs/rt5640.c
> +++ b/sound/soc/codecs/rt5640.c
> @@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id rt5640_acpi_match[] = {
>  	{ "INT33CA", 0 },
> +	{ "10EC3276", 0 },
>  	{ "10EC5640", 0 },
>  	{ "10EC5642", 0 },
>  	{ "INTCCFFD", 0 },
> -- 
> 2.10.2
> 

-- 
~Vinod

Re: [PATCH v2 2/2] ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Vinod Koul]

On Wed, Jan 04, 2017 at 03:22:13PM +0300, Alexandrov Stansilav wrote:
> Signed-off-by: Alexandrov Stansilav <neko@nya.ai>

Same comments here too, the title and log doesn't tell me the changes in the
patch.

So a better title could be:

ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

And log may contain:

HP Pavilion x2 10-p000 sports a rt5640 codec, bit with ACPI ID 10EC5640, so
add a new entry in machine table for this configuration.

> ---
>  sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
> index f4d92bb..896ced2 100644
> --- a/sound/soc/intel/atom/sst/sst_acpi.c
> +++ b/sound/soc/intel/atom/sst/sst_acpi.c
> @@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
>  	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
>  	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
>  						&chv_platform_data },
> +	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
> +						&chv_platform_data },
>  
>  	{},
>  };
> -- 
> 2.10.2
> 

-- 
~Vinod

Re: [PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

[Alexandrov Stanislav]

> Vinod Koul писал 2017-01-05 06:49:
> 
> This looks okay, but title is same for both of the patches. It would be
> better to describe the change you are doing and not the outcome.
> 
> so a better title could be:
> 
> ASoC: rt5640: Add "10EC3276" ACPI ID
> 
> and in log say:
> 
> HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add
> that.

Thanks for comments. And i'm sorry for this inconvenience -_- I will 
send new patchset with corrections.


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Applied "ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry" to the asoc tree

[Mark Brown]

The patch

   ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From e7974816a8fce6cd11dc4dfa9f1c1844a9b5d8df Mon Sep 17 00:00:00 2001
From: Alexandrov Stansilav <neko@nya.ai>
Date: Thu, 26 Jan 2017 14:09:32 -0600
Subject: [PATCH] ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

Add machine entry for HP X2 Pavilion 10-p100.
This notebook contains rt5640 codec, but with ACPI ID "10EC3276".

Signed-off-by: Alexandrov Stansilav <neko@nya.ai>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
index f4d92bbc5373..896ced2dd73c 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
 	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
 						&chv_platform_data },
+	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+						&chv_platform_data },
 
 	{},
 };
-- 
2.11.0

Applied "ASoC: rt5640: Add "10EC3276" ACPI ID" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt5640: Add "10EC3276" ACPI ID

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 03200140ee83b3655152bc0c144378732fec8af1 Mon Sep 17 00:00:00 2001
From: Alexandrov Stansilav <neko@nya.ai>
Date: Thu, 26 Jan 2017 14:09:31 -0600
Subject: [PATCH] ASoC: rt5640: Add "10EC3276" ACPI ID

Add ACPI ID "10EC3276" for sound card found on notebook HP Pavilion X2 10-p000.
ACPI DSDT Table on this device describes this card as ALC3276, but it is in fact rt5640.

Signed-off-by: Alexandrov Stansilav <neko@nya.ai>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
index e29a6defefa0..b857a715ef64 100644
--- a/sound/soc/codecs/rt5640.c
+++ b/sound/soc/codecs/rt5640.c
@@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id rt5640_acpi_match[] = {
 	{ "INT33CA", 0 },
+	{ "10EC3276", 0 },
 	{ "10EC5640", 0 },
 	{ "10EC5642", 0 },
 	{ "INTCCFFD", 0 },
-- 
2.11.0