From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Nicolas Chauvet <kwizart@gmail.com>,
linux-kernel@vger.kernel.org, Sameer Pujar <spujar@nvidia.com>,
Takashi Iwai <tiwai@suse.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
Peter Geis <pgwipeout@gmail.com>,
linux-tegra@vger.kernel.org, Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH v3 0/6] Clock and reset improvements for Tegra ALSA drivers
Date: Mon, 25 Jan 2021 16:18:33 +0100 [thread overview]
Message-ID: <s5h4kj53v06.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210120003154.26749-1-digetx@gmail.com>
On Wed, 20 Jan 2021 01:31:48 +0100,
Dmitry Osipenko wrote:
>
> This series improves the handling of clock and reset controls of
> NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling
> resets properly, which needs to be fixed in order to unblock other patches
> related to fixes of the reset controller driver since HDA/AHUB are bound
> to fail once reset controller driver will be corrected. In particular ALSA
> drivers are relying on implicit de-assertion of resets which is done by the
> tegra-clk driver. It's not the business of the clk driver to touch resets
> and we need to fix this because it breaks reset/clk programming sequences
> of other Tegra drivers.
>
> Changelog:
>
> v3: - Reworked "hda/tegra: Reset hardware" and "ahub: Reset hardware properly"
> patches, they now use usleep + reset_deassert() instead of reset_reset().
> Suggested by Thierry Reding.
>
> - Added new patch "hda/tegra: Remove unnecessary null-check from
> hda_tegra_runtime_resume()". Suggested by Thierry Reding.
>
> - Replaced "ahub: Reset hardware properly" patch with "ahub: Add missing
> resets". Suggested by Thierry Reding.
>
> - Slightly improved commit messages.
>
> - Added acks from Thierry Reding.
>
> v2: - Added regcache_sync() to the "ahub: Reset hardware properly" patch,
> which was missed by accident in v1.
>
> - Corrected typo in the format of the error message in "ahub: Use
> of_reset_control_array_get_exclusive()" patch by s/%p/%pe/.
>
> Dmitry Osipenko (6):
> ALSA: hda/tegra: Use clk_bulk helpers
> ALSA: hda/tegra: Reset hardware
> ALSA: hda/tegra: Remove unnecessary null-check from
> hda_tegra_runtime_resume()
> ASoC: tegra: ahub: Add missing resets
> ASoC: tegra: ahub: Use clk_bulk helpers
> ASoC: tegra: ahub: Reset hardware properly
Mark, a half of the series are for ASoC. Would you take those three,
or take the full patches or let me merge through my tree?
thanks,
Takashi
>
> sound/pci/hda/hda_tegra.c | 90 ++++++++++++----------------------
> sound/soc/tegra/tegra30_ahub.c | 64 ++++++++++++++----------
> sound/soc/tegra/tegra30_ahub.h | 5 +-
> 3 files changed, 72 insertions(+), 87 deletions(-)
>
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-01-25 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 0:31 [PATCH v3 0/6] Clock and reset improvements for Tegra ALSA drivers Dmitry Osipenko
2021-01-20 0:31 ` [PATCH v3 1/6] ALSA: hda/tegra: Use clk_bulk helpers Dmitry Osipenko
2021-01-26 6:33 ` Takashi Iwai
2021-01-20 0:31 ` [PATCH v3 2/6] ALSA: hda/tegra: Reset hardware Dmitry Osipenko
2021-01-25 15:18 ` Takashi Iwai
2021-01-25 15:27 ` Dmitry Osipenko
2021-01-26 6:33 ` Takashi Iwai
2021-01-20 0:31 ` [PATCH v3 3/6] ALSA: hda/tegra: Remove unnecessary null-check from hda_tegra_runtime_resume() Dmitry Osipenko
2021-01-26 6:34 ` Takashi Iwai
2021-01-20 0:31 ` [PATCH v3 4/6] ASoC: tegra: ahub: Add missing resets Dmitry Osipenko
2021-01-20 0:31 ` [PATCH v3 5/6] ASoC: tegra: ahub: Use clk_bulk helpers Dmitry Osipenko
2021-01-20 0:31 ` [PATCH v3 6/6] ASoC: tegra: ahub: Reset hardware properly Dmitry Osipenko
2021-01-25 15:18 ` Takashi Iwai [this message]
2021-01-25 18:02 ` (subset) [PATCH v3 0/6] Clock and reset improvements for Tegra ALSA drivers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4kj53v06.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).