* [PATCH] ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen
@ 2020-04-02 17:43 Hans de Goede
2020-04-02 17:53 ` Jaroslav Kysela
2020-04-02 18:43 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2020-04-02 17:43 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Hans de Goede, alsa-devel, stable
The audio setup on the Lenovo Carbon X1 8th gen is the same as that on
the Lenovo Carbon X1 7th gen, as such it needs the same
ALC285_FIXUP_THINKPAD_HEADSET_JACK quirk.
This fixes volume control of the speaker not working among other things.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1820196
Cc: stable@vger.kernel.org
Suggested-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 63e1a56f705b..9c3bbf1df93e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7299,6 +7299,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
+ SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen
2020-04-02 17:43 [PATCH] ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen Hans de Goede
@ 2020-04-02 17:53 ` Jaroslav Kysela
2020-04-02 18:43 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Jaroslav Kysela @ 2020-04-02 17:53 UTC (permalink / raw)
To: Hans de Goede, Takashi Iwai; +Cc: alsa-devel, stable
Dne 02. 04. 20 v 19:43 Hans de Goede napsal(a):
> The audio setup on the Lenovo Carbon X1 8th gen is the same as that on
> the Lenovo Carbon X1 7th gen, as such it needs the same
> ALC285_FIXUP_THINKPAD_HEADSET_JACK quirk.
>
> This fixes volume control of the speaker not working among other things.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1820196
> Cc: stable@vger.kernel.org
> Suggested-by: Jaroslav Kysela <perex@perex.cz>
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 63e1a56f705b..9c3bbf1df93e 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7299,6 +7299,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
> SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
> + SND_PCI_QUIRK(0x17aa, 0x22be, "Thinkpad X1 Carbon 8th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
> SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
> SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
> SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
>
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen
2020-04-02 17:43 [PATCH] ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen Hans de Goede
2020-04-02 17:53 ` Jaroslav Kysela
@ 2020-04-02 18:43 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2020-04-02 18:43 UTC (permalink / raw)
To: Hans de Goede; +Cc: alsa-devel, Takashi Iwai, stable
On Thu, 02 Apr 2020 19:43:11 +0200,
Hans de Goede wrote:
>
> The audio setup on the Lenovo Carbon X1 8th gen is the same as that on
> the Lenovo Carbon X1 7th gen, as such it needs the same
> ALC285_FIXUP_THINKPAD_HEADSET_JACK quirk.
>
> This fixes volume control of the speaker not working among other things.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1820196
> Cc: stable@vger.kernel.org
> Suggested-by: Jaroslav Kysela <perex@perex.cz>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied now, thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-02 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 17:43 [PATCH] ALSA: hda/realtek - Add quirk for Lenovo Carbon X1 8th gen Hans de Goede
2020-04-02 17:53 ` Jaroslav Kysela
2020-04-02 18:43 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).