From: Takashi Iwai <tiwai@suse.de>
To: Kailang <kailang@realtek.com>
Cc: " \(alsa-devel@alsa-project.org\)" <alsa-devel@alsa-project.org>
Subject: Re: New HP mute led feature
Date: Tue, 07 Apr 2020 09:51:27 +0200 [thread overview]
Message-ID: <s5hk12rohs0.wl-tiwai@suse.de> (raw)
In-Reply-To: <6741211598ba499687362ff2aa30626b@realtek.com>
On Tue, 07 Apr 2020 09:05:49 +0200,
Kailang wrote:
>
> Hi Takashi,
>
> I modified as attaches.
Thanks. They had, however, a few typos that didn't compile, so I
applied them with corrections.
Please check the commits in sound git tree later.
Takashi
>
> BR,
> Kailang
>
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Wednesday, April 1, 2020 2:18 PM
> > To: Kailang <kailang@realtek.com>
> > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > Subject: Re: New HP mute led feature
> >
> > On Wed, 01 Apr 2020 07:37:50 +0200,
> > Kailang wrote:
> > >
> > > Hi Takashi,
> > >
> > > HP had new mute led feature.
> > > Attach two patches will enable it.
> >
> > They don't seem applied cleanly.
> > Could you rebase to the latest git tree?
> >
> > Also, it might be worth unifying the handling. Both patches introduce very
> > similar functions, and the values to mask and set can be referred, e.g.
> > spec->coefbit_mask, etc. But such a cleanup can be done in a separate patch
> > later, too.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > ------Please consider the environment before printing this e-mail.
> [2 0001-hp-thinclient-0x877a-mute-led.patch <application/octet-stream (base64)>]
>
> [3 0002-hp-thinclient-0x877d-mute-led.patch <application/octet-stream (base64)>]
>
next prev parent reply other threads:[~2020-04-07 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 5:37 New HP mute led feature Kailang
2020-04-01 6:17 ` Takashi Iwai
2020-04-07 7:05 ` Kailang
2020-04-07 7:51 ` Takashi Iwai [this message]
2020-04-07 7:53 ` Kailang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk12rohs0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).