* [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue()
[not found] ` <20200311010908.42366-1-jbi.octave@gmail.com>
@ 2020-03-11 1:09 ` Jules Irenge
2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
2020-03-11 1:09 ` [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Jules Irenge
1 sibling, 2 replies; 6+ messages in thread
From: Jules Irenge @ 2020-03-11 1:09 UTC (permalink / raw)
To: boqun.feng
Cc: moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...,
netdev, Takashi Iwai, Clemens Ladisch, linux-kernel,
Alexios Zavras, Greg Kroah-Hartman, bpf, Thomas Gleixner,
Allison Randal
Sparse reports a warning at tscm_hwdep_read_queue()
warning: context imbalance in tscm_hwdep_read_queue() - unexpected unlock
The root cause is the missing annotation at tscm_hwdep_read_queue()
Add the missing __releases(&tscm->lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
sound/firewire/tascam/tascam-hwdep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c
index c29a97f6f638..9801e33e7f2a 100644
--- a/sound/firewire/tascam/tascam-hwdep.c
+++ b/sound/firewire/tascam/tascam-hwdep.c
@@ -36,6 +36,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
static long tscm_hwdep_read_queue(struct snd_tscm *tscm, char __user *buf,
long remained, loff_t *offset)
+ __releases(&tscm->lock)
{
char __user *pos = buf;
unsigned int type = SNDRV_FIREWIRE_EVENT_TASCAM_CONTROL;
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked()
[not found] ` <20200311010908.42366-1-jbi.octave@gmail.com>
2020-03-11 1:09 ` [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Jules Irenge
@ 2020-03-11 1:09 ` Jules Irenge
2020-03-11 3:18 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
1 sibling, 2 replies; 6+ messages in thread
From: Jules Irenge @ 2020-03-11 1:09 UTC (permalink / raw)
To: boqun.feng
Cc: moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...,
netdev, Takashi Iwai, Clemens Ladisch, linux-kernel,
Alexios Zavras, Greg Kroah-Hartman, bpf, Thomas Gleixner,
Allison Randal
Sparse reports a warning at tscm_hwdep_read_locked()
warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock
The root cause is the missing annotation at tscm_hwdep_read_locked()
Add the missing __releases(&tscm->lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
sound/firewire/tascam/tascam-hwdep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c
index 9801e33e7f2a..6f38335fe10b 100644
--- a/sound/firewire/tascam/tascam-hwdep.c
+++ b/sound/firewire/tascam/tascam-hwdep.c
@@ -17,6 +17,7 @@
static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
long count, loff_t *offset)
+ __releases(&tscm->lock)
{
struct snd_firewire_event_lock_status event = {
.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked()
2020-03-11 1:09 ` [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Jules Irenge
@ 2020-03-11 3:18 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
1 sibling, 0 replies; 6+ messages in thread
From: Takashi Sakamoto @ 2020-03-11 3:18 UTC (permalink / raw)
To: Jules Irenge
Cc: moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...,
netdev, boqun.feng, Takashi Iwai, Clemens Ladisch, linux-kernel,
Alexios Zavras, Greg Kroah-Hartman, bpf, Thomas Gleixner,
Allison Randal
Hi,
On Wed, Mar 11, 2020 at 01:09:08AM +0000, Jules Irenge wrote:
> Sparse reports a warning at tscm_hwdep_read_locked()
>
> warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock
>
> The root cause is the missing annotation at tscm_hwdep_read_locked()
> Add the missing __releases(&tscm->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> sound/firewire/tascam/tascam-hwdep.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks for your care of the warning. Although I have found it, I had
no idea to suppress it.
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c
> index 9801e33e7f2a..6f38335fe10b 100644
> --- a/sound/firewire/tascam/tascam-hwdep.c
> +++ b/sound/firewire/tascam/tascam-hwdep.c
> @@ -17,6 +17,7 @@
>
> static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
> long count, loff_t *offset)
> + __releases(&tscm->lock)
> {
> struct snd_firewire_event_lock_status event = {
> .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue()
2020-03-11 1:09 ` [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Jules Irenge
@ 2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
1 sibling, 0 replies; 6+ messages in thread
From: Takashi Sakamoto @ 2020-03-11 3:19 UTC (permalink / raw)
To: Jules Irenge
Cc: moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...,
netdev, boqun.feng, Takashi Iwai, Clemens Ladisch, linux-kernel,
Alexios Zavras, Greg Kroah-Hartman, bpf, Thomas Gleixner,
Allison Randal
On Wed, Mar 11, 2020 at 01:09:07AM +0000, Jules Irenge wrote:
> Sparse reports a warning at tscm_hwdep_read_queue()
>
> warning: context imbalance in tscm_hwdep_read_queue() - unexpected unlock
>
> The root cause is the missing annotation at tscm_hwdep_read_queue()
> Add the missing __releases(&tscm->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> sound/firewire/tascam/tascam-hwdep.c | 1 +
> 1 file changed, 1 insertion(+)
This looks good.
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c
> index c29a97f6f638..9801e33e7f2a 100644
> --- a/sound/firewire/tascam/tascam-hwdep.c
> +++ b/sound/firewire/tascam/tascam-hwdep.c
> @@ -36,6 +36,7 @@ static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
>
> static long tscm_hwdep_read_queue(struct snd_tscm *tscm, char __user *buf,
> long remained, loff_t *offset)
> + __releases(&tscm->lock)
> {
> char __user *pos = buf;
> unsigned int type = SNDRV_FIREWIRE_EVENT_TASCAM_CONTROL;
> --
> 2.24.1
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked()
2020-03-11 1:09 ` [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Jules Irenge
2020-03-11 3:18 ` Takashi Sakamoto
@ 2020-03-11 6:56 ` Takashi Iwai
1 sibling, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2020-03-11 6:56 UTC (permalink / raw)
To: Jules Irenge
Cc: moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...,
netdev, boqun.feng, Takashi Iwai, Clemens Ladisch, linux-kernel,
Alexios Zavras, Greg Kroah-Hartman, bpf, Thomas Gleixner,
Allison Randal
On Wed, 11 Mar 2020 02:09:08 +0100,
Jules Irenge wrote:
>
> Sparse reports a warning at tscm_hwdep_read_locked()
>
> warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock
>
> The root cause is the missing annotation at tscm_hwdep_read_locked()
> Add the missing __releases(&tscm->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue()
2020-03-11 1:09 ` [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Jules Irenge
2020-03-11 3:19 ` Takashi Sakamoto
@ 2020-03-11 6:56 ` Takashi Iwai
1 sibling, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2020-03-11 6:56 UTC (permalink / raw)
To: Jules Irenge
Cc: moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6 PACKET...,
netdev, boqun.feng, Takashi Iwai, Clemens Ladisch, linux-kernel,
Alexios Zavras, Greg Kroah-Hartman, bpf, Thomas Gleixner,
Allison Randal
On Wed, 11 Mar 2020 02:09:07 +0100,
Jules Irenge wrote:
>
> Sparse reports a warning at tscm_hwdep_read_queue()
>
> warning: context imbalance in tscm_hwdep_read_queue() - unexpected unlock
>
> The root cause is the missing annotation at tscm_hwdep_read_queue()
> Add the missing __releases(&tscm->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-11 6:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <0/8>
[not found] ` <20200311010908.42366-1-jbi.octave@gmail.com>
2020-03-11 1:09 ` [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Jules Irenge
2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
2020-03-11 1:09 ` [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Jules Irenge
2020-03-11 3:18 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).