alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620
@ 2020-08-03 15:57 Kai-Heng Feng
  2020-08-11 10:00 ` Kai-Heng Feng
  0 siblings, 1 reply; 5+ messages in thread
From: Kai-Heng Feng @ 2020-08-03 15:57 UTC (permalink / raw)
  To: alsa-devel; +Cc: Kai-Heng Feng

Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958,
so disable IEC958 accordingly.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 src/conf/cards/USB-Audio.conf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf
index 297629f3..9b64af3c 100644
--- a/src/conf/cards/USB-Audio.conf
+++ b/src/conf/cards/USB-Audio.conf
@@ -63,6 +63,8 @@ USB-Audio.pcm.iec958_device {
 	"Scarlett 2i4 USB" 999
 	"Sennheiser USB headset" 999
 	"SWTOR Gaming Headset by Razer" 999
+	"ThinkStation P620 Main" 999
+	"ThinkStation P620 Rear" 999
 	"Thunderbolt Dock Audio Headset" 999
 	"Thunderbolt Dock Audio Module" 999
 	"USB Device 0x46d_0x821" 999
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620
  2020-08-03 15:57 [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620 Kai-Heng Feng
@ 2020-08-11 10:00 ` Kai-Heng Feng
  2020-08-11 11:17   ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Kai-Heng Feng @ 2020-08-11 10:00 UTC (permalink / raw)
  To: moderated list:SOUND

Hi,

> On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> 
> Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958,
> so disable IEC958 accordingly.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Should I use GitHub instead of mailing list for any future alia-lib patch?

Kai-Heng

> ---
> src/conf/cards/USB-Audio.conf | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/src/conf/cards/USB-Audio.conf b/src/conf/cards/USB-Audio.conf
> index 297629f3..9b64af3c 100644
> --- a/src/conf/cards/USB-Audio.conf
> +++ b/src/conf/cards/USB-Audio.conf
> @@ -63,6 +63,8 @@ USB-Audio.pcm.iec958_device {
> 	"Scarlett 2i4 USB" 999
> 	"Sennheiser USB headset" 999
> 	"SWTOR Gaming Headset by Razer" 999
> +	"ThinkStation P620 Main" 999
> +	"ThinkStation P620 Rear" 999
> 	"Thunderbolt Dock Audio Headset" 999
> 	"Thunderbolt Dock Audio Module" 999
> 	"USB Device 0x46d_0x821" 999
> -- 
> 2.17.1
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620
  2020-08-11 10:00 ` Kai-Heng Feng
@ 2020-08-11 11:17   ` Takashi Iwai
  2020-08-12  4:00     ` Kai-Heng Feng
  0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2020-08-11 11:17 UTC (permalink / raw)
  To: Kai-Heng Feng; +Cc: moderated list:SOUND

On Tue, 11 Aug 2020 12:00:54 +0200,
Kai-Heng Feng wrote:
> 
> Hi,
> 
> > On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> > 
> > Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958,
> > so disable IEC958 accordingly.
> > 
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> 
> Should I use GitHub instead of mailing list for any future alia-lib patch?

Sorry, I overlooked this since I wasn't on Cc.
Applied now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620
  2020-08-11 11:17   ` Takashi Iwai
@ 2020-08-12  4:00     ` Kai-Heng Feng
  2020-08-12  6:22       ` Takashi Iwai
  0 siblings, 1 reply; 5+ messages in thread
From: Kai-Heng Feng @ 2020-08-12  4:00 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: moderated list:SOUND

Hi,

> On Aug 11, 2020, at 19:17, Takashi Iwai <tiwai@suse.de> wrote:
> 
> On Tue, 11 Aug 2020 12:00:54 +0200,
> Kai-Heng Feng wrote:
>> 
>> Hi,
>> 
>>> On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
>>> 
>>> Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958,
>>> so disable IEC958 accordingly.
>>> 
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> 
>> Should I use GitHub instead of mailing list for any future alia-lib patch?
> 
> Sorry, I overlooked this since I wasn't on Cc.
> Applied now.  Thanks.

Thanks.

Is mailing list or GitHub preferred way?

Kai-Heng

> 
> 
> Takashi


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620
  2020-08-12  4:00     ` Kai-Heng Feng
@ 2020-08-12  6:22       ` Takashi Iwai
  0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2020-08-12  6:22 UTC (permalink / raw)
  To: Kai-Heng Feng; +Cc: moderated list:SOUND

On Wed, 12 Aug 2020 06:00:22 +0200,
Kai-Heng Feng wrote:
> 
> Hi,
> 
> > On Aug 11, 2020, at 19:17, Takashi Iwai <tiwai@suse.de> wrote:
> > 
> > On Tue, 11 Aug 2020 12:00:54 +0200,
> > Kai-Heng Feng wrote:
> >> 
> >> Hi,
> >> 
> >>> On Aug 3, 2020, at 23:57, Kai-Heng Feng <kai.heng.feng@canonical.com> wrote:
> >>> 
> >>> Both USB audio cards on Lenovo ThinkStation P620 don't support IEC958,
> >>> so disable IEC958 accordingly.
> >>> 
> >>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> 
> >> Should I use GitHub instead of mailing list for any future alia-lib patch?
> > 
> > Sorry, I overlooked this since I wasn't on Cc.
> > Applied now.  Thanks.
> 
> Thanks.
> 
> Is mailing list or GitHub preferred way?

I personally still prefer ML, but it's basically up to you.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-08-12  6:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 15:57 [PATCH] conf: USB-Audio: Disable IEC958 on Lenovo ThinkStation P620 Kai-Heng Feng
2020-08-11 10:00 ` Kai-Heng Feng
2020-08-11 11:17   ` Takashi Iwai
2020-08-12  4:00     ` Kai-Heng Feng
2020-08-12  6:22       ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).