* [alsa-devel] [PATCH 0/2] ALSA: HDA: remove warnings with make W=1
@ 2020-01-13 21:14 Pierre-Louis Bossart
2020-01-13 21:14 ` [alsa-devel] [PATCH 1/2] ALSA: HDA: correct kernel-doc parameter descriptions Pierre-Louis Bossart
2020-01-13 21:14 ` [alsa-devel] [PATCH 2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body Pierre-Louis Bossart
0 siblings, 2 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:14 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, broonie, Pierre-Louis Bossart
Last series to make the sound subsystem report next to zero warnings
(at least for the parts used by Intel).
Pierre-Louis Bossart (2):
ALSA: HDA: correct kernel-doc parameter descriptions
ALSA: HDA: patch_hdmi: remove warnings with empty body
sound/pci/hda/hda_codec.c | 1 +
sound/pci/hda/hda_generic.c | 5 +++++
sound/pci/hda/hda_jack.c | 2 ++
sound/pci/hda/patch_ca0132.c | 1 +
sound/pci/hda/patch_hdmi.c | 6 ++++--
5 files changed, 13 insertions(+), 2 deletions(-)
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [alsa-devel] [PATCH 1/2] ALSA: HDA: correct kernel-doc parameter descriptions
2020-01-13 21:14 [alsa-devel] [PATCH 0/2] ALSA: HDA: remove warnings with make W=1 Pierre-Louis Bossart
@ 2020-01-13 21:14 ` Pierre-Louis Bossart
2020-01-14 6:46 ` Takashi Iwai
2020-01-13 21:14 ` [alsa-devel] [PATCH 2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body Pierre-Louis Bossart
1 sibling, 1 reply; 5+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:14 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, broonie, Pierre-Louis Bossart
make W=1 throws warnings, provide missing documentation
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/pci/hda/hda_codec.c | 1 +
sound/pci/hda/hda_generic.c | 5 +++++
sound/pci/hda/hda_jack.c | 2 ++
sound/pci/hda/patch_ca0132.c | 1 +
4 files changed, 9 insertions(+)
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 83aa4c1015d2..5dc42f932739 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -891,6 +891,7 @@ static int snd_hda_codec_device_init(struct hda_bus *bus, struct snd_card *card,
/**
* snd_hda_codec_new - create a HDA codec
* @bus: the bus to assign
+ * @card: card for this codec
* @codec_addr: the codec address
* @codecp: the pointer to store the generated codec
*
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 6815f9dc8545..f4e9d9445e18 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -4042,6 +4042,11 @@ static void call_ledtrig_micmute(struct hda_codec *codec)
*
* Note that this fixup has to be called after other fixup that sets
* cap_sync_hook. Otherwise the chaining wouldn't work.
+ *
+ * @codec: the HDA codec
+ * @fix: fixup pointer
+ * @action: only supports HDA_FIXUP_ACT_PROBE value
+ *
*/
void snd_hda_gen_fixup_micmute_led(struct hda_codec *codec,
const struct hda_fixup *fix, int action)
diff --git a/sound/pci/hda/hda_jack.c b/sound/pci/hda/hda_jack.c
index bf0255cb0515..02cc682caa55 100644
--- a/sound/pci/hda/hda_jack.c
+++ b/sound/pci/hda/hda_jack.c
@@ -122,6 +122,7 @@ any_jack_tbl_get_from_nid(struct hda_codec *codec, hda_nid_t nid)
* snd_hda_jack_tbl_new - create a jack-table entry for the given NID
* @codec: the HDA codec
* @nid: pin NID to assign
+ * @dev_id: pin device entry id
*/
static struct hda_jack_tbl *
snd_hda_jack_tbl_new(struct hda_codec *codec, hda_nid_t nid, int dev_id)
@@ -233,6 +234,7 @@ EXPORT_SYMBOL_GPL(snd_hda_jack_set_dirty_all);
* snd_hda_jack_pin_sense - execute pin sense measurement
* @codec: the CODEC to sense
* @nid: the pin NID to sense
+ * @dev_id: pin device entry id
*
* Execute necessary pin sense measurement and return its Presence Detect,
* Impedance, ELD Valid etc. status bits.
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 46e105244ad3..ded8bc07d755 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -1923,6 +1923,7 @@ static int dspio_send_scp_message(struct hda_codec *codec,
* Prepare and send the SCP message to DSP
* @codec: the HDA codec
* @mod_id: ID of the DSP module to send the command
+ * @src_id: ID of the source
* @req: ID of request to send to the DSP module
* @dir: SET or GET
* @data: pointer to the data to send with the request, request specific
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [alsa-devel] [PATCH 2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body
2020-01-13 21:14 [alsa-devel] [PATCH 0/2] ALSA: HDA: remove warnings with make W=1 Pierre-Louis Bossart
2020-01-13 21:14 ` [alsa-devel] [PATCH 1/2] ALSA: HDA: correct kernel-doc parameter descriptions Pierre-Louis Bossart
@ 2020-01-13 21:14 ` Pierre-Louis Bossart
2020-01-14 6:52 ` Takashi Iwai
1 sibling, 1 reply; 5+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-13 21:14 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, broonie, Pierre-Louis Bossart
make W=1 reports the following warnings, fix as suggested
sound/pci/hda/patch_hdmi.c: In function ‘hdmi_non_intrinsic_event’:
sound/pci/hda/patch_hdmi.c:824:3: warning: suggest braces around empty
body in an ‘if’ statement [-Wempty-body]
824 | ;
| ^
sound/pci/hda/patch_hdmi.c:826:3: warning: suggest braces around empty
body in an ‘if’ statement [-Wempty-body]
826 | ;
| ^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/pci/hda/patch_hdmi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 3a18fa4f8c21..ce3c212ee467 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -820,10 +820,12 @@ static void hdmi_non_intrinsic_event(struct hda_codec *codec, unsigned int res)
cp_ready);
/* TODO */
- if (cp_state)
+ if (cp_state) {
;
- if (cp_ready)
+ }
+ if (cp_ready) {
;
+ }
}
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH 1/2] ALSA: HDA: correct kernel-doc parameter descriptions
2020-01-13 21:14 ` [alsa-devel] [PATCH 1/2] ALSA: HDA: correct kernel-doc parameter descriptions Pierre-Louis Bossart
@ 2020-01-14 6:46 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2020-01-14 6:46 UTC (permalink / raw)
To: Pierre-Louis Bossart; +Cc: alsa-devel, broonie
On Mon, 13 Jan 2020 22:14:04 +0100,
Pierre-Louis Bossart wrote:
>
> make W=1 throws warnings, provide missing documentation
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Applied, thanks.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH 2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body
2020-01-13 21:14 ` [alsa-devel] [PATCH 2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body Pierre-Louis Bossart
@ 2020-01-14 6:52 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2020-01-14 6:52 UTC (permalink / raw)
To: Pierre-Louis Bossart; +Cc: alsa-devel, broonie
On Mon, 13 Jan 2020 22:14:05 +0100,
Pierre-Louis Bossart wrote:
>
> make W=1 reports the following warnings, fix as suggested
>
> sound/pci/hda/patch_hdmi.c: In function ‘hdmi_non_intrinsic_event’:
> sound/pci/hda/patch_hdmi.c:824:3: warning: suggest braces around empty
> body in an ‘if’ statement [-Wempty-body]
> 824 | ;
> | ^
> sound/pci/hda/patch_hdmi.c:826:3: warning: suggest braces around empty
> body in an ‘if’ statement [-Wempty-body]
> 826 | ;
> | ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Applied, thanks.
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-14 13:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 21:14 [alsa-devel] [PATCH 0/2] ALSA: HDA: remove warnings with make W=1 Pierre-Louis Bossart
2020-01-13 21:14 ` [alsa-devel] [PATCH 1/2] ALSA: HDA: correct kernel-doc parameter descriptions Pierre-Louis Bossart
2020-01-14 6:46 ` Takashi Iwai
2020-01-13 21:14 ` [alsa-devel] [PATCH 2/2] ALSA: HDA: patch_hdmi: remove warnings with empty body Pierre-Louis Bossart
2020-01-14 6:52 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).