Re: [PATCH v2 -next] drm/amd/display: remove set but not used variable 'bpc'

From: Alex Deucher <alexdeucher@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Chunming Zhou <David1.Zhou@amd.com>,
	"Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	Zhan Liu <Zhan.Liu@amd.com>, LKML <linux-kernel@vger.kernel.org>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	Dave Airlie <airlied@linux.ie>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	Jun Lei <Jun.Lei@amd.com>,
	"Wentland, Harry" <harry.wentland@amd.com>,
	Christian Koenig <christian.koenig@amd.com>,
	Anthony Koo <Anthony.Koo@amd.com>
Subject: Re: [PATCH v2 -next] drm/amd/display: remove set but not used variable 'bpc'
Date: Tue, 12 Nov 2019 10:52:40 -0500	[thread overview]
Message-ID: <CADnq5_Mj5vHSrXq-tkwoRQ+fejfosSnRpia54MpsTddvKzothA@mail.gmail.com> (raw)
Message-ID: <20191112155240.Bz3FTdhZJSDmuzE_ZRW15NakzqlpT2MDre34UtAKEtQ@z> (raw)
In-Reply-To: <20191112021050.13128-1-yuehaibing@huawei.com>

On Tue, Nov 12, 2019 at 3:13 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function get_pbn_from_timing:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:2364:11: warning:
>  variable bpc set but not used [-Wunused-but-set-variable]
>
> It is not used since commit e49f69363adf ("drm/amd/display: use
> proper formula to calculate bandwidth from timing"), this also
> remove get_color_depth(), which is only used here.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.  Thanks!

Alex

> ---
> v2: also remove unused get_color_depth()
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 15 ---------------
>  1 file changed, 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index bdc8be3..1be4277 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2638,28 +2638,13 @@ static struct fixed31_32 get_pbn_per_slot(struct dc_stream_state *stream)
>         return dc_fixpt_div_int(mbytes_per_sec, 54);
>  }
>
> -static int get_color_depth(enum dc_color_depth color_depth)
> -{
> -       switch (color_depth) {
> -       case COLOR_DEPTH_666: return 6;
> -       case COLOR_DEPTH_888: return 8;
> -       case COLOR_DEPTH_101010: return 10;
> -       case COLOR_DEPTH_121212: return 12;
> -       case COLOR_DEPTH_141414: return 14;
> -       case COLOR_DEPTH_161616: return 16;
> -       default: return 0;
> -       }
> -}
> -
>  static struct fixed31_32 get_pbn_from_timing(struct pipe_ctx *pipe_ctx)
>  {
> -       uint32_t bpc;
>         uint64_t kbps;
>         struct fixed31_32 peak_kbps;
>         uint32_t numerator;
>         uint32_t denominator;
>
> -       bpc = get_color_depth(pipe_ctx->stream_res.pix_clk_params.color_depth);
>         kbps = dc_bandwidth_in_kbps_from_timing(&pipe_ctx->stream->timing);
>
>         /*
> --
> 2.7.4
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx