* [PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check
@ 2019-11-12 15:15 mikita.lipski-5C7GfCeVMHo
2019-11-12 15:15 ` mikita.lipski
[not found] ` <20191112151532.8192-1-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: mikita.lipski-5C7GfCeVMHo @ 2019-11-12 15:15 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, harry.wentland-5C7GfCeVMHo
Cc: alexander.deucher-5C7GfCeVMHo, Mikita Lipski,
nicholas.kazlauskas-5C7GfCeVMHo
From: Mikita Lipski <mikita.lipski@amd.com>
[why]
For MST connector atomic check we have to check a new CRTC state
instead of an old one, when checking if CRTC is disabled to
release VCPI slots allocated.
Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 21f09b61ee88..00cb2f109853 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -299,7 +299,7 @@ static int dm_dp_mst_atomic_check(struct drm_connector *connector,
return 0;
if (new_conn_state->crtc) {
- new_crtc_state = drm_atomic_get_old_crtc_state(state, new_conn_state->crtc);
+ new_crtc_state = drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
if (!new_crtc_state ||
!drm_atomic_crtc_needs_modeset(new_crtc_state) ||
new_crtc_state->enable)
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check
2019-11-12 15:15 [PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check mikita.lipski-5C7GfCeVMHo
@ 2019-11-12 15:15 ` mikita.lipski
[not found] ` <20191112151532.8192-1-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
1 sibling, 0 replies; 4+ messages in thread
From: mikita.lipski @ 2019-11-12 15:15 UTC (permalink / raw)
To: amd-gfx, harry.wentland
Cc: alexander.deucher, Mikita Lipski, nicholas.kazlauskas
From: Mikita Lipski <mikita.lipski@amd.com>
[why]
For MST connector atomic check we have to check a new CRTC state
instead of an old one, when checking if CRTC is disabled to
release VCPI slots allocated.
Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 21f09b61ee88..00cb2f109853 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -299,7 +299,7 @@ static int dm_dp_mst_atomic_check(struct drm_connector *connector,
return 0;
if (new_conn_state->crtc) {
- new_crtc_state = drm_atomic_get_old_crtc_state(state, new_conn_state->crtc);
+ new_crtc_state = drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
if (!new_crtc_state ||
!drm_atomic_crtc_needs_modeset(new_crtc_state) ||
new_crtc_state->enable)
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check
[not found] ` <20191112151532.8192-1-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
@ 2019-11-12 16:06 ` Kazlauskas, Nicholas
2019-11-12 16:06 ` Kazlauskas, Nicholas
0 siblings, 1 reply; 4+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-12 16:06 UTC (permalink / raw)
To: mikita.lipski-5C7GfCeVMHo,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
harry.wentland-5C7GfCeVMHo
Cc: alexander.deucher-5C7GfCeVMHo
On 2019-11-12 10:15 a.m., mikita.lipski@amd.com wrote:
> From: Mikita Lipski <mikita.lipski@amd.com>
>
> [why]
> For MST connector atomic check we have to check a new CRTC state
> instead of an old one, when checking if CRTC is disabled to
> release VCPI slots allocated.
>
> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Nicholas Kazlauskas
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 21f09b61ee88..00cb2f109853 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -299,7 +299,7 @@ static int dm_dp_mst_atomic_check(struct drm_connector *connector,
> return 0;
>
> if (new_conn_state->crtc) {
> - new_crtc_state = drm_atomic_get_old_crtc_state(state, new_conn_state->crtc);
> + new_crtc_state = drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
> if (!new_crtc_state ||
> !drm_atomic_crtc_needs_modeset(new_crtc_state) ||
> new_crtc_state->enable)
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check
2019-11-12 16:06 ` Kazlauskas, Nicholas
@ 2019-11-12 16:06 ` Kazlauskas, Nicholas
0 siblings, 0 replies; 4+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-12 16:06 UTC (permalink / raw)
To: mikita.lipski, amd-gfx, harry.wentland; +Cc: alexander.deucher
On 2019-11-12 10:15 a.m., mikita.lipski@amd.com wrote:
> From: Mikita Lipski <mikita.lipski@amd.com>
>
> [why]
> For MST connector atomic check we have to check a new CRTC state
> instead of an old one, when checking if CRTC is disabled to
> release VCPI slots allocated.
>
> Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Nicholas Kazlauskas
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 21f09b61ee88..00cb2f109853 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -299,7 +299,7 @@ static int dm_dp_mst_atomic_check(struct drm_connector *connector,
> return 0;
>
> if (new_conn_state->crtc) {
> - new_crtc_state = drm_atomic_get_old_crtc_state(state, new_conn_state->crtc);
> + new_crtc_state = drm_atomic_get_new_crtc_state(state, new_conn_state->crtc);
> if (!new_crtc_state ||
> !drm_atomic_crtc_needs_modeset(new_crtc_state) ||
> new_crtc_state->enable)
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-12 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 15:15 [PATCH 2/2] drm/amd/display: Fix coding error in connector atomic check mikita.lipski-5C7GfCeVMHo
2019-11-12 15:15 ` mikita.lipski
[not found] ` <20191112151532.8192-1-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
2019-11-12 16:06 ` Kazlauskas, Nicholas
2019-11-12 16:06 ` Kazlauskas, Nicholas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).