From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Frederick Lawler" <fred@fredlawl.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Michel Dänzer" <michel@daenzer.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Ilia Mirkin" <imirkin@alum.mit.edu>
Subject: RE: [PATCH V3 0/3] drm: replace magic numbers
Date: Tue, 12 Nov 2019 19:35:53 +0000 [thread overview]
Message-ID: <CY4PR12MB1813200B2297DB19D1921A83F7770@CY4PR12MB1813.namprd12.prod.outlook.com> (raw)
Message-ID: <20191112193553.tqXFV17V0GbPgZBD6cPr4tJ8lFrFVLT0M3tDaH5hHqU@z> (raw)
In-Reply-To: <20191112173503.176611-1-helgaas@kernel.org>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Bjorn Helgaas
> Sent: Tuesday, November 12, 2019 12:35 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>; David Airlie <airlied@linux.ie>; Daniel Vetter
> <daniel@ffwll.ch>
> Cc: Frederick Lawler <fred@fredlawl.com>; linux-pci@vger.kernel.org;
> Michel Dänzer <michel@daenzer.net>; linux-kernel@vger.kernel.org; dri-
> devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Bjorn Helgaas
> <bhelgaas@google.com>; Ilia Mirkin <imirkin@alum.mit.edu>
> Subject: [PATCH V3 0/3] drm: replace magic numbers
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> amdgpu and radeon do a bit of mucking with the PCIe Link Control 2 register,
> some of it using hard-coded magic numbers. The idea here is to replace
> those with #defines.
>
> Since v2:
> - Fix a gpu_cfg2 case in amdgpu/si.c that I had missed
> - Separate out the functional changes for better bisection (thanks,
> Michel!)
> - Add #defines in a patch by themselves (so a GPU revert wouldn't break
> other potential users)
> - Squash all the magic number -> #define changes into one patch
>
> Since v1:
> - Add my signed-off-by and Alex's reviewed-by.
>
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
I'm happy to have it go through whatever tree is easiest for you.
Thanks,
Alex
> Bjorn Helgaas (3):
> PCI: Add #defines for Enter Compliance, Transmit Margin
> drm: correct Transmit Margin masks
> drm: replace numbers with PCI_EXP_LNKCTL2 definitions
>
> drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++--------
> drivers/gpu/drm/amd/amdgpu/si.c | 22 ++++++++++++++--------
> drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++--------
> drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++--------
> include/uapi/linux/pci_regs.h | 2 ++
> 5 files changed, 58 insertions(+), 32 deletions(-)
>
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-11-12 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 17:35 [PATCH V3 0/3] drm: replace magic numbers Bjorn Helgaas
2019-11-12 17:35 ` Bjorn Helgaas
[not found] ` <20191112173503.176611-1-helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2019-11-12 17:35 ` [PATCH 1/3] PCI: Add #defines for Enter Compliance, Transmit Margin Bjorn Helgaas
2019-11-12 17:35 ` Bjorn Helgaas
2019-11-12 17:35 ` [PATCH 2/3] drm: correct Transmit Margin masks Bjorn Helgaas
2019-11-12 17:35 ` Bjorn Helgaas
2019-11-12 17:35 ` [PATCH 3/3] drm: replace numbers with PCI_EXP_LNKCTL2 definitions Bjorn Helgaas
2019-11-12 17:35 ` Bjorn Helgaas
2019-11-12 19:35 ` Deucher, Alexander [this message]
2019-11-12 19:35 ` [PATCH V3 0/3] drm: replace magic numbers Deucher, Alexander
2019-11-12 21:52 ` Bjorn Helgaas
2019-11-12 21:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR12MB1813200B2297DB19D1921A83F7770@CY4PR12MB1813.namprd12.prod.outlook.com \
--to=alexander.deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhelgaas@google.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fred@fredlawl.com \
--cc=helgaas@kernel.org \
--cc=imirkin@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).