* [bug report] drm/amd/display: Add MST atomic routines
@ 2019-11-13 18:28 Dan Carpenter
2019-11-13 18:28 ` Dan Carpenter
[not found] ` <20191113182849.7qzsh2odtr6dw2u3-vMlZ3nK25oGAIHFoDFOv9A@public.gmane.org>
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-11-13 18:28 UTC (permalink / raw)
To: mikita.lipski-5C7GfCeVMHo; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Hello Mikita Lipski,
The patch b4c578f08378: "drm/amd/display: Add MST atomic routines"
from Nov 6, 2019, leads to the following static checker warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4870 dm_encoder_helper_atomic_check()
warn: unsigned 'dm_new_connector_state->vcpi_slots' is never less than zero.
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
4851 if (!aconnector->port || !aconnector->dc_sink)
4852 return 0;
4853
4854 mst_port = aconnector->port;
4855 mst_mgr = &aconnector->mst_port->mst_mgr;
4856
4857 if (!crtc_state->connectors_changed && !crtc_state->mode_changed)
4858 return 0;
4859
4860 if (!state->duplicated) {
4861 color_depth = convert_color_depth_from_display_info(connector, conn_state);
4862 bpp = convert_dc_color_depth_into_bpc(color_depth) * 3;
4863 clock = adjusted_mode->clock;
4864 dm_new_connector_state->pbn = drm_dp_calc_pbn_mode(clock, bpp);
4865 }
4866 dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state,
4867 mst_mgr,
4868 mst_port,
4869 dm_new_connector_state->pbn);
4870 if (dm_new_connector_state->vcpi_slots < 0) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Impossible condition.
4871 DRM_DEBUG_ATOMIC("failed finding vcpi slots: %d\n", (int)dm_new_connector_state->vcpi_slots);
4872 return dm_new_connector_state->vcpi_slots;
4873 }
4874 return 0;
4875 }
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug report] drm/amd/display: Add MST atomic routines
2019-11-13 18:28 [bug report] drm/amd/display: Add MST atomic routines Dan Carpenter
@ 2019-11-13 18:28 ` Dan Carpenter
[not found] ` <20191113182849.7qzsh2odtr6dw2u3-vMlZ3nK25oGAIHFoDFOv9A@public.gmane.org>
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-11-13 18:28 UTC (permalink / raw)
To: mikita.lipski; +Cc: amd-gfx
Hello Mikita Lipski,
The patch b4c578f08378: "drm/amd/display: Add MST atomic routines"
from Nov 6, 2019, leads to the following static checker warning:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4870 dm_encoder_helper_atomic_check()
warn: unsigned 'dm_new_connector_state->vcpi_slots' is never less than zero.
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
4851 if (!aconnector->port || !aconnector->dc_sink)
4852 return 0;
4853
4854 mst_port = aconnector->port;
4855 mst_mgr = &aconnector->mst_port->mst_mgr;
4856
4857 if (!crtc_state->connectors_changed && !crtc_state->mode_changed)
4858 return 0;
4859
4860 if (!state->duplicated) {
4861 color_depth = convert_color_depth_from_display_info(connector, conn_state);
4862 bpp = convert_dc_color_depth_into_bpc(color_depth) * 3;
4863 clock = adjusted_mode->clock;
4864 dm_new_connector_state->pbn = drm_dp_calc_pbn_mode(clock, bpp);
4865 }
4866 dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state,
4867 mst_mgr,
4868 mst_port,
4869 dm_new_connector_state->pbn);
4870 if (dm_new_connector_state->vcpi_slots < 0) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Impossible condition.
4871 DRM_DEBUG_ATOMIC("failed finding vcpi slots: %d\n", (int)dm_new_connector_state->vcpi_slots);
4872 return dm_new_connector_state->vcpi_slots;
4873 }
4874 return 0;
4875 }
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bug report] drm/amd/display: Add MST atomic routines
[not found] ` <20191113182849.7qzsh2odtr6dw2u3-vMlZ3nK25oGAIHFoDFOv9A@public.gmane.org>
@ 2019-11-13 18:39 ` Mikita Lipski
2019-11-13 18:39 ` Mikita Lipski
0 siblings, 1 reply; 4+ messages in thread
From: Mikita Lipski @ 2019-11-13 18:39 UTC (permalink / raw)
To: Dan Carpenter, mikita.lipski-5C7GfCeVMHo
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Hi Dan,
The bug has been fixed by the patch "drm/amd/display: Fix unsigned
variable compared to less than zero" by Gustavo A. R. Silva
Thanks
On 13.11.2019 13:28, Dan Carpenter wrote:
> Hello Mikita Lipski,
>
> The patch b4c578f08378: "drm/amd/display: Add MST atomic routines"
> from Nov 6, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4870 dm_encoder_helper_atomic_check()
> warn: unsigned 'dm_new_connector_state->vcpi_slots' is never less than zero.
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
> 4851 if (!aconnector->port || !aconnector->dc_sink)
> 4852 return 0;
> 4853
> 4854 mst_port = aconnector->port;
> 4855 mst_mgr = &aconnector->mst_port->mst_mgr;
> 4856
> 4857 if (!crtc_state->connectors_changed && !crtc_state->mode_changed)
> 4858 return 0;
> 4859
> 4860 if (!state->duplicated) {
> 4861 color_depth = convert_color_depth_from_display_info(connector, conn_state);
> 4862 bpp = convert_dc_color_depth_into_bpc(color_depth) * 3;
> 4863 clock = adjusted_mode->clock;
> 4864 dm_new_connector_state->pbn = drm_dp_calc_pbn_mode(clock, bpp);
> 4865 }
> 4866 dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state,
> 4867 mst_mgr,
> 4868 mst_port,
> 4869 dm_new_connector_state->pbn);
> 4870 if (dm_new_connector_state->vcpi_slots < 0) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Impossible condition.
>
> 4871 DRM_DEBUG_ATOMIC("failed finding vcpi slots: %d\n", (int)dm_new_connector_state->vcpi_slots);
> 4872 return dm_new_connector_state->vcpi_slots;
> 4873 }
> 4874 return 0;
> 4875 }
>
> regards,
> dan carpenter
>
--
Thanks,
Mikita Lipski
Software Engineer, AMD
mikita.lipski@amd.com
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bug report] drm/amd/display: Add MST atomic routines
2019-11-13 18:39 ` Mikita Lipski
@ 2019-11-13 18:39 ` Mikita Lipski
0 siblings, 0 replies; 4+ messages in thread
From: Mikita Lipski @ 2019-11-13 18:39 UTC (permalink / raw)
To: Dan Carpenter, mikita.lipski; +Cc: amd-gfx
Hi Dan,
The bug has been fixed by the patch "drm/amd/display: Fix unsigned
variable compared to less than zero" by Gustavo A. R. Silva
Thanks
On 13.11.2019 13:28, Dan Carpenter wrote:
> Hello Mikita Lipski,
>
> The patch b4c578f08378: "drm/amd/display: Add MST atomic routines"
> from Nov 6, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4870 dm_encoder_helper_atomic_check()
> warn: unsigned 'dm_new_connector_state->vcpi_slots' is never less than zero.
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
> 4851 if (!aconnector->port || !aconnector->dc_sink)
> 4852 return 0;
> 4853
> 4854 mst_port = aconnector->port;
> 4855 mst_mgr = &aconnector->mst_port->mst_mgr;
> 4856
> 4857 if (!crtc_state->connectors_changed && !crtc_state->mode_changed)
> 4858 return 0;
> 4859
> 4860 if (!state->duplicated) {
> 4861 color_depth = convert_color_depth_from_display_info(connector, conn_state);
> 4862 bpp = convert_dc_color_depth_into_bpc(color_depth) * 3;
> 4863 clock = adjusted_mode->clock;
> 4864 dm_new_connector_state->pbn = drm_dp_calc_pbn_mode(clock, bpp);
> 4865 }
> 4866 dm_new_connector_state->vcpi_slots = drm_dp_atomic_find_vcpi_slots(state,
> 4867 mst_mgr,
> 4868 mst_port,
> 4869 dm_new_connector_state->pbn);
> 4870 if (dm_new_connector_state->vcpi_slots < 0) {
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Impossible condition.
>
> 4871 DRM_DEBUG_ATOMIC("failed finding vcpi slots: %d\n", (int)dm_new_connector_state->vcpi_slots);
> 4872 return dm_new_connector_state->vcpi_slots;
> 4873 }
> 4874 return 0;
> 4875 }
>
> regards,
> dan carpenter
>
--
Thanks,
Mikita Lipski
Software Engineer, AMD
mikita.lipski@amd.com
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-13 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 18:28 [bug report] drm/amd/display: Add MST atomic routines Dan Carpenter
2019-11-13 18:28 ` Dan Carpenter
[not found] ` <20191113182849.7qzsh2odtr6dw2u3-vMlZ3nK25oGAIHFoDFOv9A@public.gmane.org>
2019-11-13 18:39 ` Mikita Lipski
2019-11-13 18:39 ` Mikita Lipski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).