From: Fenghua Yu <fenghua.yu@intel.com>
To: Felix Kuehling <felix.kuehling@amd.com>
Cc: Yong Zhao <Yong.Zhao@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: drm/amdkfd: Change pasid's type to unsigned int
Date: Fri, 22 May 2020 14:21:25 -0700 [thread overview]
Message-ID: <20200522212125.GB39766@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <d6318005-4860-b82f-e2fc-21fa9f1c1683@amd.com>
Hi, Felix,
On Fri, May 22, 2020 at 03:40:06PM -0400, Felix Kuehling wrote:
> Hi Fenghua,
>
> The PASID width in KFD is currently limited to 16 bits. I believe this
> reflects what our hardware can handle. KFD will never allocate a PASID
> bigger than 16 bits. That said, I'm OK with changing this field in the
> kfd_process structure to unsigned int. Generally, I find uint16_t in
> structures not very useful except in tightly packed structures such as
> packet formats or ioctl arguments.
Thank you very much for your insight!
I'm writing the patch set to define pasid as "unsigned int" consistently
in iommu. I'll put the amdkfd changes (only a few changes including this
pasid change in struct kfd_processin) one patch and send it to you for
review.
-Fenghua
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-05-22 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 19:25 drm/amdkfd: Change pasid's type to unsigned int Fenghua Yu
2020-05-22 19:40 ` Felix Kuehling
2020-05-22 21:21 ` Fenghua Yu [this message]
2020-05-23 3:14 ` Zhao, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522212125.GB39766@romley-ivt3.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=Yong.Zhao@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).