amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Qingqing Zhuo <qingqing.zhuo@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: Eryk.Brol@amd.com, Sunpeng.Li@amd.com, Harry.Wentland@amd.com,
	Qingqing.Zhuo@amd.com, Rodrigo.Siqueira@amd.com,
	Victor Lu <victorchengchi.lu@amd.com>,
	Bhawanpreet.Lakha@amd.com
Subject: [PATCH 17/25] drm/amd/display: Do not warn NULL dc_sink if forcing connector
Date: Tue, 27 Oct 2020 16:52:26 -0400	[thread overview]
Message-ID: <20201027205234.8239-18-qingqing.zhuo@amd.com> (raw)
In-Reply-To: <20201027205234.8239-1-qingqing.zhuo@amd.com>

From: Victor Lu <victorchengchi.lu@amd.com>

[why]
There is a DRM_ERROR when the dc_sink is NULL and
there should not be this warning when the connector
is forced.

[how]
Do not warn if dc_sink is NULL if the connector
is forced.

Signed-off-by: Victor Lu <victorchengchi.lu@amd.com>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 345eb2130869..6b3ae523e62e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -5485,7 +5485,8 @@ enum drm_mode_status amdgpu_dm_connector_mode_valid(struct drm_connector *connec
 
 	dc_sink = to_amdgpu_dm_connector(connector)->dc_sink;
 
-	if (dc_sink == NULL) {
+	if (dc_sink == NULL && aconnector->base.force != DRM_FORCE_ON_DIGITAL &&
+				aconnector->base.force != DRM_FORCE_ON) {
 		DRM_ERROR("dc_sink is NULL!\n");
 		goto fail;
 	}
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2020-10-27 20:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 20:52 [PATCH 00/25] DC Patches Nov 2nd, 2020 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 01/25] drm/amd/display: Fix compilation error Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 02/25] drm/amd/display: Add MPC memory shutdown support for DCN3 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 03/25] drm/amd/display: only check available pipe to disable vbios mode Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 04/25] drm/amd/display: Force prefetch mode to 0 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 05/25] drm/amd/display: Keep GSL for full updates with planes that flip VSYNC Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 06/25] drm/amd/display: [FW Promotion] Release 0.0.39 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 07/25] drm/amd/display: stop top_mgr when type change to non-MST during s3 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 08/25] drm/amd/display: Blank HUBP during pixel data blank for DCN30 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 09/25] drm/amd/display: 3.2.109 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 10/25] drm/amd/display: fail instead of div by zero/bugcheck Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 11/25] drm/amd/display: Update panel register Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 12/25] drm/amd/display: Add OPTC memory low power support Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 13/25] drm/amd/display: correct eDP T9 delay Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 14/25] drm/amd/display: Update connector on DSC property change Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 15/25] drm/amd/display: Reset flip_immediate to topmost plane Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 16/25] drm/amd/display: Blank HUBP during pixel data blank for DCN30 v2 Qingqing Zhuo
2020-10-27 20:52 ` Qingqing Zhuo [this message]
2020-10-27 20:52 ` [PATCH 18/25] drm/amd/display: Calculate CRC on specific frame region Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 19/25] drm/amd/display: WA to ensure MUX chip gets SUPPORTED_LINK_RATES of eDP Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 20/25] drm/amd/display: Revert HUBP blank behaviour for now Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 21/25] drm/amd/display: set hdcp1 wa re-auth delay to 200ms Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 22/25] drm/amd/display: Add missing pflip irq Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 23/25] drm/amd/display: [FW Promotion] Release 0.0.40 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 24/25] drm/amd/display: 3.2.110 Qingqing Zhuo
2020-10-27 20:52 ` [PATCH 25/25] drm/amd/display: fix recout calculation for left side clip Qingqing Zhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027205234.8239-18-qingqing.zhuo@amd.com \
    --to=qingqing.zhuo@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Eryk.Brol@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=victorchengchi.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).