* [PATCH] drm/amdkfd: handle errors returned by svm_migrate_copy_to_vram/ram
@ 2021-05-05 17:55 Philip Yang
2021-05-05 20:11 ` Felix Kuehling
0 siblings, 1 reply; 2+ messages in thread
From: Philip Yang @ 2021-05-05 17:55 UTC (permalink / raw)
To: amd-gfx; +Cc: Philip Yang
If migration copy failed because process is killed, or out of VRAM or
system memory, pass error code back to caller to handle error
gracefully.
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
index bc2fc528ad58..fd8f544f0de2 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
@@ -460,8 +460,8 @@ svm_migrate_vma_to_vram(struct amdgpu_device *adev, struct svm_range *prange,
}
if (migrate.cpages) {
- svm_migrate_copy_to_vram(adev, prange, &migrate, &mfence,
- scratch);
+ r = svm_migrate_copy_to_vram(adev, prange, &migrate, &mfence,
+ scratch);
migrate_vma_pages(&migrate);
svm_migrate_copy_done(adev, mfence);
migrate_vma_finalize(&migrate);
@@ -663,8 +663,8 @@ svm_migrate_vma_to_ram(struct amdgpu_device *adev, struct svm_range *prange,
pr_debug("cpages %ld\n", migrate.cpages);
if (migrate.cpages) {
- svm_migrate_copy_to_ram(adev, prange, &migrate, &mfence,
- scratch);
+ r = svm_migrate_copy_to_ram(adev, prange, &migrate, &mfence,
+ scratch);
migrate_vma_pages(&migrate);
svm_migrate_copy_done(adev, mfence);
migrate_vma_finalize(&migrate);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdkfd: handle errors returned by svm_migrate_copy_to_vram/ram
2021-05-05 17:55 [PATCH] drm/amdkfd: handle errors returned by svm_migrate_copy_to_vram/ram Philip Yang
@ 2021-05-05 20:11 ` Felix Kuehling
0 siblings, 0 replies; 2+ messages in thread
From: Felix Kuehling @ 2021-05-05 20:11 UTC (permalink / raw)
To: Philip Yang, amd-gfx
Am 2021-05-05 um 1:55 p.m. schrieb Philip Yang:
> If migration copy failed because process is killed, or out of VRAM or
> system memory, pass error code back to caller to handle error
> gracefully.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> index bc2fc528ad58..fd8f544f0de2 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> @@ -460,8 +460,8 @@ svm_migrate_vma_to_vram(struct amdgpu_device *adev, struct svm_range *prange,
> }
>
> if (migrate.cpages) {
> - svm_migrate_copy_to_vram(adev, prange, &migrate, &mfence,
> - scratch);
> + r = svm_migrate_copy_to_vram(adev, prange, &migrate, &mfence,
> + scratch);
> migrate_vma_pages(&migrate);
> svm_migrate_copy_done(adev, mfence);
> migrate_vma_finalize(&migrate);
> @@ -663,8 +663,8 @@ svm_migrate_vma_to_ram(struct amdgpu_device *adev, struct svm_range *prange,
> pr_debug("cpages %ld\n", migrate.cpages);
>
> if (migrate.cpages) {
> - svm_migrate_copy_to_ram(adev, prange, &migrate, &mfence,
> - scratch);
> + r = svm_migrate_copy_to_ram(adev, prange, &migrate, &mfence,
> + scratch);
> migrate_vma_pages(&migrate);
> svm_migrate_copy_done(adev, mfence);
> migrate_vma_finalize(&migrate);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-05 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 17:55 [PATCH] drm/amdkfd: handle errors returned by svm_migrate_copy_to_vram/ram Philip Yang
2021-05-05 20:11 ` Felix Kuehling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).